From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D44DC433ED for ; Fri, 14 May 2021 18:49:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3B29613C8 for ; Fri, 14 May 2021 18:49:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3B29613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AC426B006C; Fri, 14 May 2021 14:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20E4D6B006E; Fri, 14 May 2021 14:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D61C6B0070; Fri, 14 May 2021 14:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id C84CA6B006C for ; Fri, 14 May 2021 14:49:01 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4D0DD18044618 for ; Fri, 14 May 2021 18:49:01 +0000 (UTC) X-FDA: 78140723682.40.006B813 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 87624A000384 for ; Fri, 14 May 2021 18:49:00 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id v5so24679223edc.8 for ; Fri, 14 May 2021 11:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7aNLIovxf+Lwl2dDT23aHwbYOgVzois5ZTVGpET054M=; b=nJ/gKAjPe73iJPGorvByKq8jQYg4dGDJBGV79XPXTaGWXxm5cDmPA71RajP0geXSaR n2GUFRwdB0WwuKIVznZ9oT03lGXgaJfNCXtquEds/vTzerea4D8zFKh4BFdivCWBZWDY wlaOI+GTW+C93K0zCmVc2xg9FN+7FWb3J/W7e/KQq0eyT8hNmA5MojmGvcpJAODU6Fn+ 3D2h8X98i+ID6KOPux9F7Z0AJryOnb4SeFrKdOXdWnP9sMRmMqLlBlZazXHq0nM+5ew3 vQEQqetc/f/FoRUnKhv0Jz9a+2MJXBfXfJppsI7VHcqTsy2hsDv1KtK0077YBgLvjv9a qRIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7aNLIovxf+Lwl2dDT23aHwbYOgVzois5ZTVGpET054M=; b=mu5XxZYW2CqztMDZ+zvYQbGEXNdyJGTCVGQRxhJA4087utLvb9gJ3nvgkEeybAh/YO dnwXuDPuN22ChzxogiX9G4NH7p1fkzr7QquE7wYlhdNPw6vPefAnxC1jkac6zd1hzk2K +DEEX4AudMARD4nv1o2njWRDgN4kTzpQ8HSJ/rZyiKUgJBfK34hhZCR7hmfUpurhq99H qWhY54Jf4jSUQd8tbYEoxbuuhmu4CEBdLYkunmSRa71pr8rAjrZ6Pm4WToJWQUnslBJo Hi+vjUGO0W47KqrHe1ZMGPDgEs4JPdmMD9Vnhuj8iHBZ5wIu0LCeo6ZZAVPiw293kgEn 8Dfw== X-Gm-Message-State: AOAM530bjcFv3tA5VJg3oC9iYgiw7SyFy524Oxs39Cfpb9uW3ZWos3JU UedBz87VDPwaH9KSpZsMOcBZub73NOJNmKC5+Q8= X-Google-Smtp-Source: ABdhPJzce0dSO7tXlZ1ThLB+caoxeXowCVqwqTekqw/baZQbfEgFjlrEE3zU1qcFlrYCGoCDguvCVqWS9qeRw7EVa50= X-Received: by 2002:aa7:d818:: with SMTP id v24mr13415385edq.290.1621018139677; Fri, 14 May 2021 11:48:59 -0700 (PDT) MIME-Version: 1.0 References: <20210514065912.71734-1-pulehui@huawei.com> In-Reply-To: <20210514065912.71734-1-pulehui@huawei.com> From: Yang Shi Date: Fri, 14 May 2021 11:48:48 -0700 Message-ID: Subject: Re: [PATCH -next] mm/huge_memory.c: remove unused variable 'count' To: Pu Lehui Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="nJ/gKAjP"; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 87624A000384 X-Stat-Signature: 678cnemwahdeb1yjhy4oum8jtqcgfeq9 X-HE-Tag: 1621018140-295612 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 13, 2021 at 11:59 PM Pu Lehui wrote: > > mm/huge_memory.c:2663:6: warning: > variable =E2=80=98count=E2=80=99 set but not used [-Wunused-but-set-vari= able] > 2663 | int count, mapcount, extra_pins, ret; > | ^~~~~ > > This variable is not used in function , this commit > remove it to fix the warning. Thanks for catching this warning. Not sure why my gcc 10 doesn't catch this warning at all. What compiler are you using? Andrew, the compile warning was introduced by my mm-thp-check-total_mapcount-instead-of-page_mapcount.patch. > > Signed-off-by: Pu Lehui > --- > mm/huge_memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 52ca04b905cf..a23a127302e9 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2660,7 +2660,7 @@ int split_huge_page_to_list(struct page *page, stru= ct list_head *list) > struct deferred_split *ds_queue =3D get_deferred_split_queue(head= ); > struct anon_vma *anon_vma =3D NULL; > struct address_space *mapping =3D NULL; > - int count, mapcount, extra_pins, ret; > + int mapcount, extra_pins, ret; > pgoff_t end; > > VM_BUG_ON_PAGE(is_huge_zero_page(head), head); > @@ -2737,7 +2737,6 @@ int split_huge_page_to_list(struct page *page, stru= ct list_head *list) > > /* Prevent deferred_split_scan() touching ->_refcount */ > spin_lock(&ds_queue->split_queue_lock); > - count =3D page_count(head); > mapcount =3D total_mapcount(head); > if (!mapcount && page_ref_freeze(head, 1 + extra_pins)) { > if (!list_empty(page_deferred_list(head))) { > -- > 2.17.1 > >