From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9503C433DB for ; Tue, 9 Mar 2021 00:17:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6050465275 for ; Tue, 9 Mar 2021 00:17:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6050465275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D92718D0095; Mon, 8 Mar 2021 19:17:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D433D8D007F; Mon, 8 Mar 2021 19:17:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE4998D0095; Mon, 8 Mar 2021 19:17:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id A35418D007F for ; Mon, 8 Mar 2021 19:17:33 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 585703A82 for ; Tue, 9 Mar 2021 00:17:33 +0000 (UTC) X-FDA: 77898421986.23.1B7D102 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf10.hostedemail.com (Postfix) with ESMTP id ECD134080F44 for ; Tue, 9 Mar 2021 00:17:29 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id ox4so8397228ejb.11 for ; Mon, 08 Mar 2021 16:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k7EiN3DgkaHZ8scB2/qM/k5IdjZOxSdMnEZ5/Sc78dw=; b=YbU0RBEXMLfpVpcZUY6xISifozTY6p+sHGHwsPU47KJoXSwcFEfCiTqYHlGr8fEtDe qxQbVfavAaNAK6VcGEryAevXOZ+8QwYTEertv1L7jlnVx3KVJGiY1fZk62G6/zFg1xWR nQqeD7yH4h5MwJ44e21vLT1uZbjH7S50Yd4L72gZY54HWH1EbXfGO0ariimxzlPkF5zK 33WHFzniwdhylFHImcOOmtLqVH1A1lc/UJWf6+soogYyB9d+OmbGR/IG/H3y5aYyXUNd HjmcJaSAzKNiMwKTk1LWgkr2dubvtMfK5M6Z8UX6eXeInF/ukJ/8q+JYQ0CK18WVakNe 9fBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k7EiN3DgkaHZ8scB2/qM/k5IdjZOxSdMnEZ5/Sc78dw=; b=oD2sJyCcOoDDkj23zMtqRKpkYEso6jlVgKqt0LJqpMdaxcv4pe3lqNoJvVStG8A9Gn 7WGxAaSqcnFU51swN1pCpZb6xpANqczLDOC4ze+waauZIw8xMR8xarCgY9CswlFPppnI If8jgkfLAbOdP3kD4oe7IrvC6/1jgutszJ+jb+/KStjy8c741qkUAUnSbypgn5q6JH8T VL/tR+kvq5I6msJfaeyxMy9q5yGMVHL/Pt3LhFszMoz2lAW9YvyyUmV/ETUgypHo8T/t eFAPv2ZPZXgtlbmpS72ByvODRHkWOe0Vpku6We95xR7CpnwZBv+mdpqdrB5xRsNGlhlF 9MsA== X-Gm-Message-State: AOAM530W2tkiaTOXcevy5tsiQM9KH88qDsxLW6ettPxPn8PR54RBkLmh utlQpv5bGdxpNKB+WtoErD3oRM+bkViqOrjGnYU= X-Google-Smtp-Source: ABdhPJwN2myOdpLfbf4qxciTvRKt6ddcGGZKYJVMBmLecE1FSjT5L5w3cghE+C3qCe6auORmyA+2q+fbNLfW58j81Pw= X-Received: by 2002:a17:906:bcfc:: with SMTP id op28mr17041587ejb.238.1615249051778; Mon, 08 Mar 2021 16:17:31 -0800 (PST) MIME-Version: 1.0 References: <20210304235949.7922C1C3@viggo.jf.intel.com> <20210305000004.20A8D23F@viggo.jf.intel.com> In-Reply-To: <20210305000004.20A8D23F@viggo.jf.intel.com> From: Yang Shi Date: Mon, 8 Mar 2021 16:17:20 -0800 Message-ID: Subject: Re: [PATCH 08/10] mm/vmscan: Consider anonymous pages without swap To: Dave Hansen Cc: Linux Kernel Mailing List , Linux MM , kbusch@kernel.org, Yang Shi , David Rientjes , Huang Ying , Dan Williams , David Hildenbrand , Oscar Salvador Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ECD134080F44 X-Stat-Signature: 337hejjdbfbfr7h7oef6tg91k7i4wns1 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-ej1-f46.google.com; client-ip=209.85.218.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615249049-676593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 4, 2021 at 4:01 PM Dave Hansen wrote: > > > From: Keith Busch > > Reclaim anonymous pages if a migration path is available now that > demotion provides a non-swap recourse for reclaiming anon pages. > > Note that this check is subtly different from the > anon_should_be_aged() checks. This mechanism checks whether a > specific page in a specific context *can* actually be reclaimed, given > current swap space and cgroup limits > > anon_should_be_aged() is a much simpler and more prelimiary check Just a typo, s/prelimiary/preliminary > which just says whether there is a possibility of future reclaim. Reviewed-by: Yang Shi > > #Signed-off-by: Keith Busch > Cc: Keith Busch > Signed-off-by: Dave Hansen > Cc: Yang Shi > Cc: David Rientjes > Cc: Huang Ying > Cc: Dan Williams > Cc: David Hildenbrand > Cc: osalvador > > -- > > Changes from Dave 10/2020: > * remove 'total_swap_pages' modification > > Changes from Dave 06/2020: > * rename reclaim_anon_pages()->can_reclaim_anon_pages() > > Note: Keith's Intel SoB is commented out because he is no > longer at Intel and his @intel.com mail will bounce. > --- > > b/mm/vmscan.c | 35 ++++++++++++++++++++++++++++++++--- > 1 file changed, 32 insertions(+), 3 deletions(-) > > diff -puN mm/vmscan.c~0009-mm-vmscan-Consider-anonymous-pages-without-swap mm/vmscan.c > --- a/mm/vmscan.c~0009-mm-vmscan-Consider-anonymous-pages-without-swap 2021-03-04 15:35:59.994806420 -0800 > +++ b/mm/vmscan.c 2021-03-04 15:36:00.001806420 -0800 > @@ -287,6 +287,34 @@ static bool writeback_throttling_sane(st > } > #endif > > +static inline bool can_reclaim_anon_pages(struct mem_cgroup *memcg, > + int node_id) > +{ > + if (memcg == NULL) { > + /* > + * For non-memcg reclaim, is there > + * space in any swap device? > + */ > + if (get_nr_swap_pages() > 0) > + return true; > + } else { > + /* Is the memcg below its swap limit? */ > + if (mem_cgroup_get_nr_swap_pages(memcg) > 0) > + return true; > + } > + > + /* > + * The page can not be swapped. > + * > + * Can it be reclaimed from this node via demotion? > + */ > + if (next_demotion_node(node_id) >= 0) > + return true; > + > + /* No way to reclaim anon pages */ > + return false; > +} > + > /* > * This misses isolated pages which are not accounted for to save counters. > * As the data only determines if reclaim or compaction continues, it is > @@ -298,7 +326,7 @@ unsigned long zone_reclaimable_pages(str > > nr = zone_page_state_snapshot(zone, NR_ZONE_INACTIVE_FILE) + > zone_page_state_snapshot(zone, NR_ZONE_ACTIVE_FILE); > - if (get_nr_swap_pages() > 0) > + if (can_reclaim_anon_pages(NULL, zone_to_nid(zone))) > nr += zone_page_state_snapshot(zone, NR_ZONE_INACTIVE_ANON) + > zone_page_state_snapshot(zone, NR_ZONE_ACTIVE_ANON); > > @@ -2332,6 +2360,7 @@ enum scan_balance { > static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > unsigned long *nr) > { > + struct pglist_data *pgdat = lruvec_pgdat(lruvec); > struct mem_cgroup *memcg = lruvec_memcg(lruvec); > unsigned long anon_cost, file_cost, total_cost; > int swappiness = mem_cgroup_swappiness(memcg); > @@ -2342,7 +2371,7 @@ static void get_scan_count(struct lruvec > enum lru_list lru; > > /* If we have no swap space, do not bother scanning anon pages. */ > - if (!sc->may_swap || mem_cgroup_get_nr_swap_pages(memcg) <= 0) { > + if (!sc->may_swap || !can_reclaim_anon_pages(memcg, pgdat->node_id)) { > scan_balance = SCAN_FILE; > goto out; > } > @@ -2717,7 +2746,7 @@ static inline bool should_continue_recla > */ > pages_for_compaction = compact_gap(sc->order); > inactive_lru_pages = node_page_state(pgdat, NR_INACTIVE_FILE); > - if (get_nr_swap_pages() > 0) > + if (can_reclaim_anon_pages(NULL, pgdat->node_id)) > inactive_lru_pages += node_page_state(pgdat, NR_INACTIVE_ANON); > > return inactive_lru_pages > pages_for_compaction; > _ >