From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F2BC433DB for ; Tue, 23 Mar 2021 17:46:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A74661931 for ; Tue, 23 Mar 2021 17:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A74661931 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3B056B0278; Tue, 23 Mar 2021 13:46:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEB756B0279; Tue, 23 Mar 2021 13:46:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8CE16B027A; Tue, 23 Mar 2021 13:46:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 9CE1A6B0278 for ; Tue, 23 Mar 2021 13:46:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4C6F68249980 for ; Tue, 23 Mar 2021 17:46:52 +0000 (UTC) X-FDA: 77951869464.01.9B4288C Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 09B344080F59 for ; Tue, 23 Mar 2021 17:46:50 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id kt15so19032585ejb.12 for ; Tue, 23 Mar 2021 10:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ql4xcjbxDiQewQBjoY2RWA9a9mOAjHNHjjlKvX5iKME=; b=ImQ/kiWhqm2FHjRW4oVru2YORFDIcuEufuObYX9u2FjTzqYgYl6/r+JWf6xVtdTz2u 7AU6abiSQGDTT7olhxvb6fgkSt7EelRi/m7lBYnOoYzmq+N6bwBvzfhamelCfOTKlKle 94UAtK9vvgLBgLB2JkZPoTsTnbiIp05/3xP8smzwihxYVzAP+gS/E9HrRpzqNq8onYCH N6xrpljENJkRbmx++O8szjm5Yptf9M+IQ5PegIQH8voLWKR9AW3xgdeoauIT7JLEsOJd 9eLo41s0uq/w0dFZVtNXmypUl0lDG4ZDlWSDdKAzbnjDG9q0qgF2pnf6fVPUNs6NuRIx gkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ql4xcjbxDiQewQBjoY2RWA9a9mOAjHNHjjlKvX5iKME=; b=ZVmlWHaUCef4tSu5fjCKjgmnJ8TYli6TsmKABpRoCnT+9nCsvQV9frJuzEPgeW/zUr PeQYsphEGU13kIW3kA200jV4d+cSJEgu92/XUfeld8+h0PlmWeDssQBcjio/HUuJbJ0F 1uS5S6x7EwK62vxSilVfKtgyFen4kr8+lxlO33BBB5rX72GOTThp4uP6pHNd1rWwKcBS qW9vE2SdyMweEWkQm7owKjtaUKvCxtlMeTeBUBS/y+hFnngRrKwKAgcMw7uG/d23XseM CAvSCbGVnviWBHJjODyGFfGuLJyK1E08uS28fgsVA2lUsBdpfMi+RVY4HhR8Tl2Q4DKz wyuw== X-Gm-Message-State: AOAM533Yw+RtiQAE4M35uE2ksCVXBn5QDQjbjyw4lMpiEEuMFyoi4KYM 1fdz+KPGxMVNW48VEVAsWKhV/fWdFuYwoyakxoXgB9QA X-Google-Smtp-Source: ABdhPJxzFOGovvGm7xPD0TAOzpfYJ7X7k6cVcDxxZ6cFVl+Mf2WmiyLIAIKDWgQsgMBVjCyZho29t1+GVrcC1UKB3GE= X-Received: by 2002:a17:906:bcfc:: with SMTP id op28mr6035782ejb.238.1616521610786; Tue, 23 Mar 2021 10:46:50 -0700 (PDT) MIME-Version: 1.0 References: <20210323135405.65059-1-linmiaohe@huawei.com> <20210323135405.65059-3-linmiaohe@huawei.com> In-Reply-To: <20210323135405.65059-3-linmiaohe@huawei.com> From: Yang Shi Date: Tue, 23 Mar 2021 10:46:39 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm/migrate.c: remove unnecessary rc != MIGRATEPAGE_SUCCESS check in 'else' case To: Miaohe Lin Cc: Andrew Morton , Jerome Glisse , Rafael Aquini , David Hildenbrand , Alistair Popple , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09B344080F59 X-Stat-Signature: 6ohapqrpexfje8xba5bfidocxh94f53d Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail-ej1-f52.google.com; client-ip=209.85.218.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616521610-214958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 23, 2021 at 6:54 AM Miaohe Lin wrote: > > It's guaranteed that in the 'else' case of the rc == MIGRATEPAGE_SUCCESS > check, rc does not equal to MIGRATEPAGE_SUCCESS. Remove this unnecessary > check. Reviewed-by: Yang Shi > > Reviewed-by: David Hildenbrand > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index facec65c7374..97da1fabdf72 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1374,7 +1374,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > out: > if (rc == MIGRATEPAGE_SUCCESS) > putback_active_hugepage(hpage); > - else if (rc != -EAGAIN && rc != MIGRATEPAGE_SUCCESS) > + else if (rc != -EAGAIN) > list_move_tail(&hpage->lru, ret); > > /* > -- > 2.19.1 >