From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD98C433DF for ; Thu, 13 Aug 2020 05:19:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E72B320829 for ; Thu, 13 Aug 2020 05:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CFOxOzMH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72B320829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 042686B0006; Thu, 13 Aug 2020 01:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F33936B0007; Thu, 13 Aug 2020 01:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFCA86B0008; Thu, 13 Aug 2020 01:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id C598F6B0006 for ; Thu, 13 Aug 2020 01:19:38 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 58C7A52BF for ; Thu, 13 Aug 2020 05:19:38 +0000 (UTC) X-FDA: 77144392836.14.chain99_3f0bd8c26ff1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 27A8218229818 for ; Thu, 13 Aug 2020 05:19:38 +0000 (UTC) X-HE-Tag: chain99_3f0bd8c26ff1 X-Filterd-Recvd-Size: 4959 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Aug 2020 05:19:37 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id t15so3186302edq.13 for ; Wed, 12 Aug 2020 22:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c67l/Kh4PrxDU+p63GZTC7eyIKKS3Nmd1e/4JTBchUQ=; b=CFOxOzMHsFHIuClJ7Zta78lgA88l2r2iwbskY7fQim0eEZPYIowmnsurp72VuktPH8 fOZOUOPclufD0ZeU68VhjMeG15uPxNmHYNVD4PEas4ZtBsv6hitG+i7Qa9KabQFtjjTE 8CfD2vYjPb6EQLvugzOTG6yVARndLkyIuEJ0N6avAVPo6obJK9Zu8kRgQ3p9MpnBXdfC 87gC+Q3ec2CG6HmoH1NQ32hP4IGjcmEB3N6j6r/5AcgGp30iaSHRkElLNCJmpe3OOkc0 3d/ueLu/zxnAAhDH4gfMvSa+0jSm/G79KBhqqTBRUfm4y1XJrAGVlGzei5s8gTDvxRD+ Xu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c67l/Kh4PrxDU+p63GZTC7eyIKKS3Nmd1e/4JTBchUQ=; b=o386RoMWGw755W4RpKGsCH6YT5p1jX3IiHWS9QhiS4yUboddmy/2FTmgXAO+NPS8+4 mu3YiNOJdkZiHtU+OAe7wlNjxqNigwqml3Dh9sJyFPPiIE1BQublwaaIRjTRCNvCF1Ue Lfu9/P+InsIjVCbeKrtNWSh2m5v0f4jDP95FWKh5OG5WRahzZOfMp/+U/3JBmFXzKbA7 zV+Q6NL268voPM/6C0Iv506rzJhCTzbNWk39292MBP7rpZUbKIQzxdFpnkKe1/Imuvjl vJ+Z3efeXiE1peLR2LsAKIp0qKlAzgs12TNTgTEVpAGzwa2xMd04sKE30rDP8GJlnXGF 0sfw== X-Gm-Message-State: AOAM532V7qe0FqvuMUgpxGfdDqPSolUF2x5OZXdTiQou2qYETeh7qZbG GG0rgBce68CnC60k6Ubxd3nffnugv68Al8xAWeU= X-Google-Smtp-Source: ABdhPJzUvmd5BZyQ3p133JmD0914kUtVo6A4n698OGvGsmcdjPh+owzaduroH3A/XF4aNic2WDuoOduAgYsi6JUcTtA= X-Received: by 2002:a05:6402:2038:: with SMTP id ay24mr3207332edb.200.1597295976320; Wed, 12 Aug 2020 22:19:36 -0700 (PDT) MIME-Version: 1.0 References: <20200812040423.2707213-1-yuzhao@google.com> In-Reply-To: <20200812040423.2707213-1-yuzhao@google.com> From: Yang Shi Date: Wed, 12 Aug 2020 22:19:24 -0700 Message-ID: Subject: Re: [PATCH 1/3] mm: don't call activate_page() on new ksm pages To: Yu Zhao Cc: Andrew Morton , Alexander Duyck , Huang Ying , David Hildenbrand , Michal Hocko , Yang Shi , Qian Cai , Mel Gorman , Nicholas Piggin , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Hugh Dickins , Linux MM , Linux Kernel Mailing List , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 27A8218229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 11, 2020 at 9:04 PM Yu Zhao wrote: > > lru_cache_add_active_or_unevictable() already adds new ksm pages to > active lru. Calling activate_page() isn't really necessary in this > case. > > Signed-off-by: Yu Zhao > --- > mm/swapfile.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 6c26916e95fd..cf115ea26a20 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1913,16 +1913,16 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > pte_mkold(mk_pte(page, vma->vm_page_prot))); > if (page == swapcache) { > page_add_anon_rmap(page, vma, addr, false); > + /* > + * Move the page to the active list so it is not > + * immediately swapped out again after swapon. > + */ > + activate_page(page); Actually I think we could just remove this activate_page() call with Joonsoo's anonymous page workingset series merged. The active bit will be taken care by workingset_refault(). > } else { /* ksm created a completely new copy */ > page_add_new_anon_rmap(page, vma, addr, false); > lru_cache_add_active_or_unevictable(page, vma); And it looks the latest linus's tree already changed this to lru_cache_add_inactive_or_unevictable() by commit b518154e59 ("mm/vmscan: protect the workingset on anonymous LRU") Added Joonsoo in this loop. > } > swap_free(entry); > - /* > - * Move the page to the active list so it is not > - * immediately swapped out again after swapon. > - */ > - activate_page(page); > out: > pte_unmap_unlock(pte, ptl); > if (page != swapcache) { > -- > 2.28.0.236.gb10cc79966-goog > >