From: Yang Shi <shy828301@gmail.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Rik van Riel <riel@surriel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Matthew Wilcox <willy@infradead.org>,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH v2] mm: align larger anonymous mappings on THP boundaries
Date: Thu, 18 Jan 2024 10:42:12 -0800 [thread overview]
Message-ID: <CAHbLzkq_ZSoA-DT=qtENMNpU1cgVacXsyWDjLxGFHzsn7bFXNg@mail.gmail.com> (raw)
In-Reply-To: <CAJuCfpFKLfMM16VbzdaEHaMELgB2pAo6_t1OKsRO80BL2iAzsg@mail.gmail.com>
On Thu, Jan 18, 2024 at 9:48 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Wed, Jan 17, 2024 at 11:05 PM Jiri Slaby <jirislaby@kernel.org> wrote:
> >
> > On 18. 01. 24, 1:07, Yang Shi wrote:
> > >> This works around the problem, of course (but is a band-aid, not a fix):
> > >>
> > >> --- a/mm/mmap.c
> > >> +++ b/mm/mmap.c
> > >> @@ -1829,7 +1829,7 @@ get_unmapped_area(struct file *file, unsigned long
> > >> addr, unsigned long len,
> > >> */
> > >> pgoff = 0;
> > >> get_area = shmem_get_unmapped_area;
> > >> - } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
> > >> + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
> > >> !in_32bit_syscall()) {
> > >> /* Ensures that larger anonymous mappings are THP
> > >> aligned. */
> > >> get_area = thp_get_unmapped_area;
> > >> }
> > >>
> > >>
> > >> thp_get_unmapped_area() does not take care of the legacy stuff...
> > >
> > > Could you please help test the below patch? It is compiled, but I
> > > don't have 32 bit userspace or machine to test it.
> >
> > Yeah, for x86_64, it's semantically the same as the above, so this works
> > too:
> >
> > Tested-by: Jiri Slaby <jirislaby@kernel.org>
>
> With the addition of #include <linux/compat.h> it builds and passes
> our tests as well. Thanks!
>
> Tested-by: Suren Baghdasaryan <surenb@google.com>
Thanks for checking the test case and testing the patch. I will fix it
and post the formal patch.
>
> >
> > > --- a/mm/huge_memory.c
> > > +++ b/mm/huge_memory.c
> > > @@ -811,6 +811,9 @@ static unsigned long
> > > __thp_get_unmapped_area(struct file *filp,
> > > loff_t off_align = round_up(off, size);
> > > unsigned long len_pad, ret;
> > >
> > > + if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall())
> > > + return 0;
> > > +
> > > if (off_end <= off_align || (off_end - off_align) < size)
> > > return 0;
> >
> > thanks,
> > --
> > js
> > suse labs
> >
> >
next prev parent reply other threads:[~2024-01-18 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:24 [PATCH v2] mm: align larger anonymous mappings on THP boundaries Rik van Riel
2022-08-10 17:06 ` Yang Shi
2024-01-16 11:53 ` Jiri Slaby
2024-01-16 12:09 ` Jiri Slaby
2024-01-16 19:16 ` Suren Baghdasaryan
2024-01-16 20:56 ` Yang Shi
2024-01-16 21:57 ` Suren Baghdasaryan
2024-01-16 22:25 ` Yang Shi
2024-01-16 22:30 ` Suren Baghdasaryan
2024-01-16 23:14 ` Yang Shi
2024-01-17 17:40 ` Kees Cook
2024-01-17 23:32 ` Yang Shi
2024-01-18 0:01 ` Suren Baghdasaryan
2024-01-18 0:13 ` Yang Shi
2024-01-18 0:29 ` Suren Baghdasaryan
2024-01-18 1:34 ` Suren Baghdasaryan
2024-01-18 2:10 ` Suren Baghdasaryan
2024-01-16 20:55 ` Yang Shi
2024-01-18 0:07 ` Yang Shi
2024-01-18 0:09 ` Suren Baghdasaryan
2024-01-18 0:11 ` Suren Baghdasaryan
2024-01-18 0:15 ` Yang Shi
2024-01-18 0:28 ` Suren Baghdasaryan
2024-01-18 7:04 ` Jiri Slaby
2024-01-18 17:48 ` Suren Baghdasaryan
2024-01-18 18:42 ` Yang Shi [this message]
2024-01-18 18:42 ` Yang Shi
2024-01-20 13:43 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-01-20 15:47 ` Linux regression tracking #adding (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkq_ZSoA-DT=qtENMNpU1cgVacXsyWDjLxGFHzsn7bFXNg@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jirislaby@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).