From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7893C3F2C6 for ; Tue, 3 Mar 2020 19:05:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B85120866 for ; Tue, 3 Mar 2020 19:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AhnqSv2z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B85120866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 111C26B0005; Tue, 3 Mar 2020 14:05:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09B126B0006; Tue, 3 Mar 2020 14:05:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA5156B0007; Tue, 3 Mar 2020 14:05:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id CEF1B6B0005 for ; Tue, 3 Mar 2020 14:05:14 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3FBB38248D51 for ; Tue, 3 Mar 2020 19:05:14 +0000 (UTC) X-FDA: 76554978948.11.legs03_2dafe1b2a3d0e X-HE-Tag: legs03_2dafe1b2a3d0e X-Filterd-Recvd-Size: 4442 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 19:05:13 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id e25so5784924edq.5 for ; Tue, 03 Mar 2020 11:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nmU+4k6YjovxnqibV6q5K31wq03slTYnA1JtrVeX4rk=; b=AhnqSv2z/IK5h27bFyYak13H7lJPCerRJb1TaDNPXiMskdjEpynPLxPTtDccbzL/Sc J+kcMxPK0EcO0ufi3ItB8tsEN8yFmgrkvKEmhpkpXoIKEvl6QSQ9UrIWFqoG0iySiSON wF3jPD3w09SJ3bym+QScisaMdHOOcol9i4vMKrejIk1V9tLiEhRY0IYuQBCfW5tzv51i X3/JcEX0cpiopVK4hHw054mG03ULSierJaew+JYiskB82PcKaK/KUqCLKTgdPXBmQery 0siMC1xT9TdzdRQO371i7A0lleM3q9M/AL9MDkx3cmIZboV10BdDfUIZzWt8EXVTFL0+ JECQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nmU+4k6YjovxnqibV6q5K31wq03slTYnA1JtrVeX4rk=; b=lz/WJt9B8cUSYh/2oXfGDhG+2BedjlJcBDO62yP4+3spVGDIbiM1ZajCAVt0RxDD04 Fh3eM4NRxBpwzqbjyDQDczB8ODX9KjV3MdsTG98DySS9SnLZgzn1PJGs5yomq/bFMR52 eHSXfik0GufExXutgNrZ35qzkEfflg93VQjk8xb+q9N4eAB+bQcji1+OttJ8JOa0uHK2 Q9Uw9qnU5O0bmx95EeYoYwaHmPRoYFNFNOTkT4dcZMpq4YGodrlr8p7YRqE5KmHGrvFO t6sFUGbuLzkvQcO+Uxt/hfK6EMjpGvigqk8Gd+zU3fPndAMjYGDPsQwXkAjeEpWPJyt1 Sknw== X-Gm-Message-State: ANhLgQ3i+O/ZFtwjfpeteF+ZXfsfVjhUE5dBDUS83y3wiLmo6MsH/IAl PnNSTvo3gixUdhPgX4nsYztu9yBXCYD5V0Xkdgc= X-Google-Smtp-Source: ADFU+vvrrO9j1cXlgCLMga/KBUFPhIux7Pkc1Co+ufl4gUM+coqSFyjVBQcPp2ZanVEJ70ZfySHKaCG8Pc8fxUQj5Pc= X-Received: by 2002:a17:906:1e12:: with SMTP id g18mr4947220ejj.309.1583262312846; Tue, 03 Mar 2020 11:05:12 -0800 (PST) MIME-Version: 1.0 References: <0a37bb7d-18a7-c43c-52a5-f13a34decf69@i-love.sakura.ne.jp> In-Reply-To: From: Yang Shi Date: Tue, 3 Mar 2020 11:04:56 -0800 Message-ID: Subject: Re: fs/buffer.c: WARNING: alloc_page_buffers while mke2fs To: Naresh Kamboju Cc: Tetsuo Handa , linux-mm , Andrew Morton , Mel Gorman , Michal Hocko , Shakeel Butt , schatzberg.dan@gmail.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 3, 2020 at 10:40 AM Naresh Kamboju wrote: > > On Tue, 3 Mar 2020 at 23:17, Yang Shi wrote: > > > > On Tue, Mar 3, 2020 at 2:53 AM Tetsuo Handa > > wrote: > > > > > > Hello, Naresh. > > > > > > > [ 98.003346] WARNING: CPU: 2 PID: 340 at > > > > include/linux/sched/mm.h:323 alloc_page_buffers+0x210/0x288 > > > > > > Could you please try the below debug patch? This is not the proper > > fix, but it may help us narrow down the problem. > > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index c49257a..1cc1cdc 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -320,6 +320,10 @@ static inline void > > memalloc_nocma_restore(unsigned int flags) > > */ > > static inline void memalloc_use_memcg(struct mem_cgroup *memcg) > > { > > + if ((current->flags & PF_KTHREAD) && > > + current->active_memcg) > > + return; > > + > > WARN_ON_ONCE(current->active_memcg); > > current->active_memcg = memcg; > > } > > After applying this patch the reported "warning" did not happen. > Here is the full test log. > https://lkft.validation.linaro.org/scheduler/job/1265325#L1287 Thanks for doing testing. We could confirm this is caused by paralleled memalloc_use_memcg(). > > - Naresh