From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4372EC433E0 for ; Mon, 28 Dec 2020 17:31:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5E4C229C4 for ; Mon, 28 Dec 2020 17:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E4C229C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A644C8D0012; Mon, 28 Dec 2020 12:31:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EDBB8D0010; Mon, 28 Dec 2020 12:31:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B6878D0012; Mon, 28 Dec 2020 12:31:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 72A4E8D0010 for ; Mon, 28 Dec 2020 12:31:19 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3E3168249980 for ; Mon, 28 Dec 2020 17:31:19 +0000 (UTC) X-FDA: 77643382278.16.book09_3e0bea727495 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 1EC9E100E6903 for ; Mon, 28 Dec 2020 17:31:19 +0000 (UTC) X-HE-Tag: book09_3e0bea727495 X-Filterd-Recvd-Size: 4544 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Dec 2020 17:31:18 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id d17so15044422ejy.9 for ; Mon, 28 Dec 2020 09:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L6jMggetbrrUEJcKxjzuL9oTosulpOnPLZ2l3XhwKRs=; b=sTNImozLG8IUJ7j7UwjMpqjYlF4QAZZpCW/LSq75Vt0RO1PNnl+NlthpsCUNTS+oEY Oji8WEtUKftUwXdtwbJzUQPnMJGy3Jv4UTXDo6EiV5zRGfTHvxEXGd0GtAD2rOKX8c5J Hb+ec3q1e8ssIeDfVC+hOSCnKd/LiTdq5ZP5h0pMDXO9SKgijrI7UZ5fld2y3w48q7Zu jByVPXR06kOSCI7JBI4qkUv+/ASVdjPP6ai0lrfqwJxiRxO9jtHe8mYAzbmh6RlHdJ+M HL8UADYYuHy/ja4ArNgBGG15iWstN9HGqBT7aEtva3IvIKH77bETrMrW+u+s9Q6mS4/B 6E3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L6jMggetbrrUEJcKxjzuL9oTosulpOnPLZ2l3XhwKRs=; b=IvMWJkWHBPVCqTl8V6bCd3vh946I46jGmcEs3uC2ZcSqf04bJeqDyJCEs6p0d37ycN FHxSX7GT5evPAUTRbxbV5dQkiw7+Ycr5IYqTrivWuz8km5UBBysJmoj3kXWe97BH8W2I JVkPQNIP9dIGUjlS1rGTGAvzJcmJCqyRfoqANnUvoyeWYNdW6d3K4K4WmHL9zB8xYC7c 0y3TP0+8acYGSGkm8lYgcUYVtq23giaO14Aq9ipQ54KSQN1CHC9XTPtZOK5qyZI/E6fB iogRP4KZEzkp74OqZbViUTgJ38FrvGosnmGP2fbImJ8AyNr/toaKMqzEG72YsTXZTGzd UKrw== X-Gm-Message-State: AOAM532rnFWhCyoTmv5FJsoral7nH9jIEKOc9Ae3vdq388ZP6IcYInsV Fopc0oU0Nm70CG4oHtZevxk63+imqJrVqKhN3tE= X-Google-Smtp-Source: ABdhPJwnGEJ77oSQj1FpVI6e1CvKlbyKgsHA+UHCeVILPPWIBeIAH1mKdtiFuhAXf57/MP63eN9cjUHniQLXulXtYgc= X-Received: by 2002:a17:906:b04f:: with SMTP id bj15mr41116505ejb.383.1609176677425; Mon, 28 Dec 2020 09:31:17 -0800 (PST) MIME-Version: 1.0 References: <20201227181310.3235210-1-shakeelb@google.com> In-Reply-To: <20201227181310.3235210-1-shakeelb@google.com> From: Yang Shi Date: Mon, 28 Dec 2020 09:31:05 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat To: Shakeel Butt Cc: Muchun Song , Naoya Horiguchi , Andrew Morton , "Kirill A . Shutemov" , Johannes Weiner , Roman Gushchin , Cgroups , Linux MM , Linux Kernel Mailing List , stable Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 27, 2020 at 10:13 AM Shakeel Butt wrote: > > The kernel updates the per-node NR_FILE_DIRTY stats on page migration > but not the memcg numa stats. That was not an issue until recently the > commit 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface > for cgroup v2") exposed numa stats for the memcg. So fixing the > file_dirty per-memcg numa stat. > > Fixes: 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface for cgroup v2") > Signed-off-by: Shakeel Butt > Cc: Acked-by: Yang Shi > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index ee5e612b4cd8..613794f6a433 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -500,9 +500,9 @@ int migrate_page_move_mapping(struct address_space *mapping, > __inc_lruvec_state(new_lruvec, NR_SHMEM); > } > if (dirty && mapping_can_writeback(mapping)) { > - __dec_node_state(oldzone->zone_pgdat, NR_FILE_DIRTY); > + __dec_lruvec_state(old_lruvec, NR_FILE_DIRTY); > __dec_zone_state(oldzone, NR_ZONE_WRITE_PENDING); > - __inc_node_state(newzone->zone_pgdat, NR_FILE_DIRTY); > + __inc_lruvec_state(new_lruvec, NR_FILE_DIRTY); > __inc_zone_state(newzone, NR_ZONE_WRITE_PENDING); > } > } > -- > 2.29.2.729.g45daf8777d-goog > >