From: Yang Shi <shy828301@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Zi Yan <ziy@nvidia.com>,
nao.horiguchi@gmail.com,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mempolicy: don't have to split pmd for huge zero page
Date: Tue, 8 Jun 2021 12:36:05 -0700 [thread overview]
Message-ID: <CAHbLzkrQdt+gvq-SdQoH8sVVNiSxdMqreTGsrZC4AsVpYzysWQ@mail.gmail.com> (raw)
In-Reply-To: <YL+ttjqJ9lEMndiA@dhcp22.suse.cz>
On Tue, Jun 8, 2021 at 10:49 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Tue 08-06-21 10:15:36, Yang Shi wrote:
> [...]
> > I did some archeology, the findings are:
> >
> > The zero page has PageReserved flag set, it was skipped by the
> > explicit PageReserved check in mempolicy.c since commit f4598c8b3678
> > ("[PATCH] migration: make sure there is no attempt to migrate reserved
> > pages."). The zero page was not used anymore by do_anonymous_page()
> > since 2.6.24 by commit 557ed1fa2620 ("remove ZERO_PAGE"), then
> > reinstated by commit a13ea5b759645 ("mm: reinstate ZERO_PAGE") and
> > this commit added zero page check in vm_normal_page(), so mempolicy
> > doesn't depend on PageReserved check to skip zero page anymore since
> > then.
> >
> > So the zero page is skipped by mempolicy.c since 2.6.16.
>
> Thanks a lot! This is really useful. Can you just add it to the
> changelog so others do not have to go through the painful archeology.
>
> With that, feel free to add
> Acked-by: Michal Hocko <mhocko@suse.com>
Thanks. Will add that into v2.
>
> Thanls!
> --
> Michal Hocko
> SUSE Labs
prev parent reply other threads:[~2021-06-08 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 20:35 [PATCH] mm: mempolicy: don't have to split pmd for huge zero page Yang Shi
2021-06-04 21:23 ` Zi Yan
2021-06-07 6:21 ` Michal Hocko
2021-06-07 17:00 ` Yang Shi
2021-06-07 18:41 ` Yang Shi
2021-06-07 18:55 ` Michal Hocko
2021-06-07 22:02 ` Yang Shi
2021-06-08 6:41 ` Michal Hocko
2021-06-08 17:15 ` Yang Shi
2021-06-08 17:49 ` Michal Hocko
2021-06-08 19:36 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHbLzkrQdt+gvq-SdQoH8sVVNiSxdMqreTGsrZC4AsVpYzysWQ@mail.gmail.com \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).