From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED8E6C433E0 for ; Fri, 7 Aug 2020 20:53:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8BE6C2075A for ; Fri, 7 Aug 2020 20:53:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oMkbbQec" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BE6C2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CEB206B000A; Fri, 7 Aug 2020 16:53:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C755A6B000C; Fri, 7 Aug 2020 16:53:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3EDA6B000D; Fri, 7 Aug 2020 16:53:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 9BB7B6B000A for ; Fri, 7 Aug 2020 16:53:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2E693181AEF10 for ; Fri, 7 Aug 2020 20:53:26 +0000 (UTC) X-FDA: 77124973212.29.stage77_0304c8026fc3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id E4CBC180868D9 for ; Fri, 7 Aug 2020 20:53:25 +0000 (UTC) X-HE-Tag: stage77_0304c8026fc3 X-Filterd-Recvd-Size: 4120 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 20:53:25 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id di22so2167030edb.12 for ; Fri, 07 Aug 2020 13:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uDdO7KYbxhxTk2FOJVbqBVzcbLgZ7jU5XfocoxoIBgI=; b=oMkbbQecdxBGwszkCSHjbswohitljIgQwkOQWaGukPotDPUE+7V5FqR8o21TlFSPZM VZFDmTR6WqPYKfGFGayZpJHlShZEQsgXE1YKOTOlOIJLLidt928lE7XmfS66hfv25SrU xbfpNpACS7a9qXUxwR26fHO3cV40IevWLB88M2CW5+ilqTNkGaA9vLebcRDqL63ZgECr IIa/53RI/TYMdm7dJNZZzTKitXZdWmhzOOvHbv7xWK36UGYk3T/S9DC2+KF6Q3mp36eU QBN96wXQGcKI+A12i+/kNwzHqS+QWQ695pqsYp54nfgxil0ad2eeyKq6h1BkjEIVnmGU ycGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uDdO7KYbxhxTk2FOJVbqBVzcbLgZ7jU5XfocoxoIBgI=; b=EPKDYGv8+609BGw2sbewUD6dnctWutZLYjVvcHf0KqtklpVegdUWuI4bt5I/TYVREQ VWmuDTW98gu59zOuQJGp9BtT5b39e4MBrDHiD0NX5gzmgghUu3ZMhhPCshp18ujuwKXj BFtlyY6GQneF6xvErPmt1zymDFqkhZxz6sB26V7bUCz2STgjJ0GckE+hMixHbQ3lQnTU zAC1j+fp82BiEXXpqYs0/jXPKdK/wEnjojAsdWNRpY+S/NFImIctOYieRLvVvdP72Y8H MDoy/6w+IPS6/SZ+HtCMDbVoowSfneUV67J4WtAdaA42jS3ZpyZHNXTid2Y1N/BSp87/ cfvw== X-Gm-Message-State: AOAM533GOue0JiLJfk99R/s6OOKY0vlH0EnAwuk4XTt+8wEn+KH+DRpB MgEa27CGmkl0+7WWjf4eUKiLb9RRlIUfmYfn07E= X-Google-Smtp-Source: ABdhPJw2DTnQO7A+X9ua1LSB52QrGpIJx4BF1Nb+Lgekbo+gJCkfmnEsq56kQIekJo8f6pdqErfZ/G2lea1hf2CtIvQ= X-Received: by 2002:a05:6402:1d92:: with SMTP id dk18mr10324663edb.206.1596833604283; Fri, 07 Aug 2020 13:53:24 -0700 (PDT) MIME-Version: 1.0 References: <20200806231643.a2711a608dd0f18bff2caf2b@linux-foundation.org> <20200807061706.unk5_0KtC%akpm@linux-foundation.org> In-Reply-To: From: Yang Shi Date: Fri, 7 Aug 2020 13:53:07 -0700 Message-ID: Subject: Re: [patch 001/163] mm/memory.c: avoid access flag update TLB flush for retried page fault To: Linus Torvalds Cc: Andrew Morton , Catalin Marinas , Johannes Weiner , Hillf Danton , Hugh Dickins , Josef Bacik , "Kirill A . Shutemov" , Linux-MM , mm-commits@vger.kernel.org, stable , Will Deacon , Matthew Wilcox , Yu Xu , Yang Shi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E4CBC180868D9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 7, 2020 at 11:17 AM Linus Torvalds wrote: > > On Thu, Aug 6, 2020 at 11:17 PM Andrew Morton wrote: > > > > From: Yang Shi > > Subject: mm/memory.c: avoid access flag update TLB flush for retried page fault > > This is not the safe version that just avoids the extra TLB flush. > > This is - once again - the thing that skips the whole mkdirty and page > table update too. > > I'm not taking it this time _either_. I'm supposed Catalin would submit his proposal (flush local TLB for spurious TLB fault on ARM) for this specific regression per the discussion, right? And, the more general spurious TLB fault problem sounds not that urgent since it should be very rare. > > Andrew, please flush this garbage from your system. > > Linus >