From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71024C43334 for ; Mon, 11 Jul 2022 21:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9609940022; Mon, 11 Jul 2022 17:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E445C940010; Mon, 11 Jul 2022 17:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0C6B940022; Mon, 11 Jul 2022 17:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C1CAD940010 for ; Mon, 11 Jul 2022 17:32:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 52B5520DE4 for ; Mon, 11 Jul 2022 21:32:37 +0000 (UTC) X-FDA: 79676118354.14.D825F4E Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf05.hostedemail.com (Postfix) with ESMTP id E197910003D for ; Mon, 11 Jul 2022 21:32:36 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id 73so5822275pgb.10 for ; Mon, 11 Jul 2022 14:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=va04T0cvQOYNBElLFYp9BJR3rnDCvEr1oML1d9eb1fw=; b=pX4DWzI+y7DkaqwsJH9X4Gxt7XthOHohjoamLBsqDNHYY1VwS+s7g9HMySKGGyITTl JlMsG2SCXfh5rz91r5J6sFuOJokMi08HhABVEyX6vrCLZ0A6om90P7SXKDG9T9/Hlsvz PFP8c5hpDKaH/nkTZvRA5tjesjfcF9qSLvxoh30hJCZQsJz/XXjtCVqCXj2idtgUt8/5 wMzl87b95z/RPmI3oWb8OyNG1CrRZ3jXrKusbUltde2vjPp8720e2am+UFkoyYjGuVWZ erx9iVeN9GskPPaKJurkFysWl8JiNXWMTUnmTl+67P9mT1cxtPagoDTeDOGVhNM2CfMt F2mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=va04T0cvQOYNBElLFYp9BJR3rnDCvEr1oML1d9eb1fw=; b=Nrnubd2Z1UGPOqscsbNTWygmYGYBrFDwJ47KRzTsZUcBCrj1MpTv5FxFG9+YDc9wFO 2gKmGCocrtMdCYjskwirXGpxTv/y1VjXqIPBlPGVN/aHJN1VLqH/FulJ1FuHcHXQlXXl IHAQ0iTZ2gVJ1xenoHTAHWUm/Do2p/s6RA9xrLD2WijgIYozYaJjg89aKdpQSFvwW+Po +UdrWx4qPrYmbzWviII8X1YGLnexi5XhBpJIJmqEZS5pHxLakczgCKmfDSPQd888zexk 5hikt3a+o2N5qrJPrLn0nQYAEXOyj7A/Nuqxj4CcYE+H9lrSUZNyMp5wyZa1fBckVhjj U7GQ== X-Gm-Message-State: AJIora+hBNphcPOqUfGGNn9LgBKkSCkPebwyWLIaXAozIMr6V2GiSs+j grZ7kqubveC0CuXx9EwB2lwnLTRp51+ryNx6Sjk= X-Google-Smtp-Source: AGRyM1ugQ+DTC8BXKyc8bsJJ4kAM3iUMbWMR2/OgagUqXJ/fP8z3QFoHW29pGnmKjFh6HLIJWluWw3e2wQIvItq73mU= X-Received: by 2002:a63:4a5f:0:b0:415:d3a4:44d6 with SMTP id j31-20020a634a5f000000b00415d3a444d6mr12562327pgl.75.1657575155970; Mon, 11 Jul 2022 14:32:35 -0700 (PDT) MIME-Version: 1.0 References: <20220706235936.2197195-1-zokeefe@google.com> <20220706235936.2197195-12-zokeefe@google.com> In-Reply-To: <20220706235936.2197195-12-zokeefe@google.com> From: Yang Shi Date: Mon, 11 Jul 2022 14:32:23 -0700 Message-ID: Subject: Re: [mm-unstable v7 11/18] mm/madvise: add huge_memory:mm_madvise_collapse tracepoint To: "Zach O'Keefe" Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Zi Yan , Linux MM , Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657575157; a=rsa-sha256; cv=none; b=VNqRRSqzyMxeAD2ww6YfJIrHeQq0mLZCUeZqpEJrwidLvmJB+NrXusgKNX1l0dI0OuXMud 4wIJysLTVlxLrJpm+YS9xfjBm3h+TS5R//Zu8mg6VbEe/KvYYTj8bu4r+MatHskcK98Ou5 f0FwYkPUTERkNC96WlRoyAVOw+OwaqM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pX4DWzI+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657575157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=va04T0cvQOYNBElLFYp9BJR3rnDCvEr1oML1d9eb1fw=; b=Vf5FrvmyrYn74VoPPtDgNrRJqTptw1KfCT20CjZ1oE1p0+wTxU39nA60FoOhYbcFc78pvL +0mwfCmWkzNOCYGcG9n4I18vp9Mqn6M5EOvhuf28jqlWOEqyuLaYXor+Z4W3ZKfCAqU+DV UZzy8IPC1DiieuZlfpxAmOlLbeRA/Oc= X-Stat-Signature: m149zjbxsf9sgynqwnu71athje91gxk8 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pX4DWzI+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E197910003D X-Rspam-User: X-HE-Tag: 1657575156-279290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 6, 2022 at 5:06 PM Zach O'Keefe wrote: > > Add a tracepoint to expose mm, address, and enum scan_result of each > hugepage attempted to be collapsed by call to madvise(MADV_COLLAPSE). Is this necessary? Isn't mm_khugepaged_scan_pmd tracepoint good enough? It doesn't have "address", but you should be able to calculate address from it with syscall trace together. > > Signed-off-by: Zach O'Keefe > --- > include/trace/events/huge_memory.h | 22 ++++++++++++++++++++++ > mm/khugepaged.c | 2 ++ > 2 files changed, 24 insertions(+) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h > index 55392bf30a03..38d339ffdb16 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -167,5 +167,27 @@ TRACE_EVENT(mm_collapse_huge_page_swapin, > __entry->ret) > ); > > +TRACE_EVENT(mm_madvise_collapse, > + > + TP_PROTO(struct mm_struct *mm, unsigned long addr, int result), > + > + TP_ARGS(mm, addr, result), > + > + TP_STRUCT__entry(__field(struct mm_struct *, mm) > + __field(unsigned long, addr) > + __field(int, result) > + ), > + > + TP_fast_assign(__entry->mm = mm; > + __entry->addr = addr; > + __entry->result = result; > + ), > + > + TP_printk("mm=%p addr=%#lx result=%s", > + __entry->mm, > + __entry->addr, > + __print_symbolic(__entry->result, SCAN_STATUS)) > +); > + > #endif /* __HUGE_MEMORY_H */ > #include > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index e0d00180512c..0207fc0a5b2a 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2438,6 +2438,8 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > if (!mmap_locked) > *prev = NULL; /* Tell caller we dropped mmap_lock */ > > + trace_mm_madvise_collapse(mm, addr, result); > + > switch (result) { > case SCAN_SUCCEED: > case SCAN_PMD_MAPPED: > -- > 2.37.0.rc0.161.g10f37bed90-goog >