From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F6F7C678D5 for ; Tue, 7 Mar 2023 15:24:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A69D56B0074; Tue, 7 Mar 2023 10:24:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A19FE6B0075; Tue, 7 Mar 2023 10:24:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E1C16B0078; Tue, 7 Mar 2023 10:24:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7CD6E6B0074 for ; Tue, 7 Mar 2023 10:24:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 488A240DA1 for ; Tue, 7 Mar 2023 15:24:20 +0000 (UTC) X-FDA: 80542473480.07.0E21755 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6080714001D for ; Tue, 7 Mar 2023 15:24:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkuxvXKW; spf=pass (imf09.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678202658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=49sjefw2FKulo5Vz5tQGPSxZQZKzbcJ05HQTQwuGmNA=; b=8LAfKGMiYh94yT8mHbalrwYEDAwGFAlVlqmOVHtEuNcfx0w628VjT2Lhf+EM5b3cLdKoBK mWnR+6lPXJRiynnPlM+opawU6i/Eck3jCpzIX/uBVLMFPylBAOnxUrOhSye8Aivx1cfYsy R/0xfXcm6CVMDBuXD1sGUpjT57AXWik= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkuxvXKW; spf=pass (imf09.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678202658; a=rsa-sha256; cv=none; b=uPivPDKSTLs4uJOhT7pBlwZf/ot6lyMx4GvbSW+mIyKMd5cOcAZh1YFhPfGZBMvXocorba EueGvzznWRa9HghiTbUPC5KHfcduMZPZe05i2kjbarw43fxhxTN/zx3JhCT+Q/XvU751zr SrxBDt7yC9ArywJadPq1iQoXPN1gx10= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678202655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49sjefw2FKulo5Vz5tQGPSxZQZKzbcJ05HQTQwuGmNA=; b=SkuxvXKWy3LN3CE05jJSuytvFkp+rhtJgVk1DMKS8G34k/9dZaEFp2iDf8X2e6bR8xRQuz u6botFvaU+1qj8g768Qw72tJqQBI2zSCLpxCIJAm1O14f0WjksPeQyb6VEzgXfmJCd4vBi XoawFt8KUDiK/RCJcmftg14fM90U/Rw= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-9QaNndsKPiip1nnNPgBhPQ-1; Tue, 07 Mar 2023 10:24:09 -0500 X-MC-Unique: 9QaNndsKPiip1nnNPgBhPQ-1 Received: by mail-pl1-f198.google.com with SMTP id z2-20020a170903018200b0019cfc0a566eso7890109plg.15 for ; Tue, 07 Mar 2023 07:24:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678202643; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=49sjefw2FKulo5Vz5tQGPSxZQZKzbcJ05HQTQwuGmNA=; b=BgatHbcq8w3ZQQLIjW80+VJulB5Z/SSMFhw2LDl3Te6PQ3DTQoO5cxbXmkjdudKJTn bECPaZHagMedAbk0iHhRHtCmXCY/qHZNXZEx7dydrw23PSWGyevKQRDiYa1Y7TsHiioO jmdTSEl+z7qVgw+d/O+eQFXGi7sldVEd8htjTjpRtQIpT624CsvuFxUIM5G1oiuDRPqz IDs1Aef9frhUFt6OViEl3dZRODT2RsTuHICNMudPaYRY/GqLyrbQ45RozzJZWmSHDHjE qiOlx1RCcHlnxbku6stawIzc4mIcX7EzyiHEl/mgWfn1swCg5SPrS7x2sUu2h6lfLwWH Jykg== X-Gm-Message-State: AO0yUKV6rynXle/JDpu8q2x/JuUP/8G18IE560OIjmP2SlkVSBU/PVFF SGHtkNbXLtujmgaydmA3pqkbVf4hSsbyb6am/RmqAMaudhV7p3TK/YvD8PYfgrRKLI3ui1snBJy 7aLsVCHGvToF0e/6uU/Nq/vktqNE= X-Received: by 2002:a17:902:f812:b0:19a:f153:b73e with SMTP id ix18-20020a170902f81200b0019af153b73emr5668634plb.4.1678202642957; Tue, 07 Mar 2023 07:24:02 -0800 (PST) X-Google-Smtp-Source: AK7set9SWy5O05m3x1Ey9TSLMznr1jfUxFnvxAX39KEBXqqmaUx44UhyFFrhNGEtwClSqvzd8jjgUVc0X6h/fPAWheE= X-Received: by 2002:a17:902:f812:b0:19a:f153:b73e with SMTP id ix18-20020a170902f81200b0019af153b73emr5668618plb.4.1678202642668; Tue, 07 Mar 2023 07:24:02 -0800 (PST) MIME-Version: 1.0 References: <20230307143410.28031-1-hch@lst.de> In-Reply-To: <20230307143410.28031-1-hch@lst.de> From: Andreas Gruenbacher Date: Tue, 7 Mar 2023 16:23:50 +0100 Message-ID: Subject: Re: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v3 To: Christoph Hellwig Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5z16aqqpm5jdckcshc58e4mu53ycr7kk X-Rspamd-Queue-Id: 6080714001D X-HE-Tag: 1678202656-727309 X-HE-Meta: U2FsdGVkX1/3zCmu6nHTH3huhDnF6UEBLft3CTys1YuoN6IJzmniWOzuOPYAc2RqB6xw2H8gFvJqWDJUPAMu75IGlAPoJNQKxybDiepNTTaSWLz17a4ztkPWo7kcPDEMnLmVq9UNH/Gn3vTcxEJvaVkgRsUi/5NhcsuNfRLBYunuQW66+v0IAGzo7LvItQXg1jp0HUZqWjkaTA4FH0NptwAKI+qFbap8F2BnmfwrQdl7B6TuGcCBJnJYWRFShyeXzi7iyAkzcboXSjojAcPUPBTUAffOm0HzL2F54XkINyU45nPatcZXOItQVxHcHrz6XbFXJbjw7p4kQHNrenmfXt7HZ/i1z2OVRa72553kj1nZDFAkxSc6N1fXATv9Lu6WXi0KTeDzuaQxIszLaGYT8HmEvv8BpF8pAUqiNlTo3nnNAFW4Qz1i25k6MxBHYQJG8SOhrMvuSwkRW+xK0WlORyMLWVCZ/C3laBNNY7+F2RE4D7S1Gsm+JbaDB1SS+3UZcvqyXcofJId4HSJ9omfVoi7BAeu6keeeTRRdUOl53Ay5gUJAt9SxcaNIy39N51IBT3OCnh3Z35BqxafqR5Ym3v9YhaQPDVcaJakB6SwsqcpFW4IykjvhdBrQJco6BK9QzabqIAogTu6lw6LlP801wgEErus4c7jUraI0w7KduopCempP6B4uVeInu+MSqT6zoXs4ebXAPT8A+4WCmIfFcAvlDiBN2pVM4YhXH5ypYWfFhtX+uxW/UlnzQ1ZNtpita+FH+3qx8An8bwQcspHRDu56UnH2IrRagFumGut4qPVm6GjIuLuJQU37KoOAXbm3UEvdKqdlmz+amq05iquzhlBQ5zk6qsvItb7BaeW3qqa3oaucYKqbkoBL251MO057lNJK4NE88FKZLco9SmU6BL0uUOk7/3qCLz2Ye4ReWtpo1hkX3ZwQ//9KUpPuuO2O75wn8wqiGS6ctY1X4Yk fcSgyGGt BVG8mwZ19o/mN7j76FVZRU7kIITjr8mppDbSZljZUqI2O6dbvRyjZgPa3HSSyo7AOiuOR7w4QfZCinXZkKDzUpeMMAPYaOjZsjRVak+2SZNanV4UJPQFU4dbq8KJlfQRVwBmbt9obMX+ZLa4hlBwlthFZ9A21poc0wUWGERK0h1v7Ul3lxb5J9jQlyfBcgNsisGkC6TAIQ72F8n+VO/KLSpXlc8dbSoVy/6QDrFqlXOJz29xYTWHfuTf2C3qimsx4iltHOnoLNLlWG0IOBaDQvHSWt2+9kpMht/T3ZE0HJPOfJyLCcC28g50R9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 7, 2023 at 4:07=E2=80=AFPM Christoph Hellwig wrote= : > __filemap_get_folio and its wrappers can return NULL for three different > conditions, which in some cases requires the caller to reverse engineer > the decision making. This is fixed by returning an ERR_PTR instead of > NULL and thus transporting the reason for the failure. But to make > that work we first need to ensure that no xa_value special case is > returned and thus return the FGP_ENTRY flag. It turns out that flag > is barely used and can usually be deal with in a better way. Thanks for working on this cleanup; looking good at a first glance. Andreas