From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DADBC433F5 for ; Wed, 20 Oct 2021 06:38:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4C4C61038 for ; Wed, 20 Oct 2021 06:38:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4C4C61038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1714B6B0071; Wed, 20 Oct 2021 02:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1211A900002; Wed, 20 Oct 2021 02:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00FAD6B0073; Wed, 20 Oct 2021 02:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id E38886B0071 for ; Wed, 20 Oct 2021 02:38:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9741F29DFA for ; Wed, 20 Oct 2021 06:38:46 +0000 (UTC) X-FDA: 78715862652.13.0ECB4C8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 4FF376001983 for ; Wed, 20 Oct 2021 06:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634711925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PrOFEvqhNQrQ0/ExACfaN4BBMFTlowBIDO0/wNK/PGI=; b=PoMinisIlENjtV23IhOMvbpBLah8wxjwdjn5rP8xZ+wo9VG8J45LBHAk9Fs7hbc0lzpm+s PWWnH5ab608WFXYURopCjgNBetS4FDQtoAqgK15/QoQfULTkwz36mH2zM3yVOkN8oikeRW /XM9YBOWpdDfHzGoHltb2Ejwcfi1i64= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-XyKAQ2GUPcKSFoGWAdhHtA-1; Wed, 20 Oct 2021 02:38:44 -0400 X-MC-Unique: XyKAQ2GUPcKSFoGWAdhHtA-1 Received: by mail-yb1-f199.google.com with SMTP id i21-20020a253b15000000b005b9c0fbba45so29224568yba.20 for ; Tue, 19 Oct 2021 23:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PrOFEvqhNQrQ0/ExACfaN4BBMFTlowBIDO0/wNK/PGI=; b=060/3pK2fiPHAisB+4SYM4YKQRIQalj5p4iPZyog7OlvZnqLx+jnanUVc3P5zjAOmX 1SDMKO/H4rCYKOySwMUPYFRwIOXpInXt/+DNPLBoSbwrm3kirflBIWoZJJ4qjfz670P2 dsgwzMLQ3RGHix6O8I+Mf6UAHmzr0pl+loROJALhrcmYzqDCxO31DsK6NY0BUp2gwdxY enbdsbVr5aj6L9zAFn42/orpdx0K+hiAbFZafEctUwtcaZeiXDnkxEm36MCOq4I/Vrg3 cdQg/2Km4xJ58fuHWcmA0RUHRpZdd6lbP/FjZhMtqS3qLZJApTBSH6J4mp6vGUsNl43+ tYxg== X-Gm-Message-State: AOAM532Hsbu98ZNFWj6HajDJ7LjdKyVylMjYCngFYIJAeKQMij4nCljq 3GfcQukYb/YrR4Zy5QLVhMSHorbaCJMB9tml8ogJhJptiQaeZFRVmvDNurbrebxR9jVOQ/+jFe2 6XkJ0y9pn/Fwo45WWaQR22aMD5lQ= X-Received: by 2002:a25:3104:: with SMTP id x4mr40913561ybx.512.1634711923714; Tue, 19 Oct 2021 23:38:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIZmVt4b8AgEMPxIzXR7HjibNCLFoFON5qfINqUWjmWY1rYZGs5qe6fNCsg2PkDEFW2ZrVeNuo6RpgxFciEWQ= X-Received: by 2002:a25:3104:: with SMTP id x4mr40913541ybx.512.1634711923514; Tue, 19 Oct 2021 23:38:43 -0700 (PDT) MIME-Version: 1.0 References: <20211019073641.2323410-1-hch@lst.de> In-Reply-To: <20211019073641.2323410-1-hch@lst.de> From: Yi Zhang Date: Wed, 20 Oct 2021 14:38:23 +0800 Message-ID: Subject: Re: fix a pmem regression due to drain the block queue in del_gendisk To: Christoph Hellwig Cc: Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Jens Axboe , linux-block , Linux NVDIMM , linux-mm@kvack.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4FF376001983 X-Stat-Signature: 5qnqjdt3kocbtfk6ejyrax5hyn9ex6d5 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PoMinisI; spf=none (imf14.hostedemail.com: domain of yizhan@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=yizhan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1634711927-652161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Verified the issue was fixed by this patchset. https://lore.kernel.org/linux-block/CAHj4cs87BapQJcV0a=M6=dc9PrsGH6qzqJEt9fbjLK1aShnMPg@mail.gmail.com/ Tested-by: Yi Zhang On Tue, Oct 19, 2021 at 3:37 PM Christoph Hellwig wrote: > > Hi Dan, > > this series fixes my recently introduced regression in the pmem driver by > removing the usage of q_usage_count as the external pgmap refcount in the > pmem driver and then removes the now unused external refcount > infrastructure. > > Diffstat: > drivers/nvdimm/pmem.c | 33 +-------------------- > include/linux/memremap.h | 18 +---------- > mm/memremap.c | 59 +++++++------------------------------- > tools/testing/nvdimm/test/iomap.c | 43 +++++++-------------------- > 4 files changed, 29 insertions(+), 124 deletions(-) > -- Best Regards, Yi Zhang