From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EBDC2D0DB for ; Wed, 22 Jan 2020 18:24:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C72424125 for ; Wed, 22 Jan 2020 18:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="c17kuYSr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C72424125 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D2406B0006; Wed, 22 Jan 2020 13:24:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0836E6B0007; Wed, 22 Jan 2020 13:24:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F014F6B000A; Wed, 22 Jan 2020 13:24:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id D9AB96B0006 for ; Wed, 22 Jan 2020 13:24:51 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 726332464 for ; Wed, 22 Jan 2020 18:24:51 +0000 (UTC) X-FDA: 76406096382.11.cable79_476e82f57c93e X-HE-Tag: cable79_476e82f57c93e X-Filterd-Recvd-Size: 5258 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Jan 2020 18:24:50 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id o11so104845ljc.6 for ; Wed, 22 Jan 2020 10:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIMMT3lCl+eANfb55cCw3QDYBNjRwo8JhGMdDvgr7PE=; b=c17kuYSrsF8ApH4qTq2aUrhTyJuVUz8Qw7Uqon82/zhXga7zwOs4wblkpbPz0h9lVu Mk1jBZzARoiTbYMPv6eHlPBz1kmgDHakPiaAgrUnRGb1IahFhKrpr/e1yazkuLI925En FVkjGNvnMMyvMfWRS8f7fAzQi00FO8SB4wXTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIMMT3lCl+eANfb55cCw3QDYBNjRwo8JhGMdDvgr7PE=; b=O+uO5X0qHxG9MqKZPIczYIeq7MGIriIE278JswEgZ6lkjcdRzhutHQquJKCX/+4Juz 1U2yocnNkZmzKgEl/vTv1G7jLqlL8oG3g0BrcpOWUUXH+GCq2t4au7DRvhetYrOGKskC qVDgdbvRDw9n4TfmWCvnhjtAQU80FB7V4neGs4w8RwNRshFJjqf5JvC4hzuH/V1l+HG1 VyHWMsZTJRy+sh6VmNzYuV/Fh1fo4PNPt9Ed4rf4RvRRUqM1xInsfCYMbeTx124UqytE p0MUmemmcn5jPn+z6D2UGJok2rXOnxhdCxaLUeZvZILlUQfLa60FTw1lysf7OyT52eGr KHgg== X-Gm-Message-State: APjAAAWP8tq9dKHUBB5hA/JZyHUz2P9FJJiO1Wyi4xKfGJIOkd+JVQq1 a53b9khja5byu+b/Rn72ug85hKdhjrE= X-Google-Smtp-Source: APXvYqzg/dwRna+VR4fAhocQjrF9nmGnd0GrcGmUAgaIi6Nds4S65cR/r/Qg4l0VHxbzGbXa5nu3eQ== X-Received: by 2002:a2e:a168:: with SMTP id u8mr21084354ljl.5.1579717488267; Wed, 22 Jan 2020 10:24:48 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id i197sm21380597lfi.56.2020.01.22.10.24.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2020 10:24:46 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id 9so323344lfq.10 for ; Wed, 22 Jan 2020 10:24:46 -0800 (PST) X-Received: by 2002:a05:6512:78:: with SMTP id i24mr2492109lfo.10.1579717485818; Wed, 22 Jan 2020 10:24:45 -0800 (PST) MIME-Version: 1.0 References: <12a4be679e43de1eca6e5e2173163f27e2f25236.1579715466.git.christophe.leroy@c-s.fr> In-Reply-To: <12a4be679e43de1eca6e5e2173163f27e2f25236.1579715466.git.christophe.leroy@c-s.fr> From: Linus Torvalds Date: Wed, 22 Jan 2020 10:24:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/6] fs/readdir: Fix filldir() and filldir64() use of user_access_begin() To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: multipart/alternative; boundary="000000000000968f64059cbea3a6" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000968f64059cbea3a6 Content-Type: text/plain; charset="UTF-8" [ Sorry about HTML crud, on mobile right now ] On Wed, Jan 22, 2020, 09:52 Christophe Leroy wrote: > > - struct linux_dirent __user * dirent; > + struct linux_dirent __user * dirent, *dirent0; Patch looks better, but those names are horrid. Please just use "prev" for the previous dirent, and leave the current one as "dirent". I think that's going to be a lot more legible. But no numbering. Linus --000000000000968f64059cbea3a6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
[ Sorry about HTML crud, on mobile right now ]
On Wed, = Jan 22, 2020, 09:52 Christophe Leroy <christophe.leroy@c-s.fr> wrote:

-=C2=A0 =C2=A0 =C2=A0 =C2=A0struct linux_dirent __user * dirent;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0struct linux_dirent __user * dirent, *dirent0;<= /blockquote>

Patch= looks better, but those names are horrid.

Please just use "prev" for the previous dirent= , and leave the current one as "dirent".
<= br>
I think that's going to be a lot more legibl= e. But no numbering.

=C2= =A0 =C2=A0 =C2=A0 Linus
--000000000000968f64059cbea3a6--