From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED37C433DF for ; Sun, 18 Oct 2020 16:22:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED4312064C for ; Sun, 18 Oct 2020 16:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GJ68dYyJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED4312064C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FBB06B005C; Sun, 18 Oct 2020 12:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ABC46B0062; Sun, 18 Oct 2020 12:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C24D6B0068; Sun, 18 Oct 2020 12:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 2DB576B005C for ; Sun, 18 Oct 2020 12:22:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C807D3629 for ; Sun, 18 Oct 2020 16:22:33 +0000 (UTC) X-FDA: 77385564186.19.mask96_4a0688b2722f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id AC2581AD1B2 for ; Sun, 18 Oct 2020 16:22:33 +0000 (UTC) X-HE-Tag: mask96_4a0688b2722f X-Filterd-Recvd-Size: 4055 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 16:22:33 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id d24so10107555lfa.8 for ; Sun, 18 Oct 2020 09:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rtseMlU6aTGoPRcjRdJrb7Y2w8ZeQv13FZvGimK4Plw=; b=GJ68dYyJwVdPXzlKzQnUiHbwJbsVnv7nscEARPECO/9S/DexUd7Yl/A//3mjNKsLra 9lsr4xZQYxluJ/6VGeTBmZd+o6GLZ70NnYlOY2QAhpwezhiyThti4RfzaE/8JT9od3lR 3hp84ro+3+hDkx+DXLkMiCkBl9oX0QOozymV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rtseMlU6aTGoPRcjRdJrb7Y2w8ZeQv13FZvGimK4Plw=; b=IvaO7fif0lrtFE4jSjOhUKfizITdI2XAkohdmthnOS+ZwHyMuNfnN/FpmT2CXk1Cmx eapBFXdiAObAsKFITpSYSgpCxjChOO9/zCEHpNH+1k2KThGbP+KnZm4qvyR8I/VDcO7a MnCkrgNJKaqordejdo7w1tqkKq9cLg5d1/qQ9dm0yGPeXO7waizaA6jRxiDp656RBQk8 bCSRGxDJFUnT99dBXXwH0meLoTUsV0y5M7jX5zO160j8+nHrVqNAVk9D0Jjp9MuDVg1n hf5pfQ2WVuTITCBcZEPXnZI7CgUdhWZU/jIy0B503k81oNqUIqoJpNyg8hpv49ZIcZgi 0IgQ== X-Gm-Message-State: AOAM530FE6SSYyeRRcy3isu7aQW9fE1obsCbJniO2741z5u0MUC6bOoF DJrc8/r8WLDZ2DqbJwR6YT423DjXbG2KlQ== X-Google-Smtp-Source: ABdhPJyL4hbQmjzV/UsuDt6IPd7cm6yuPg8BbIATbFQy2aowP2YcKZ8utYXMyGrGHyYtWnIgRqpXEw== X-Received: by 2002:ac2:5a0f:: with SMTP id q15mr4087860lfn.213.1603038151250; Sun, 18 Oct 2020 09:22:31 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id a201sm2817824lfd.213.2020.10.18.09.22.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2020 09:22:30 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id x16so8509740ljh.2 for ; Sun, 18 Oct 2020 09:22:29 -0700 (PDT) X-Received: by 2002:a2e:898c:: with SMTP id c12mr5480913lji.285.1603038149531; Sun, 18 Oct 2020 09:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Sun, 18 Oct 2020 09:22:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h To: Andrew Morton Cc: Jonathan Corbet , Jerome Glisse , John Hubbard , Linux-MM , mm-commits@vger.kernel.org, Ralph Campbell , Shuah Khan Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 18, 2020 at 9:18 AM Linus Torvalds wrote: > > On Sat, Oct 17, 2020 at 4:14 PM Andrew Morton wrote: > > > > --- a/mm/gup_test.c~selftests-vm-use-a-common-gup_testh > > +++ a/mm/gup_test.c > > @@ -4,22 +4,7 @@ > > +#include "../../../../mm/gup_test.h" > > +++ a/mm/gup_test.h > > There is no way I'm applying a crazy patch like this. > > That can't be right. > > And even if it works, it *still* isn't right. .. and it looks like I'll have to drop all the other gup-test patches too because this one is broken. Linus