From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D66C433DF for ; Mon, 8 Jun 2020 17:55:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFCFF20760 for ; Mon, 8 Jun 2020 17:55:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="DKYgCBD0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFCFF20760 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 578446B0003; Mon, 8 Jun 2020 13:55:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52A676B0005; Mon, 8 Jun 2020 13:55:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 416916B0006; Mon, 8 Jun 2020 13:55:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 28D766B0003 for ; Mon, 8 Jun 2020 13:55:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D4F1718019559 for ; Mon, 8 Jun 2020 17:55:52 +0000 (UTC) X-FDA: 76906797744.03.shoes72_4b07ee826dbb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id A108716985 for ; Mon, 8 Jun 2020 17:55:52 +0000 (UTC) X-HE-Tag: shoes72_4b07ee826dbb X-Filterd-Recvd-Size: 3725 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Jun 2020 17:55:52 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id j12so10783944lfh.0 for ; Mon, 08 Jun 2020 10:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Be2F/p554tZmCPWJOpnLNyvF18eqlNdstTdLiEpYOog=; b=DKYgCBD0wBkeJ4fStXzvqb/vE9vQhmByDtYBEA77W0HHvr2SeuJSfIoEqL/rN/gsTp 5AZGcEGlX67/EvKnq91OOuimTw53a1yyXLZFCVTHrGeqhFO+WANfOrn2vFNbGdRerMOj 4S6eIulyJwqqbZIj+f54OTGr898gullqBjDoQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Be2F/p554tZmCPWJOpnLNyvF18eqlNdstTdLiEpYOog=; b=KJL3D3HNWZ+9UhN3ujsO4UjSAlZ85frnaG6D8vYdviiL6mHUB1A4a6XKAxAJhX6B92 g2m7vwIOebp++1rgpHZt14UYo6IQTE8JmumsvnCSOi6KaiAPHeDG+FAT1fAd4EuI0zNz x932ed2U1KPd3YCxOGC13oNe8jAXsyFkVagGzMLO3I5o5LEam/65R+mus090GXg/z0hS HLw3fnEApTJHdMdFeo3huVZzmtmym3nhgY59clh0FtVVZW2dVcqzBKvqwnxY6N+TZdKN aKbMNdhJlYLoyi4A8rfDi62rNcVsi/miogge7q+5BA3rPzH0e9CqXINOfvIqJm3opgjg JF5Q== X-Gm-Message-State: AOAM532VGVjQvTPGd+0jlWen1CQ/Z90M5UUxVgEV828F+sfynJfloPTO v6jpUsnR5NsAu6HNutMnoJkojSiNsiU= X-Google-Smtp-Source: ABdhPJzT1E2xybJcqfe2w4k6tEUmRx4WrQWmfHLfmFlbK852DTsCLtdzojn3NXFGKhqds7m9WmcbxQ== X-Received: by 2002:ac2:5466:: with SMTP id e6mr13183206lfn.175.1591638950539; Mon, 08 Jun 2020 10:55:50 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id p2sm2051486ljg.95.2020.06.08.10.55.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 10:55:49 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id d7so10777291lfi.12 for ; Mon, 08 Jun 2020 10:55:49 -0700 (PDT) X-Received: by 2002:a19:ae0f:: with SMTP id f15mr13491554lfc.142.1591638949436; Mon, 08 Jun 2020 10:55:49 -0700 (PDT) MIME-Version: 1.0 References: <20200607212615.b050e41fac139a1e16fe00bd@linux-foundation.org> <20200608044121.stuEeVRhM%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Mon, 8 Jun 2020 10:55:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 24/54] mm/mmap.c: do not allow mappings outside of allowed limits To: Andrew Morton Cc: agordeev@linux.ibm.com, Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A108716985 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000159, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 10:50 AM Linus Torvalds wrote: > > So I'm dropping this patch, because it is not clear that this was > fully thought through. Side note: I'm also dropping 23/54, just because they go together, and because of how mmap_min_addr really isn't a hard limit (as things stand today). The logic in 23/54 fundamentally has that "it's a hard limit" issue. Linus