From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4252FC433E0 for ; Thu, 11 Jun 2020 02:09:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF1E7206A4 for ; Thu, 11 Jun 2020 02:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="hTVhIKMF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF1E7206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 73AD38D0071; Wed, 10 Jun 2020 22:09:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ED088D004C; Wed, 10 Jun 2020 22:09:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 602378D0071; Wed, 10 Jun 2020 22:09:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 491268D004C for ; Wed, 10 Jun 2020 22:09:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 817C03571 for ; Thu, 11 Jun 2020 02:09:38 +0000 (UTC) X-FDA: 76915299636.18.meat90_061364d26dd0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 5943A100ED3A9 for ; Thu, 11 Jun 2020 02:09:38 +0000 (UTC) X-HE-Tag: meat90_061364d26dd0 X-Filterd-Recvd-Size: 5330 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 11 Jun 2020 02:09:37 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id 82so2630550lfh.2 for ; Wed, 10 Jun 2020 19:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HqAaNK+tkReTjG9nwyeNUrJ33d6ZGcqEHVyrFyV/fY0=; b=hTVhIKMFQgBt5iKMaxnoxfYcTXGsL+UK2ZtZL/Mu/q149y09TLIaQ9vDiH83VlcSH2 Vyd9MQilRhz7cVSjTHe9QZNvE19iHzLqpaGIn/5AE6WINqPkQqGG1aU5n6WlVykhmeIL TGSfqv4I5LOj/ryBRQp/uZr1xAyeYJ1uN94KI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HqAaNK+tkReTjG9nwyeNUrJ33d6ZGcqEHVyrFyV/fY0=; b=F/t2nNmXW5OmGQ9AB5oBNA23rRwmY57MXspwUPsdd+yiPMsP+Id/VXdN8d8nCFMg2Z vSG/e8zUEMmF+Dvbb29J/A6h33B6GDARuLoizZXj8qKKWow9b5vrESzVdTTxjBqaH3hn vK6/IR2WXavuLU0nAiUpQwzcZErYa+Yxx5OJ2bCVuwrZPRK7CjKXCxxLQXoJE8pVhP/O aPLL0m+E6jr2Fg1jL8LyaWe9xS6V+PydBYWDQpsdIyPqCYv45aJkgnKQVHXNkIn34Enh eFlYnMjXGbRsjySvg+eI8x60g8nhRR+Yv1Jd/+CICaSNweJdiOtIpnBkADivWjbwbU6J atQg== X-Gm-Message-State: AOAM533T9oB1W11bmuyo6lqCPERjFgYVl8XJPOfdFC8W2KcOLVy8TzF1 43XFRmDYuZvfvkTkyFYgNoTjTAni4yg= X-Google-Smtp-Source: ABdhPJwEZ0G+tzt/pmT/ZRQQKsi7gls5rgG1q/Cfo2WxUIsA1HAt4eZZtnf2A7h0a4gqMjvFluPOCA== X-Received: by 2002:a19:4048:: with SMTP id n69mr3078520lfa.31.1591841374613; Wed, 10 Jun 2020 19:09:34 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id t15sm351491lji.49.2020.06.10.19.09.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2020 19:09:33 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id 202so2617236lfe.5 for ; Wed, 10 Jun 2020 19:09:32 -0700 (PDT) X-Received: by 2002:a19:4048:: with SMTP id n69mr3078478lfa.31.1591841372581; Wed, 10 Jun 2020 19:09:32 -0700 (PDT) MIME-Version: 1.0 References: <20200610184053.3fa7368ab80e23bfd44de71f@linux-foundation.org> <20200611014241.11iF_RJqJ%akpm@linux-foundation.org> In-Reply-To: <20200611014241.11iF_RJqJ%akpm@linux-foundation.org> From: Linus Torvalds Date: Wed, 10 Jun 2020 19:09:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 24/25] mm: use only pidfd for process_madvise syscall To: Andrew Morton Cc: arjunroy@google.com, Brian Geffon , Christian Brauner , Daniel Colascione , Johannes Weiner , joaodias@google.com, Joel Fernandes , Linux-MM , Michal Hocko , Minchan Kim , mm-commits@vger.kernel.org, Oleksandr Natalenko , David Rientjes , Shakeel Butt , sj38.park@gmail.com, Sonny Rao , sspatil@google.com, Suren Baghdasaryan , Tim Murray , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5943A100ED3A9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 10, 2020 at 6:42 PM Andrew Morton wrote: > > From: Minchan Kim > Subject: mm: use only pidfd for process_madvise syscall No. I'm not taking this crazy series. First we have patch 18/25, which introduces process_madvise() that takes a pidfd. Then we have patch 21/25, which says "There is a demand[1] to support pid as well pidfd for process_madvise.." and points to https://lore.kernel.org/linux-mm/9d849087-3359-c4ab-fbec-859e8186c509@virtuozzo.com/ And then finally we have patch 24/25, which says "Based on discussion[1], people didn't feel we need to support both pid and pidfd for every new coming API[2] so this patch keeps only pidfd" and points to https://lore.kernel.org/linux-mm/20200509124817.xmrvsrq3mla6b76k@wittgenstein/ Fine. Discussion is good. But this patch-series is crazy, and I refuse to take this kind of schizophrenic patches that can't make up their mind. Make up your mind, dammit! Don't send me patches that vacillate between two standpoints and make the history and the eventual final end result really hard to tell. What will it be tomorrow? Another two patches that decide to go the other way and then back? I'm going to flush this whole madvise patch-set down the toilet, because after having this kind of whip-lash looking through it, I can't take it any more. So all of 17-25 are just going in the garbage until people can make up their minds. Linus