From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE67C433E0 for ; Thu, 14 Jan 2021 18:17:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC5DA23B55 for ; Thu, 14 Jan 2021 18:17:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC5DA23B55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 62A9E8D0104; Thu, 14 Jan 2021 13:17:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DB6D8D0102; Thu, 14 Jan 2021 13:17:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1908D0104; Thu, 14 Jan 2021 13:17:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 391528D0102 for ; Thu, 14 Jan 2021 13:17:43 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 00F01181AF5C1 for ; Thu, 14 Jan 2021 18:17:43 +0000 (UTC) X-FDA: 77705188806.28.army06_5a0387627528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id C26416D75 for ; Thu, 14 Jan 2021 18:17:42 +0000 (UTC) X-HE-Tag: army06_5a0387627528 X-Filterd-Recvd-Size: 4194 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 18:17:42 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id o17so9388302lfg.4 for ; Thu, 14 Jan 2021 10:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=AoB8ftutsiFSPCw0cLKCQs0z3iibi8buOE+leA0p6M8n8cLzFROGUPZBIn7ctD38k3 P8PjCxgmmEPwmAxrvDK/44szweqhYTqRRhQ7ABljYS6nvUa+dFzpzyrpyeJb+Zevv9Ut Kqv0YJ+aqmNv1B67+g6LHOBYTHPMx/XbaQCkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIhd1uC2z/B49SFr+5F6fuw8ur1PxMBEOpX9JeU0Qpc=; b=WFZN3vpLYfZm/iHC28V9KJDEpimPHFk+WOCQhOauTiJNFMw/niJFRGltHZ0NN7ERv+ NOwyTxgtr9W0o/pYJdTz3qcrmT3EfU4ZEyktySICyMukSCVFmdZMK+hTvTthAgPAQUxo g0D6YtRvAtVee9Z+tmbPQHlgWtRCabbUxxib24gMi/EgEDYmj2jg+EmFpSAVRYW4RTI3 mtvzwS6YGxHXDjTYF8mqPHkCCkACNWGHqXaFjpqZdH8YhPpRIMDeiK/SfNp3hW6PJj7m hGaNPljFS0x+gLeWQyryF9jtBjeVv961cu0Xs6RfT2Fi6FVgvJdarSq/RWRkMKxk/3/2 bvDg== X-Gm-Message-State: AOAM531hZfMpLrpDJtJSY0AlzLfKXwSygGn+JaoV7/uZhWJGt1zXfYkf zzsGlSqfLFS/DkYgwBNb1LQGGySk2w5A8Q== X-Google-Smtp-Source: ABdhPJy3v7Huei2oyfCh+GZp5Sy2+NCr6VdchDbcOAVxZ+QKThm9GXcKeS8CW3uLBf1WcPwEnx1g6g== X-Received: by 2002:a19:4f57:: with SMTP id a23mr3766200lfk.495.1610648259876; Thu, 14 Jan 2021 10:17:39 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id i10sm617241lfd.202.2021.01.14.10.17.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:17:38 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id 23so9331010lfg.10 for ; Thu, 14 Jan 2021 10:17:38 -0800 (PST) X-Received: by 2002:ac2:4987:: with SMTP id f7mr3584520lfl.41.1610648258222; Thu, 14 Jan 2021 10:17:38 -0800 (PST) MIME-Version: 1.0 References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-6-will@kernel.org> In-Reply-To: <20210114175934.13070-6-will@kernel.org> From: Linus Torvalds Date: Thu, 14 Jan 2021 10:17:22 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 5/8] mm: Pass 'address' to map to do_set_pte() and drop FAULT_FLAG_PREFAULT To: Will Deacon Cc: Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Hugh Dickins , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > Rather than modifying the 'address' field of the 'struct vm_fault_info' > passed to do_set_pte(), leave that to identify the real faulting address > and pass in the virtual address to be mapped by the new pte as a > separate argument. Ack. In fact - apart from the question I had about the 'info' sub-structure - ack on the whole series. But this one struck me particularly as "that's simpler and clearer" even if that finish_fault() case is now not as pretty (but with an unnamed structure it would be slightly simpler, at least). Linus