From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BF8C4363A for ; Fri, 23 Oct 2020 15:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DAAC821D47 for ; Fri, 23 Oct 2020 15:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GD436E2U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAAC821D47 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1CF4C6B0068; Fri, 23 Oct 2020 11:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B0396B006C; Fri, 23 Oct 2020 11:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BD236B006E; Fri, 23 Oct 2020 11:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id D57286B0068 for ; Fri, 23 Oct 2020 11:55:04 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7D8401EE6 for ; Fri, 23 Oct 2020 15:55:04 +0000 (UTC) X-FDA: 77403638928.23.pump86_4c0d91f2725a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 5169437604 for ; Fri, 23 Oct 2020 15:55:04 +0000 (UTC) X-HE-Tag: pump86_4c0d91f2725a X-Filterd-Recvd-Size: 5298 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 15:55:03 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id i2so2086669ljg.4 for ; Fri, 23 Oct 2020 08:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CVCIDlW+4rSCxQwC/0UuCHmyl6vLpGQY3YbrIv0lS7k=; b=GD436E2U3ELljPkL4nM1PYvlFMy+YQnW7aen5YTspfRl7ksFgb2HDAmkn6V4t+JDaG dMMQj13VpeQs7o/RmxbX2tP6MlGCxWLIBdmEqKZM5NLiH7YFdLHZUROFosyHo2YrU1Oc /mkd7zfPG7SEUfxCAGBxjhO9Vpkj4+BC/pLM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CVCIDlW+4rSCxQwC/0UuCHmyl6vLpGQY3YbrIv0lS7k=; b=LkR9A1K6fJmdWh2Au05okid8QTXy3vOP+vANpRTBSjHBsKPkFRdhsU/mWa7IuX2xkW /nOT0PFBphRVY84wL58TOQKN58MrNUm5F6GpKEL4bgdqgQHO2WO44hCdNx7VItbPQCqj 3PnJl331PQjXM+i6A1LkI+6ypJ3+7InzyZQ+DBwg2mYm9sPQmEb7yRyTiwrVNf6r8tOL 1ICL6hhPsnH6DzCyUvjH8PuJhcjnTInjjOhXbVD/yB/cXI80vyrEgr0ClUP6YRTf1nGa jLuuXhVbaWJPH80LCjIhhsxKVYCa7HB3IQU6qrWGgV+ucwVh6liefaSYNqBR7rVOZbHl L9tw== X-Gm-Message-State: AOAM531gvFwetsdV9gvkkvPwCh+2JtLcy5Ox5rx1ZNSO+Jtmw2kkTT70 owOiHYTLJbFNPrAfFIDmMlVpwkbFQbk2Tg== X-Google-Smtp-Source: ABdhPJz83s+eUa6iB9vbz8yH7lZZgZOm2l2RUSZrWghyz3d00tck9+Kn2ZnYM3J9oOAI64tqWGZlvA== X-Received: by 2002:a05:651c:1119:: with SMTP id d25mr1193039ljo.357.1603468502268; Fri, 23 Oct 2020 08:55:02 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id n2sm174112lfa.24.2020.10.23.08.55.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 08:55:02 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id h20so2083065lji.9 for ; Fri, 23 Oct 2020 08:55:01 -0700 (PDT) X-Received: by 2002:a2e:8815:: with SMTP id x21mr1227378ljh.312.1603468500894; Fri, 23 Oct 2020 08:55:00 -0700 (PDT) MIME-Version: 1.0 References: <20201023050214.GG23681@linux.intel.com> <356811ab-cb08-7685-ca01-fe58b5654953@rasmusvillemoes.dk> In-Reply-To: <356811ab-cb08-7685-ca01-fe58b5654953@rasmusvillemoes.dk> From: Linus Torvalds Date: Fri, 23 Oct 2020 08:54:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000] To: Rasmus Villemoes Cc: Sean Christopherson , =?UTF-8?B?RGFuaWVsIETDrWF6?= , Naresh Kamboju , Stephen Rothwell , "Matthew Wilcox (Oracle)" , zenglg.jy@cn.fujitsu.com, "Peter Zijlstra (Intel)" , Viresh Kumar , X86 ML , open list , lkft-triage@lists.linaro.org, "Eric W. Biederman" , linux-mm , linux-m68k , Linux-Next Mailing List , Thomas Gleixner , kasan-dev , Dmitry Vyukov , Geert Uytterhoeven , Christian Brauner , Ingo Molnar , LTP List , Al Viro Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 23, 2020 at 12:14 AM Rasmus Villemoes wrote: > > That's certainly garbage. Now, I don't know if it's a sufficient fix (or > could break something else), but the obvious first step of rearranging > so that the ptr argument is evaluated before the assignment to __val_pu Ack. We could do that. I'm more inclined to just bite the bullet and go back to the ugly conditional on the size that I had hoped to avoid, but if that turns out too ugly, mind signing off on your patch and I'll have that as a fallback? Linus