From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB4AC33CA9 for ; Tue, 14 Jan 2020 02:17:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95B3A2084D for ; Tue, 14 Jan 2020 02:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="beDl3qmn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95B3A2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2EC0F8E0007; Mon, 13 Jan 2020 21:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29C4F8E0003; Mon, 13 Jan 2020 21:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B26E8E0007; Mon, 13 Jan 2020 21:17:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 07D988E0003 for ; Mon, 13 Jan 2020 21:17:14 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id A95138248047 for ; Tue, 14 Jan 2020 02:17:13 +0000 (UTC) X-FDA: 76374627546.23.goose63_21eb6c6b18148 X-HE-Tag: goose63_21eb6c6b18148 X-Filterd-Recvd-Size: 4539 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 02:17:12 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id w1so12474649ljh.5 for ; Mon, 13 Jan 2020 18:17:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tXrdTNgNvk4xbfBBGRrbg6Mp0kjMafKo4y5HdsO2HB0=; b=beDl3qmnpNV5zrogodwZLNyNIgE9gBEpwXjcxUm2I1+53SLEB7CaLkwn0LEQDcOwvr BK9RU06+BIA5gqtGF6RoNsjS0ombyE6PUbnHkBzTgGmlsvQSvyK1i4fIiH2+qOvI3jyf EKyTpMUZ4lg5euBxMO/2VCyHZvzKEuF7GgfGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tXrdTNgNvk4xbfBBGRrbg6Mp0kjMafKo4y5HdsO2HB0=; b=QbAgQBw1QEaKJM+9x12AVCmP0GwylladmNte0aKUOf9tlbkEOtLSeiCi5Fvzu3I91R RmKVahse8jn4L/YE1yLpVUvqDMpiLvcfmXHfIEGkkH3iBKMR+vXBPvFoZqwQDdm/2Arw +XHcSBRfRR+0GpowImEwQ3Cqopen/OGgm4yYFEjfOYpfWFkAsWYIR63xRPqFyrAN+PRU zhdfr9kPNQVnMkovusOUUZswmVgiPU4VKcVDx93jRVjezYzT1yeYejzLG5+/wuoZqI0m 6oOyNonMeG5x4s8F2aUWtOY59t2QXOsXRRm8DfnIQE9YVWXQ3Hgx1VHCiCQUkaekm9R5 BQ5Q== X-Gm-Message-State: APjAAAUOK3dWBD0OrzQn4pi2n3xTjh22Sygrrwqf+ZQ8ol9FOL/x8rt2 LdUamvSsQw3yf973ahlWM9H9MCOOLwM= X-Google-Smtp-Source: APXvYqxfeqX37QstoV9YesMFRKipQTgWiDvFk36udqr4UXTor6tt17RytsD05YmGP8OL2wZTnyqOCQ== X-Received: by 2002:a2e:94c8:: with SMTP id r8mr12881041ljh.28.1578968230744; Mon, 13 Jan 2020 18:17:10 -0800 (PST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id r12sm6636601ljh.105.2020.01.13.18.17.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 18:17:10 -0800 (PST) Received: by mail-lj1-f170.google.com with SMTP id r19so12479575ljg.3 for ; Mon, 13 Jan 2020 18:17:09 -0800 (PST) X-Received: by 2002:a05:651c:204f:: with SMTP id t15mr13293387ljo.240.1578968229371; Mon, 13 Jan 2020 18:17:09 -0800 (PST) MIME-Version: 1.0 References: <20200113162831.f7d69e11e9e673c40005c9b0@linux-foundation.org> <20200114002904.h9bSo%akpm@linux-foundation.org> In-Reply-To: <20200114002904.h9bSo%akpm@linux-foundation.org> From: Linus Torvalds Date: Mon, 13 Jan 2020 18:16:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 01/11] mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations To: Andrew Morton Cc: David Rientjes , Michal Hocko , Mel Gorman , "Kirill A . Shutemov" , Andrea Arcangeli , Vlastimil Babka , Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 13, 2020 at 4:29 PM Andrew Morton wrote: > > From: Vlastimil Babka > Subject: mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations I absolutely _detest_ how we've had this pattern of trying to change the THP logic in a late -rc game. Considering how unsuccessful some of the earlier attempts have been, late -rc kernels really are *not* the time to make changes like this. I'm going to take it this time, but (a) I'm going to revert *immediately* if anybody even peeps about the new behavior (b) I want this to stop. Andrew - send THP "tweaks" during the merge window, and not like some late-rc "fixes", when there are absolutely _zero_ performance numbers or anything else critical associated with the patch. IOW, there is a decided lack of "bugfix" here. And if there actually _were_ performance numbers, they should have been in the explanation. So stop randomly messing with the THP allocation code, since it's _known_ to be fragile with subtle side effects. Linus