From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24FDC433E0 for ; Tue, 9 Feb 2021 22:03:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6279F64EB6 for ; Tue, 9 Feb 2021 22:03:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6279F64EB6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6D936B006C; Tue, 9 Feb 2021 17:03:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1EBE6B006E; Tue, 9 Feb 2021 17:03:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35356B0070; Tue, 9 Feb 2021 17:03:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id BD0A16B006C for ; Tue, 9 Feb 2021 17:03:42 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 87DB5F001 for ; Tue, 9 Feb 2021 22:03:42 +0000 (UTC) X-FDA: 77800107084.20.horn53_26076312760a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 51DAA1824DC21 for ; Tue, 9 Feb 2021 22:03:42 +0000 (UTC) X-HE-Tag: horn53_26076312760a X-Filterd-Recvd-Size: 4763 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 22:03:41 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id p21so30709987lfu.11 for ; Tue, 09 Feb 2021 14:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tx92KR5yoK7Kj/E1nLE3ghpQl5QQOqByWmJjzpCqtGY=; b=V9UwqGgzVSybr9MIk7X99nXuilfse+Mk3lydDn9RKCzCDYoRB0jaRN+0j9MgwzacFu gRu43Pm1ruDkaldhqSI5PoDCwr8oM5gMRZ1n8jG6KKWHOx0mKaox9/lF3u76ljge1VQS yj32Jj3AKfWfodOLM8Zk0KFcJSORZEpSei+Io= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tx92KR5yoK7Kj/E1nLE3ghpQl5QQOqByWmJjzpCqtGY=; b=DtgHVV/GsPDbLXIvQNvT+M27W78iUS/wR9WhnfaTiHtQAnyFzsA+9qGY7iGeHzT7uv LDHU17ddKS+K6DsFQMwJWtOoSYjj94MRQDdf8Oz+D2i1I/T0bbBfPmJXE2cgNEpZ8e9t GTII/JESdRuw/aIFnn/Q2tmBd2hNyK+b8JEuyguh2/OfcE0ma/gOsiELXaBPO6XQIkG2 3Z2YFnKRwJa1r3bRgGB0n17ww227UUhFdyLQIAykAwez48nXVnUTd/5/ECynRoE+zHCA rYBO2wVrWZ7aGQcp8HgLRwfEmOnVESMq/D6i18GzTSHFJGqE/dskyVSeEcyuL2cF0h0u pqdg== X-Gm-Message-State: AOAM530abszu/QlSLRFRE19IfPYEIrDOkWjwD4e3bsR81Ye/8z+L/CGZ vymQKr2RzIftgdzGOA86GnfuMcArKA+Aiw== X-Google-Smtp-Source: ABdhPJz5oLYsjyxiPZFbbLjWtdZ6Axr6zM/WiC5erZmEIxOsPBygU19iq713H9zEgy9LxFhlnqgMuQ== X-Received: by 2002:a19:c7cf:: with SMTP id x198mr142733lff.289.1612908219797; Tue, 09 Feb 2021 14:03:39 -0800 (PST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id x3sm2796397ljj.120.2021.02.09.14.03.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 14:03:39 -0800 (PST) Received: by mail-lj1-f174.google.com with SMTP id b16so141314lji.13 for ; Tue, 09 Feb 2021 14:03:39 -0800 (PST) X-Received: by 2002:a2e:8116:: with SMTP id d22mr15212997ljg.48.1612908215823; Tue, 09 Feb 2021 14:03:35 -0800 (PST) MIME-Version: 1.0 References: <20210209134115.4d933d446165cd0ed8977b03@linux-foundation.org> <20210209214217.gRa4Jmu1g%akpm@linux-foundation.org> In-Reply-To: <20210209214217.gRa4Jmu1g%akpm@linux-foundation.org> From: Linus Torvalds Date: Tue, 9 Feb 2021 14:03:19 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha To: Andrew Morton , Christian Borntraeger , Heiko Carstens , Vasily Gorbik Cc: Amir Goldstein , Chris Down , Hugh Dickins , Ivan Kokshaysky , Linux-MM , Matt Turner , mm-commits@vger.kernel.org, Richard Henderson , Seth Forshee , stable Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 1:42 PM Andrew Morton wrote: > > As with s390, alpha is a 64-bit architecture with a 32-bit ino_t. With > CONFIG_TMPFS_INODE64=y tmpfs mounts will get 64-bit inode numbers and > display "inode64" in the mount options, whereas passing "inode64" in the > mount options will fail. Ugh. The two patches for s390 and alpha are obviously the right thing to do, but I do wonder if we could strive to make __kernel_ino_t go away entirely. It's actually not used very much, because it's such a nasty type, and s390 and alpha are the only ones that override it from the default "word length" version (and honestly, even that default is not a great type). The main use of it is for "ino_t" and for "struct ustat". And yes, "ino_t" is widely used, but I think pretty much all uses of it are entirely internal to the kernel, and we could just make it be "unsigned long". Does anybody see any actual user interfaces that depend on "__kernel_ino_t", aka "ino_t" (apart from that "struct ustat")? I guess this is mostly a question for s390, which is actively maintained? Linus