From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458BFC433EF for ; Fri, 25 Mar 2022 02:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2EA16B0071; Thu, 24 Mar 2022 22:03:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7146B0073; Thu, 24 Mar 2022 22:03:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A4D6B0074; Thu, 24 Mar 2022 22:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 6BEF06B0071 for ; Thu, 24 Mar 2022 22:03:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1FF2DA5A80 for ; Fri, 25 Mar 2022 02:03:04 +0000 (UTC) X-FDA: 79281260688.25.B1C94FD Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 808E140012 for ; Fri, 25 Mar 2022 02:03:03 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id d5so11070159lfj.9 for ; Thu, 24 Mar 2022 19:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ngtVr9tesRrH3h9QuJdwsRWwUqV+lCc3sEv7bM/pFPs=; b=S6nDFjuC5irly55Lifc9R62XBYSxZJDRmTi0DdDbogM1HSiCQm+1qbdjfGbyF021eP fEF2cncLSM88eWWsLKedyC+Z2HLojh7NeGRv6ZfKizTnEqphPmPBkhbk1gP4Cqld8agq j+FqOohMFDtUCRF5jWZ2XNLWo6mMTAQVnDgWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ngtVr9tesRrH3h9QuJdwsRWwUqV+lCc3sEv7bM/pFPs=; b=nnX8YHcPAOjOPzuunwRl64YqZkajOADHJrdc+ioi9CrA5dzIwWiBJkacgcshLH5CCk P+dlWVv1IQKawosIY3KX+RnAPE0I767WjuhGhrs/ICfA8hi+DG1jqHopHzKWnUUjuCeW So6K4gYKxWnnqPcywmJ1gdFqcFiihrBaPLNAoZMmT7KmkjeOTUHG4JdAjGeZGpmQZWu1 qo4udTZ5UhacBDadrZQOW7X93szMb1or2o92TqXwfDUyiNrDZ1InjRr3GRonAIWgIUXK fFwJt+/kra1SXI7+cFrU4WbgGG2n6NBkILz8W1hAvAReXaiWZ08TVz3aU7s/IK4q/EuR i8Ng== X-Gm-Message-State: AOAM531NxJyR85ScIaBlj+MyyjdYtT/sJ8HqCjUkWghY86L0U/F0rjak fiYXMnCkiTNR9874Wi9qPuCiKGVadjYj/Aho81c= X-Google-Smtp-Source: ABdhPJxIlSSQA7CDNo6d11n8+lyvgFavZ1GbzpY5lWmlJM38gcHZgKv+Yo+wqBz8oXO09T5sdz1mTw== X-Received: by 2002:a05:6512:3cc:b0:444:23b0:f34b with SMTP id w12-20020a05651203cc00b0044423b0f34bmr5793847lfp.624.1648173781389; Thu, 24 Mar 2022 19:03:01 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id p15-20020a19f10f000000b0044a36e3cc33sm525350lfh.298.2022.03.24.19.03.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 19:03:01 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id 5so11089679lfp.1 for ; Thu, 24 Mar 2022 19:03:00 -0700 (PDT) X-Received: by 2002:a2e:a5c4:0:b0:249:9ec3:f2b with SMTP id n4-20020a2ea5c4000000b002499ec30f2bmr6190271ljp.358.1648173425818; Thu, 24 Mar 2022 18:57:05 -0700 (PDT) MIME-Version: 1.0 References: <20220324180758.96b1ac7e17675d6bc474485e@linux-foundation.org> <20220325011415.C645DC340EC@smtp.kernel.org> In-Reply-To: <20220325011415.C645DC340EC@smtp.kernel.org> From: Linus Torvalds Date: Thu, 24 Mar 2022 18:56:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 113/114] selftests: vm: remove dependecy from internal kernel macros To: Andrew Morton Cc: Thomas Gleixner , Shuah Khan , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Matthieu Baerts , mathew.j.martineau@linux.intel.com, Jakub Kicinski , Darren Hart , Davidlohr Bueso , David Miller , chi.minghao@zte.com.cn, Alistair Popple , andrealmeid@collabora.com, usama.anjum@collabora.com, patches@lists.linux.dev, Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 8rwzw39gcsmqbprkrz3ua3f5hojz1jo6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 808E140012 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=S6nDFjuC; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-HE-Tag: 1648173783-913580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 24, 2022 at 6:14 PM Andrew Morton wrote: > > From: Muhammad Usama Anjum > Subject: selftests: vm: remove dependecy from internal kernel macros What what what? > --- a/tools/testing/selftests/vm/userfaultfd.c~selftests-vm-remove-dependecy-from-internal-kernel-macros > +++ a/tools/testing/selftests/vm/userfaultfd.c > @@ -122,6 +122,9 @@ struct uffd_stats { > #define swap(a, b) \ > do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0) > > +#define swap(a, b) \ > + do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0) > + > const char *examples = > "# Run anonymous memory test on 100MiB region with 99999 bounces:\n" > "./userfaultfd anon 100 99999\n\n" Read that patch one more time. This was already merged in commit 681696862bc1 ("selftests: vm: remove dependecy from internal kernel macros"), just how many of those 'swap()' macros do you think we need? Your patch managment logic seems to have failed the "was this already applied" thing. This smells like another "it applied with some context noise that I just ignored" thing. Please please PLEASE use "-F0" to apply patches, and if you have context that causes it to not apply cleanly, double-check what is up. (And if you are not git tool based, the *default* for git is to not ignore context. But if you have scripts that do "-C1" or something to ignore context lines, please make them warn very very loudly) Linus