From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A65C33CAC for ; Tue, 4 Feb 2020 03:05:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1BF220CC7 for ; Tue, 4 Feb 2020 03:04:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="XGNBBxXZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1BF220CC7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 854BE6B026B; Mon, 3 Feb 2020 22:04:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 806116B026F; Mon, 3 Feb 2020 22:04:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F3E36B0270; Mon, 3 Feb 2020 22:04:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 54C016B026B for ; Mon, 3 Feb 2020 22:04:59 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 124682DFA for ; Tue, 4 Feb 2020 03:04:59 +0000 (UTC) X-FDA: 76450952718.04.crime45_4885c61d77d07 X-HE-Tag: crime45_4885c61d77d07 X-Filterd-Recvd-Size: 5994 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Feb 2020 03:04:58 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id l18so11200742lfc.1 for ; Mon, 03 Feb 2020 19:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z1Vyy2dQaWIbRA2XQu4ziNe0yP10XTn1l0G7Wgmue1U=; b=XGNBBxXZF7RUp0Y4ma1a+dKbsmXJnIKv27m15LBXOakdbGi/AbCyESelA7XQkdWbRT hrzQfqWd4D/HiiNQCouoe7SYdlK2yAV64ukIfn8xoPngGZDxy9QhVDAT+PjIV38CFOHe 6XAzVlzdGc3//OpvAzhfuRblTHXeQBG2X581w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z1Vyy2dQaWIbRA2XQu4ziNe0yP10XTn1l0G7Wgmue1U=; b=jUD6sko0DN1FYh79nuBFpvh+HyChgumZCzqvy+ZP54tKgXbMnj/csOeiKnQnuUD24u oWVaDnTtiC7QT/bzgnm0FLRX1WI3BQdBeoJ/Smrb8C5POJH+1vIU6sOOVtoz0te+5dT8 tiDdvxJRF0ui65BX+cbBIQOm4HTDQL5evJ595II6ipw5eO9kx6AYgfBR3eGwa+8DPYYq O1ypp7rvgHLE+0PhCUnZfzVOiPesbuwr3djK5rEu6l/6ZqFIW9aRs/MLK7u9WmUvZH6q 20HJQU4KCTkWgaj8jCpmMKoK8a0mSB/coeJNwzlJlfxgpLPWEZ2S0o0z5MDnU8Uj+rk+ m5Fg== X-Gm-Message-State: APjAAAVsUHr8g02SBGzqrMpit+ubRaBeB9rMXnR3aqQlcPaJ6kuPjmLB qp99jgNvFW/Ip506fqZrf3o6ha42+1Tm8w== X-Google-Smtp-Source: APXvYqyo1pqyysAk14htgMc9XgKbqcgXrOo3yWTEQz8ndYL3UPkYNlKWXwVmVZHH+mjs5z4weElEVQ== X-Received: by 2002:ac2:44bc:: with SMTP id c28mr13238860lfm.72.1580785496757; Mon, 03 Feb 2020 19:04:56 -0800 (PST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id k24sm12734327ljj.27.2020.02.03.19.04.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2020 19:04:56 -0800 (PST) Received: by mail-lf1-f48.google.com with SMTP id y19so11155019lfl.9 for ; Mon, 03 Feb 2020 19:04:56 -0800 (PST) X-Received: by 2002:ac2:43a7:: with SMTP id t7mr13701797lfl.125.1580785496001; Mon, 03 Feb 2020 19:04:56 -0800 (PST) MIME-Version: 1.0 References: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> <20200204013402.UfNC2Pqe3%akpm@linux-foundation.org> In-Reply-To: <20200204013402.UfNC2Pqe3%akpm@linux-foundation.org> From: Linus Torvalds Date: Tue, 4 Feb 2020 03:04:40 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 06/67] mm: factor out next_present_section_nr() To: Andrew Morton Cc: Baoquan He , Dan Williams , David Hildenbrand , "Kirill A . Shutemov" , "Kirill A . Shutemov" , Linux-MM , Mel Gorman , Michal Hocko , Michal Hocko , mm-commits@vger.kernel.org, osalvador@suse.de, Pavel Tatashin , Vlastimil Babka , zhi.jin@intel.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: More signs of your - or somebody elses - email scripts being broken: On Tue, Feb 4, 2020 at 1:34 AM Andrew Morton wrote: > > From: David Hildenbrand > Subject: mm: factor out next_present_section_nr() > > Let's move it to the header and use the shorter variant from > mm/page_alloc.c (the original one will also check > "__highest_present_section_nr + 1", which is not necessary). While at it, > make the section_nr in next_pfn() const. > > In next_pfn(), we now return section_nr_to_pfn(-1) instead of -1 once we > exceed __highest_present_section_nr, which doesn't make a difference i= n > the caller as it is big enough (>=3D all sane end_pfn). Here, look at that "i= n". It looks like it was a MIME line-break (so "in" was MIME-encoded and turned into "i=\nn") followed by you or David re-flowing the text without MIME-decoding it. And note the ">=3D" thing. It should be just ">=" but again there is left-over crud from using MIME-encoded data without decoding it. I am noticing that this has apparently happened before too. And maybe it's not you. Maybe it's David Hildenbrand that has sent you already corrupted data. Doing a git log --grep="=3D" shows that this mistake has been done by others before. But it's not _that_ common. I find 25 occurrences of that "=3D" thing in the logs over the whole history of the kernel. The "=\n" thing is much harder to grep for quite that trivially, or the other "random utf8 encoded as MIME and never decoded properly" stuff. But the fact that I found at least _two_ of these cases in just this series, and it had that broken coverletter too, makes me go "Hmm". I tried to look for other cases, but those two emails (both from David Hildenbrand, soo...) were the only ones I found in this series of 67. I can fix them up, of course, but I really hate how somebody has some workflow that generates this corruption. MIME corruption in the patches themselves tends to be much more obvious ("it doesn't apply" or "it no longer builds"). But in the commit message it's not always clear. So please be *careful*. I'm jetlagged in Cambridge UK and was going to apply this series since I was awake anyway, but now I'm not sure I should do that. At a minimum I want to know what the base commit was supposed to be.. Linus