From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F845C433DB for ; Thu, 14 Jan 2021 18:16:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B510B23A50 for ; Thu, 14 Jan 2021 18:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B510B23A50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E43F68D0103; Thu, 14 Jan 2021 13:16:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF4C28D0102; Thu, 14 Jan 2021 13:16:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95CF8D0103; Thu, 14 Jan 2021 13:16:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id B09708D0102 for ; Thu, 14 Jan 2021 13:16:34 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7F1E412ED for ; Thu, 14 Jan 2021 18:16:34 +0000 (UTC) X-FDA: 77705185908.17.thumb69_1614b6927528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 5B45D18025BEE for ; Thu, 14 Jan 2021 18:16:34 +0000 (UTC) X-HE-Tag: thumb69_1614b6927528 X-Filterd-Recvd-Size: 4165 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 18:16:33 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id h205so9351652lfd.5 for ; Thu, 14 Jan 2021 10:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aft+47NxygdBFcq9TFp+5i9C19WqLdlSHw/uTUCv2iM=; b=AgMjhyXp6oKx6fm9HEWMrWNr/lXEqclKxgHaCoAvlOMJ1D6LcOW6GfjutxrkU2cEp+ IPlvcixV4GV7nx92ho32piLUh2Aj8crb+Re1rjCltubtNGngNzNvYVbYznojeuRtOP2H ZQVXkZPhiFkRx0MTXTiZ+uBwhHuwY03R+cENU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aft+47NxygdBFcq9TFp+5i9C19WqLdlSHw/uTUCv2iM=; b=O1RxzmxGB3twIxMKyWwfHHyU08VUaZgD3bcq8ivX0HyqRHQUncghiuBjU7IZFHA7ZS GNwSLHWb8zqbEglSu4dWNhnMImZX5xt31bk+hwPz0pDMvGODS6qu5tS5IL6TQCWOVE7v vriEwI0JmcNwa6dNU+TJXKSP0jUqBodlWAKWnHO1USO0ARy5l+fiz6ghOIeXRrTk3pi5 qXiCVmaMu9CFqs6dVHpvSWP9YQ1CqcNpE8rq+s7Orr4dTYVTAtnbV1SPr1T/FBzKLlQw CpTrie4Ip3CoS/q6KuO94VRF+65Zz+4c2vFgu3STgnCOiNGOsAVawHx5Rv/al8ipSpoW DDWg== X-Gm-Message-State: AOAM532O2Zv9WBC3TLv1gJjmTwJKey6bGnE71HJQ8lB2JmVv2zYLLZmL LkEUtXo7JSS3pRBWnByZ2QGNfGBFD6jWdA== X-Google-Smtp-Source: ABdhPJylQpvrtsk5PfC9IqnCdofCN9Ic3hcmsZySVVdAehYrD5e+li8VEloH50EAvOtNNonZtQRB3Q== X-Received: by 2002:ac2:539b:: with SMTP id g27mr3541508lfh.401.1610648191681; Thu, 14 Jan 2021 10:16:31 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id n13sm299535lfu.265.2021.01.14.10.16.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:16:29 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id o17so9382553lfg.4 for ; Thu, 14 Jan 2021 10:16:29 -0800 (PST) X-Received: by 2002:a05:6512:2287:: with SMTP id f7mr3612591lfu.40.1610648189395; Thu, 14 Jan 2021 10:16:29 -0800 (PST) MIME-Version: 1.0 References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-5-will@kernel.org> In-Reply-To: <20210114175934.13070-5-will@kernel.org> From: Linus Torvalds Date: Thu, 14 Jan 2021 10:16:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/8] mm: Separate fault info out of 'struct vm_fault' To: Will Deacon Cc: Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Hugh Dickins , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > Try to clean this up by splitting the immutable fault information out > into a new 'struct vm_fault_info' which is embedded in 'struct vm_fault' > and will later be made 'const'. The vast majority of this change was > performed with a coccinelle patch: You may have a reason for doing it this way, but my reaction to this was: "just make the new embedded struct unnamed". Then you wouldn't need to do all the automated coccinelle changes. Is there some reason you didn't do that, or just a "oh, I didn't think of it". Linus