From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349C8C433DF for ; Sat, 25 Jul 2020 02:46:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9DF8206C1 for ; Sat, 25 Jul 2020 02:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ONZI0YOu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9DF8206C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 799C16B0027; Fri, 24 Jul 2020 22:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74A286B0029; Fri, 24 Jul 2020 22:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6117D6B002A; Fri, 24 Jul 2020 22:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 47ECA6B0027 for ; Fri, 24 Jul 2020 22:46:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 066BC2300C for ; Sat, 25 Jul 2020 02:46:43 +0000 (UTC) X-FDA: 77075060286.23.elbow01_1614fde26f4c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id CECDA28DA0 for ; Sat, 25 Jul 2020 02:46:42 +0000 (UTC) X-HE-Tag: elbow01_1614fde26f4c X-Filterd-Recvd-Size: 5461 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 02:46:42 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id x9so11848769ljc.5 for ; Fri, 24 Jul 2020 19:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FUH5ZgL4Gg4QInigyESctID6C5txQBv0Qt+FjLQ+12A=; b=ONZI0YOu712KSSeXlHyibd4cF3kZNWrnZe/Yi28TYAyIvPqB54JMYVXkA3HbAaQVF2 J7A37WO2j+ixBZhGoYa4mPAShO8cYECzOO0V4F8bWdfJQC9O86WhkI3TDn2MECGVjSRW c7hVgQMtcFVTbw8mMW8Ewe6ruwHlgcdB7FA6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FUH5ZgL4Gg4QInigyESctID6C5txQBv0Qt+FjLQ+12A=; b=ZT4gYiF84abNh+TVTlXm/vlT2qfzAITRqaHycVUUv07hF65F8a+4CU6vJfgDVUN7+u 5nLwsBgYYrAWmLWYjFadq1Y8kg0EVfvfxzKKu+0B0JbMZ+bcHCoIjSq4bBazBenQPpk1 xPD1fzwwV1+8ml1uqdmQbz9HvxL7inBy0YRZTGPaHkFq3UrnQmVs2tmRdlg+5B9NK443 8l6ZMuTGmekiMmJ5KWA1DcfLSMXb5EE4LPdE/YvL7i4kwrtJ2uLmE3hwFJxI+bN86/lY AEtLrHwPnVqS2tot7lyZd6XnnLYHh7ZvWvrU/nfNCBk6aNMu4aFdFWV3XCik11S4phIb ekOA== X-Gm-Message-State: AOAM531SbmZU8u/k24yuXpU10MgP/txr8DiV3AyktwnuJYUTcuhqrDcN 4Lu7WftHpvWYidYoLv2/VeMmSdyua7A= X-Google-Smtp-Source: ABdhPJyxLsIlvlG/OS5Ej5dRau/K51SGGpVXEY72btaBhOK+ioakjKW94CPfDLRWUzcBXik5uOUeCg== X-Received: by 2002:a05:651c:1291:: with SMTP id 17mr5972964ljc.286.1595645200036; Fri, 24 Jul 2020 19:46:40 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id s1sm656418ljj.96.2020.07.24.19.46.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 19:46:38 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id q6so11838020ljp.4 for ; Fri, 24 Jul 2020 19:46:38 -0700 (PDT) X-Received: by 2002:a2e:86c4:: with SMTP id n4mr5814202ljj.312.1595645198300; Fri, 24 Jul 2020 19:46:38 -0700 (PDT) MIME-Version: 1.0 References: <20200723124749.GA7428@redhat.com> <20200724152424.GC17209@redhat.com> In-Reply-To: From: Linus Torvalds Date: Fri, 24 Jul 2020 19:46:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] mm: silence soft lockups from unlock_page To: Hugh Dickins Cc: Oleg Nesterov , Michal Hocko , Linux-MM , LKML , Andrew Morton , Tim Chen , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CECDA28DA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 24, 2020 at 7:08 PM Hugh Dickins wrote: > > But whatever, what happens on the next run, with these latest patches, > will be more important; and I'll follow this next run with a run on > the baseline without them, to compare results. So the loads you are running are known to have sensitivity to this particular area, and are why you've done your patches to the page wait bit code? Because yes, I think that last version in particular might make a big difference with the "let people continue even if they only saw the wakeup event, and never actually tested and saw the bit clear". Of course, there's a possibility that "big difference" ends up being a negative one. I think it will make the page wait queues shorter (which is good for that latency and lockup thing), but waking things up more aggressively _may_ also end up adding more CPU load, if they then all decide to retry the operation for whatever reason. And hey, it's also possible that it makes no difference at all, because your load mainly tests the exclusive "lock_page()" case, which won't have changed. And that's all assuming they don't show some instability, of course. But the code actually seems fairly simple now, and the basic synchronization hasn't changed, just a behavioral optimization. Famous last words. Linus