From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8F6C433E0 for ; Fri, 3 Jul 2020 19:25:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A379D208E4 for ; Fri, 3 Jul 2020 19:25:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="EhC1qDxG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A379D208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 257A38D008D; Fri, 3 Jul 2020 15:25:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 207238D0030; Fri, 3 Jul 2020 15:25:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F67C8D008D; Fri, 3 Jul 2020 15:25:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id EEE928D0030 for ; Fri, 3 Jul 2020 15:25:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B7382180AD806 for ; Fri, 3 Jul 2020 19:25:01 +0000 (UTC) X-FDA: 76997742402.22.test13_0c111f526e94 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 813CA18038E67 for ; Fri, 3 Jul 2020 19:25:01 +0000 (UTC) X-HE-Tag: test13_0c111f526e94 X-Filterd-Recvd-Size: 3829 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 19:25:01 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id g139so19087366lfd.10 for ; Fri, 03 Jul 2020 12:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nEMPMKHktF+3GiPNxFWdeLrXOxNE07nmroDOEVThA4A=; b=EhC1qDxGOcHnqhdTefcfYAg7Ihgd+dyuCofQ5oRzGgTrAnhAQqF7OzcfuyTH4ovLGg lVeESWYyUkkno7e5pvU5gocokHSLu0r0EG8L+u7jkct0aI3QhIpJFf9k8NwIciFyX7/7 9XeVBI0g2czxapfWKmluX0h7W/Jh645iHYlCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nEMPMKHktF+3GiPNxFWdeLrXOxNE07nmroDOEVThA4A=; b=QTiVKhO/cBP5F4YigZ/lIhjh4i1yRcoCXManrlKW3aDAUL52hDMHrX6dpaSGsA6Qji FXj5eEQY1buTRETATF8e08BNBXRZpgJ+pthS0hD/m8nWhpJe9LcHLQIOM9sGuwGgqViF Z360Qmdq8twsl5DjSo5Z2WBr94332tFG6AQTdWocQnieuBOfherralREl6MYPeLdpNb7 XTdmlpgdQGrPErQfEzEtw29CSNI1T/l/hmjIEKkEA7Xrb/u+utgC+ScYDockTZlvwIUA ptsPtHWnpVjAKSre/kQYedMQ7fofhaPEkj7Lq5BY8NeOeY0nOGFWgl+bHUl758ZLmVRm Jmcg== X-Gm-Message-State: AOAM5308+GbY+b9VIoTbvOM6inxf8NMOUOY56sx7nU2SExbLQ9M214q7 VDEvU/VawimKN5gc0aQz6mW/yDp0Lp0= X-Google-Smtp-Source: ABdhPJz6X9CVkDdM2MPXD7/Oox+XW1a3ADY/klBERYlKjKMwJ8YK4a6A3YOmmgnhikRCyARllkBaig== X-Received: by 2002:ac2:5338:: with SMTP id f24mr6615400lfh.1.1593804299252; Fri, 03 Jul 2020 12:24:59 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id i197sm4998309lfi.58.2020.07.03.12.24.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 12:24:58 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id q4so2473385lji.2 for ; Fri, 03 Jul 2020 12:24:58 -0700 (PDT) X-Received: by 2002:a2e:991:: with SMTP id 139mr20104619ljj.314.1593804298028; Fri, 03 Jul 2020 12:24:58 -0700 (PDT) MIME-Version: 1.0 References: <20200703095325.1491832-1-agruenba@redhat.com> In-Reply-To: <20200703095325.1491832-1-agruenba@redhat.com> From: Linus Torvalds Date: Fri, 3 Jul 2020 12:24:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v2 0/2] Fix gfs2 readahead deadlocks To: Andreas Gruenbacher Cc: Matthew Wilcox , Dave Chinner , linux-fsdevel , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 813CA18038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 3, 2020 at 2:53 AM Andreas Gruenbacher wrote: > > Here's an improved version. If the IOCB_NOIO flag can be added right > away, we can just fix the locking in gfs2. I see nothing wrong with this, and would be ok with getting the patches as pulls from the gfs2 tree despite touching generic code. Maybe wait a bit for others to comment (I see Willy already did), but it seems like a fairly straightforward improvement, and the IOCB_NOIO flag conceptually seems to match well with the IOCB_NOWAIT one, so this all makes sense to me. Linus