From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB8BC433E0 for ; Sun, 31 Jan 2021 00:45:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACE0064E17 for ; Sun, 31 Jan 2021 00:45:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACE0064E17 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00DAD6B0005; Sat, 30 Jan 2021 19:45:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFF876B0006; Sat, 30 Jan 2021 19:45:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC9256B006C; Sat, 30 Jan 2021 19:45:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id C87CA6B0005 for ; Sat, 30 Jan 2021 19:45:48 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8F0CB181AEF1F for ; Sun, 31 Jan 2021 00:45:48 +0000 (UTC) X-FDA: 77764227576.27.stew89_61090c6275b5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 76B3B3D663 for ; Sun, 31 Jan 2021 00:45:48 +0000 (UTC) X-HE-Tag: stew89_61090c6275b5 X-Filterd-Recvd-Size: 4486 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sun, 31 Jan 2021 00:45:47 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id j13so14882967edp.2 for ; Sat, 30 Jan 2021 16:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DD6WrpWIFpx8OEBcyiuO6A2SCACjFJeGyauo7ybABPI=; b=ed5CVkLyOKnKHx2gOTRhmFxU2q6FKrW0udikjcX7cpa463TD+QKnWktODVSFA6jFSs bVmfFtQ0V5LVryuIy+tzPrvF8xQCaThasnQECTTtFo+FSJLo2Q6KNKIVtQC6ATrvDjF1 q4Owka2JEFQ+CCivfQ0SQ8QO0QcFVbvhsbmlU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DD6WrpWIFpx8OEBcyiuO6A2SCACjFJeGyauo7ybABPI=; b=sQNrWthG3mw6tHe6z6jYP12Jjop1fMRBA2VmyfAXL8OexeXssbf+TWe/wYkSum8dV8 pBThRU7m++NekjmxvuokIt7tkGlSV6k/L+vy9KGhBnBpuHvZob9sbg8/EsuWwbEuvT65 XJUEmuxTkW7l/Yw9vP27Mld5tA1p2aPxaoqbIB7TKNfe0IBz926T7IiSbGKs2OJtd7xW HvRcC+Q8xTncXCWwlFOjwe/fcnIA6eCiTXd7ypSkPNRpqTN1QVuSpH2oAVxuYW0jBxtN SrzlTsoW+7cu4Hte9+Y6vwtXWTXljEzbaFu33XtPNrvKKPybDk0tIOu28E9mUDfyh/ci oSIQ== X-Gm-Message-State: AOAM531LXNC+Up6FqXgKyDwX+zDTWsRtUKGLttPOW9xDgSDIeBvu79UU 2VoVo4UZ+wAEZxUQwbY8pjxOuV6f2M/6uw== X-Google-Smtp-Source: ABdhPJxCZjsEoJPIx0Utl3aUtZIIMOupyb9joKOhXOheNhcsdqVxSjshn/f/sPhkF3mplvWD//xctw== X-Received: by 2002:a50:84e7:: with SMTP id 94mr12385997edq.87.1612053946479; Sat, 30 Jan 2021 16:45:46 -0800 (PST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id e6sm6292870edv.46.2021.01.30.16.45.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Jan 2021 16:45:46 -0800 (PST) Received: by mail-ed1-f46.google.com with SMTP id j13so14882945edp.2 for ; Sat, 30 Jan 2021 16:45:46 -0800 (PST) X-Received: by 2002:a2e:8116:: with SMTP id d22mr6026940ljg.48.1612053490367; Sat, 30 Jan 2021 16:38:10 -0800 (PST) MIME-Version: 1.0 References: <20210130221035.4169-1-rppt@kernel.org> <20210130221035.4169-2-rppt@kernel.org> In-Reply-To: <20210130221035.4169-2-rppt@kernel.org> From: Linus Torvalds Date: Sat, 30 Jan 2021 16:37:54 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] x86/setup: always add the beginning of RAM as memblock.memory To: Mike Rapoport Cc: Andrew Morton , Andrea Arcangeli , Baoquan He , Borislav Petkov , Chris Wilson , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , =?UTF-8?Q?=C5=81ukasz_Majczak?= , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , "Sarvela, Tomi P" , Thomas Gleixner , Vlastimil Babka , Linux Kernel Mailing List , Linux-MM , stable , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 30, 2021 at 2:10 PM Mike Rapoport wrote: > > In either case, e820__memblock_setup() won't add the range 0x0000 - 0x1000 > to memblock.memory and later during memory map initialization this range is > left outside any zone. Honestly, this just sounds like memblock being stupid in the first place. Why aren't these zones padded to sane alignments? This patch smells like working around the memblock code being fragile rather than a real fix. That's *particularly* true when the very line above it did a "memblock_reserve()" of the exact same range that the memblock_add() "adds". Linus