From: Linus Torvalds <torvalds@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Jann Horn <jannh@google.com>,
Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeelb@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Christian Brauner <christian@brauner.io>,
David Rientjes <rientjes@google.com>,
Brian Geffon <bgeffon@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Security Officers <security@kernel.org>
Subject: Re: [PATCH] mm/madvise: remove racy mm ownership check
Date: Tue, 8 Dec 2020 20:58:20 -0800 [thread overview]
Message-ID: <CAHk-=wjWDchdE6sd+nwoGmybj96VFC8VOybCSrB7QOouPs+QvA@mail.gmail.com> (raw)
In-Reply-To: <20201209032155.564991-1-minchan@kernel.org>
On Tue, Dec 8, 2020 at 7:22 PM Minchan Kim <minchan@kernel.org> wrote:
>
> Jann spotted the security hole due to race of mm ownership check.
> If the task is sharing the mm_struct but goes through execve()
> before mm_access(), it could skip process_madvise_behavior_valid
> check. That makes *any advice hint* to reach into the remote process.
>
> This patch removes the mm ownership check.
Applied directly - I'm not sure Andrew has anything else pending, so
might as well short-circuit it.
Linus
prev parent reply other threads:[~2020-12-09 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 3:21 [PATCH] mm/madvise: remove racy mm ownership check Minchan Kim
2020-12-09 4:58 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjWDchdE6sd+nwoGmybj96VFC8VOybCSrB7QOouPs+QvA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=christian@brauner.io \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
--cc=security@kernel.org \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).