From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A367C433EF for ; Wed, 23 Feb 2022 20:05:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152A38D0059; Wed, 23 Feb 2022 15:05:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DB338D0053; Wed, 23 Feb 2022 15:05:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E48898D0059; Wed, 23 Feb 2022 15:05:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id B7FD38D0053 for ; Wed, 23 Feb 2022 15:05:26 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 549219F31C for ; Wed, 23 Feb 2022 20:05:26 +0000 (UTC) X-FDA: 79175124252.15.464CA73 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf12.hostedemail.com (Postfix) with ESMTP id C0F2840006 for ; Wed, 23 Feb 2022 20:05:25 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id y24so235492lfg.1 for ; Wed, 23 Feb 2022 12:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+S6BFzj6o5ckty5iXSThNrfkPsdFE94/fVb8NP4+aFs=; b=F/2f/aEUKxSuzDdCknAbug+t8clrlE0v7gj9NkhphhHftuFg6XGIjvpJXVx+ZHKhn9 jOIdz4l7lK+/F1JhXkxR/PARyehOhzu1/S93ijWQKe7fGKOKTiRs9R81aIq3OYNVOgnf G4UcKLBEtMgH8cssPIzV42vV3R64/Z0YRVhdY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+S6BFzj6o5ckty5iXSThNrfkPsdFE94/fVb8NP4+aFs=; b=7W46+YhPWzlAHJiXgY+q8jI/QmxAUonaxP1SLEXE677n0G0DZVHoPMVE2FRMhF4HXN Z3WhZU0C7QPE1qCgwjhU5g1E5XM9zaBu96Lr6lOVH5uEWs4i7STCch4kGRA0lw+6Ee5T UXXwyw9h4GzfmWzMYov0Jwo+/sYb2Ite52Z2G7AKYLWVawVZWtFkmfhhPf0TTc2xX0QF Ng2QaqAVlDwobfhNcOdhnV3NtJQ8HXBmqcx9Xp92JzeQrYlCHe+UnhdoFta0rVDRHVFp sEXBPjgRFVreBatBNiW1BhWV/rIhblFCqhUp6OVyOTYxQOzq5abbK5gphelNUwo08XAQ /F7A== X-Gm-Message-State: AOAM530ikZCZAcQfmtQPYmKXVki5Lw4N3Zyhu/DhVLYXfNwzpYHqlBUI KpwIs9I/U+w/tIiQC0g6IjbZieqMVo2MNbkvKx4= X-Google-Smtp-Source: ABdhPJzHvK7uJVCuWuEMt951QHBqSf+dCSuFVKvLuG0gBrsAVdVrKQTPexfb9M/yiAugEjxabCkuIg== X-Received: by 2002:a19:6b15:0:b0:443:b6ae:2ab7 with SMTP id d21-20020a196b15000000b00443b6ae2ab7mr805556lfa.555.1645646722692; Wed, 23 Feb 2022 12:05:22 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id u4sm74883ljo.103.2022.02.23.12.05.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 12:05:21 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id e5so168365lfr.9 for ; Wed, 23 Feb 2022 12:05:20 -0800 (PST) X-Received: by 2002:a05:6512:130b:b0:443:c2eb:399d with SMTP id x11-20020a056512130b00b00443c2eb399dmr822016lfu.27.1645646720244; Wed, 23 Feb 2022 12:05:20 -0800 (PST) MIME-Version: 1.0 References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-10-arnd@kernel.org> <20220221132456.GA7139@alpha.franken.de> In-Reply-To: <20220221132456.GA7139@alpha.franken.de> From: Linus Torvalds Date: Wed, 23 Feb 2022 12:05:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/18] mips: use simpler access_ok() To: Thomas Bogendoerfer Cc: Arnd Bergmann , Christoph Hellwig , linux-arch , Linux-MM , Linux API , Arnd Bergmann , Linux Kernel Mailing List , Al Viro , Russell King - ARM Linux , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Nick Hu , Greentime Hu , Dinh Nguyen , Stafford Horne , Helge Deller , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Mark Rutland , Heiko Carstens , Rich Felker , David Miller , Richard Weinberger , "the arch/x86 maintainers" , Max Filippov , "Eric W. Biederman" , Andrew Morton , Ard Biesheuvel , alpha , "open list:SYNOPSYS ARC ARCHITECTURE" , linux-csky@vger.kernel.org, linux-hexagon , linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , linux-parisc , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , linux-sparc , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="F/2f/aEU"; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C0F2840006 X-Stat-Signature: jzxc1cyxqf78cc8op5aineh43uknas8q X-HE-Tag: 1645646725-762980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 5:25 AM Thomas Bogendoerfer wrote: > > With this patch [ .. snip snip ..] > I at least get my simple test cases fixed, but I'm not sure this is > correct. I think you really want to do that anyway, just to get things like wild kernel pointers right (ie think get_kernel_nofault() and friends for ftrace etc). They shouldn't happen in any normal situation, but those kinds of unverified pointers is why we _have_ get_kernel_nofault() in the first place. On x86-64, the roughly equivalent situation is that addresses that aren't in canonical format do not take a #PF (page fault), they take a #GP (general protection) fault. So I think you want to do that fixup_exception() for any possible addresses. > Is there a reason to not also #define TASK_SIZE_MAX __UA_LIMIT like > for the 32bit case ? I would suggest against using a non-constant TASK_SIZE_MAX. Being constant is literally one reason why it exists, when TASK_SIZE itself has often been about other things (ie "32-bit process"). Having to load variables for things like get_user() is annoying, if you could do it with a simple constant instead (where that "simple" part is to avoid having to load big values from a constant pool - often constants like "high bit set" can be loaded and compared against more efficiently). Linus