From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B48C433DF for ; Tue, 14 Jul 2020 16:19:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 801742251F for ; Tue, 14 Jul 2020 16:19:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="hPQODzQe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 801742251F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 114646B0007; Tue, 14 Jul 2020 12:19:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C48B6B0008; Tue, 14 Jul 2020 12:19:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF4B66B000A; Tue, 14 Jul 2020 12:19:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id D8FD06B0007 for ; Tue, 14 Jul 2020 12:19:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 653D5180AD838 for ; Tue, 14 Jul 2020 16:19:24 +0000 (UTC) X-FDA: 77037191448.23.laugh24_330f3a126ef2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 1D42A37612 for ; Tue, 14 Jul 2020 16:19:24 +0000 (UTC) X-HE-Tag: laugh24_330f3a126ef2 X-Filterd-Recvd-Size: 4898 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 16:19:23 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id n26so22751339ejx.0 for ; Tue, 14 Jul 2020 09:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jVja+Dm3U4NNdoUzuGjR/wqvDeVbDJNnrorH0uGFQ1c=; b=hPQODzQeZU73y/uYKV3Or723M4Cd3tvDmXFHXDZxwc+KS0m8Ik+d8ktVcP6IwAmUh2 e/Tgq0pCCJ3dVb4vS8wSP+mNSYY+Fbx1xHTpNcw7/DtynQixRQYltmHYu2OHIrdP80P7 B6L7zYegq+LM862HVAY4Aot1lHzFerNg0ZcSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jVja+Dm3U4NNdoUzuGjR/wqvDeVbDJNnrorH0uGFQ1c=; b=VKjSHQHLvEZUWewsMlK2SOLwVYKdYNc5RKT83xKFdPnOy/aBUknLiFPYzV0fXb4V48 Qu2/pty6uwWZH/SXWPbF+0djqtZfiQlBiLz/rMEHpq1H98UwO8xb96N6vf95SUez/BIJ dC1WqIFPvyREMyi94kSl8w+z4irWZKemjsLjT0vVDdGmnqGim2inI+vvEZVYplwebD6d MVY10FHT8IHCekvqzf3LhvlyU4FlVKZgQ5Rc1xTloznSqGHOOVMkxixVMQ6MaEwBEP2V e/xNJROkqNPQJLZ9OCWOwto5L6Y5FVMGbCkfgT6g2L4FHQarjVRFEF40cRxK0qaHU2ZW E8ww== X-Gm-Message-State: AOAM5316139AmlYcfpooUFQs53AFjK1BIfJ8uzXUOx3rUJ0mKrNFlGFy DkLnJXKZFJvSjbHwczVxGMb8M0MzxNI= X-Google-Smtp-Source: ABdhPJyNEh/iJkakdsYGAEfVnqSb3FALY/iYvUHcv7fuUfMmSvUp3EVHwlbVGmHyMa4/Yy79UqjtUA== X-Received: by 2002:a17:906:c10f:: with SMTP id do15mr5464748ejc.249.1594743561894; Tue, 14 Jul 2020 09:19:21 -0700 (PDT) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com. [209.85.218.50]) by smtp.gmail.com with ESMTPSA id x19sm14485074eds.43.2020.07.14.09.19.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 09:19:21 -0700 (PDT) Received: by mail-ej1-f50.google.com with SMTP id lx13so22708560ejb.4 for ; Tue, 14 Jul 2020 09:19:21 -0700 (PDT) X-Received: by 2002:a2e:999a:: with SMTP id w26mr2613302lji.371.1594743064458; Tue, 14 Jul 2020 09:11:04 -0700 (PDT) MIME-Version: 1.0 References: <20200712215041.GA3644504@google.com> <20200714073306.kq4zikkphqje2yzb@box> <20200714160843.GA1685150@google.com> In-Reply-To: <20200714160843.GA1685150@google.com> From: Linus Torvalds Date: Tue, 14 Jul 2020 09:10:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 To: Joel Fernandes Cc: "Kirill A. Shutemov" , Naresh Kamboju , linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1D42A37612 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 14, 2020 at 9:08 AM Joel Fernandes wrote: > > I was thinking we should not call move_page_tables() with overlapping ranges > at all, just to keep things simple. No, we're not breaking the existing stack movement code just to keep things simple. The rule is "make it as simple as possible, but no simpler". And "as possible" in the case of Linux means "no breaking of old interfaces". The stack randomization movement most certainly counts. Linus