From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB39C00144 for ; Fri, 29 Jul 2022 15:32:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247188E0001; Fri, 29 Jul 2022 11:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F6C46B0072; Fri, 29 Jul 2022 11:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E60D8E0001; Fri, 29 Jul 2022 11:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0041E6B0071 for ; Fri, 29 Jul 2022 11:32:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1207381651 for ; Fri, 29 Jul 2022 15:32:41 +0000 (UTC) X-FDA: 79740529722.29.8BA5231 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf23.hostedemail.com (Postfix) with ESMTP id 9A5CD14003A for ; Fri, 29 Jul 2022 15:32:40 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id mf4so9177941ejc.3 for ; Fri, 29 Jul 2022 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=jmBIRMRQS/VgtMcMzm0Oe80Xtab0xlTKGKq4qVMd4kY=; b=ZlQLOFKuTG5vgUQiyuXFtBbf6p1VnWLpTKhhUn8bD9oI97N5UwWofWf/jVXh+6FEI3 PsrYm8DSkIGvjUy6Fu+MYXsgMbiqP9ECFlJ1NYDkty/Tt9xK6EtUkaWcc/lIPnnnBJrT SSwomT5XTaslGcRyymoPuanPAzQDSWB+Xonos7q4IqLOs7TX3pG/ewNHud2BZwCUFcXB PvYO8+1rd3Ivlb1cCgo3FkA03JRCQ1XJVBS1uAU0EuUMh7/kFWcjMwulMFcpri8FXQzv Sm+i3mWxDcq0FNDUiUq2Zkuixu5Jrsl3/+fyCQgTYHOdRPH/EEEDGgDNiXaGhCMpdfNx gJEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=jmBIRMRQS/VgtMcMzm0Oe80Xtab0xlTKGKq4qVMd4kY=; b=IIS5DbgQoFTd4/+L+S+I6lHTV2ojADLnY9Wh2Ztz4AvlNcA3pJmV281dVuUAYifhaN 6QqgqShSufYBfpnz74GS5En/hh2N8pN5whh6DgeqHWeVD/s4xlWvz2BOGmIk83sM77Zo S3HTn1zIWS3JcI82iwUUQElYNozfUfnnul2nfzuk8cjV+18x65+y7Bm/J855gydoMEuN YSj83pCSBtuKqqAfxwNrMbvJQQ98L24ERk8uwINd6PMhnWHBwlGeJZTB3Kz/525nS5K6 85Lpu7KOzMxgqEDSbTB8ZTcKeuy0Q3Udfli5dzf9HpQSXKvX1dfbY4I7V+ou4p1PGCQ9 DmKw== X-Gm-Message-State: AJIora/cA0184dDz5pcjoqmmu+NsCo61S2tzCA4ro1APnts0FPsLn3O6 lowKibfcHWKat2pRHKX86gTb8+g74W+Gessb1wU= X-Google-Smtp-Source: AGRyM1vNISp+OeLGZrYIy7SfAY+GquNrF6kbAQH50eNQJ5t6bF8PfYsV9OfaunP6KrxX7eG9G6dp9UZnVijPuCqsW6I= X-Received: by 2002:a17:907:9706:b0:72b:4b0d:86a2 with SMTP id jg6-20020a170907970600b0072b4b0d86a2mr3227461ejc.242.1659108759194; Fri, 29 Jul 2022 08:32:39 -0700 (PDT) MIME-Version: 1.0 References: <20220426180203.70782-1-jvgediya@linux.ibm.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 29 Jul 2022 17:32:01 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() To: Alexey Dobriyan Cc: Andy Shevchenko , Matthew Wilcox , Mark Rutland , Jagdish Gediya , Linux Kernel Mailing List , linux-mm , ying.huang@intel.com, Dave Hansen , Jonathan Cameron , Andrew Morton , Richard Fitzgerald , Petr Mladek , Will Deacon Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659108760; a=rsa-sha256; cv=none; b=Wz62Ealox7rvfmABj6CjgySsmGjcne13RAXGliO2f9iVvHB33IP2sdhFghGho6DFvCtHGX aG/ebFqv+Has8C83e7kar/zdXtkNhRyCXTYPbiI6E0z6n2zEo/iwX1EYbAl2rHHucrAQdv HbGzAoeOEYbYA/Zkzyu7S2fuxCqtHmk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZlQLOFKu; spf=pass (imf23.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659108760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jmBIRMRQS/VgtMcMzm0Oe80Xtab0xlTKGKq4qVMd4kY=; b=H45iQFWPwgGLZIBUCQKKkTzPovoWfLXbV2GpDT+xeOcz/8J4et0m7i1wLGrxqdTkXpEVi3 eFb97d08Xa2Ol2ca6ILAey3sVg+YQFZpljJ8p1WE3WbLXK8iSUGO79MmIH4oZn45hAywPJ 9DN60XM2iaQLxWrU3HZMA7kuRV7rj0E= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZlQLOFKu; spf=pass (imf23.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A5CD14003A X-Stat-Signature: cxokoujyfun1pdewu7j7ffmarj7uxmf6 X-HE-Tag: 1659108760-420975 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 29, 2022 at 5:21 PM Alexey Dobriyan wrote: > On Fri, Jul 29, 2022 at 05:35:26PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 25, 2022 at 04:21:11PM +0100, Matthew Wilcox wrote: > > > On Mon, Jul 25, 2022 at 03:55:27PM +0100, Mark Rutland wrote: ... > > > Well, that's going to break people who've started using the new option. > > > As a quick fix, how about only allowing either "f\0" or "fa"? > > > > I think we need to be more strict in kstrtobool(), i.e. 'f\0' ('t\0') and 'fal' > > ('tru') perhaps? > > lol what? > > the only way to be strict is to accept "0" and "1" with optional > newline and delete all the rubbish entirely. You have an anti-user mindset. Be more constructive, please. -- With Best Regards, Andy Shevchenko