From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B766DC433DB for ; Mon, 8 Feb 2021 13:26:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1262164E26 for ; Mon, 8 Feb 2021 13:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1262164E26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 42AE06B0006; Mon, 8 Feb 2021 08:26:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1186B006C; Mon, 8 Feb 2021 08:26:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E7B66B006E; Mon, 8 Feb 2021 08:26:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 1883F6B0006 for ; Mon, 8 Feb 2021 08:26:18 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D56A38249980 for ; Mon, 8 Feb 2021 13:26:17 +0000 (UTC) X-FDA: 77795174394.14.ocean66_370a365275ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B03C318229835 for ; Mon, 8 Feb 2021 13:26:17 +0000 (UTC) X-HE-Tag: ocean66_370a365275ff X-Filterd-Recvd-Size: 4374 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 13:26:17 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id r38so10179391pgk.13 for ; Mon, 08 Feb 2021 05:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lbNVw0blb9h/d3DKBZ+tlSkBAWgYcu2EY7pdWUJ8R8Q=; b=T6sTlCGO/g6U+NOiCA464UwO8ijdPpSZOpM7NiQenIPVB/GRtx9cFMWEMqz3XlMs7F mAUl5mKvD/FaJdvGtRnjXl69DDch3WyyedTDMuearxyE6hkPEgOOtED9ny+5OIUKTcTp 97otTPVSVanhbCSS1a20tpxKrWz5BqtmRuDvLrw0NySU8yKD8jQantfzMq5ubqyoGu9a 4pFjdi8SMg+MGRGv8xB1zfea/+z8GBcGOGzgkTYs2kO7Q6G3u05fDM4jsesnTzy8sBV2 DDLTiXncgxMXL4xIGOTwY/NLC3WoBUbSKggRtCtkf97VEKqNAP/NJifd50iC6bDcUrw/ jOwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lbNVw0blb9h/d3DKBZ+tlSkBAWgYcu2EY7pdWUJ8R8Q=; b=BqlS6FJqBlQ6EDKTkoGNFU7froyZlSr7BpssGOgnT6DVrjvS4YSvPDl1A1lezA0KNf yGNZgiioy4OCltvnVr/mCai9itYGxGIl4sNvXbp6QFycDbLtpEqantqWjdN7cb97pLZz hgky/Hkc+UPwSKYdQ7muGD7c9Qv4xvvfcqGPvru4A/pBXUMbnTYsmqO5n4zZRyWt3jjr me0hVjRJCdXyPNb8w+6UGo15Sz3o7Sy5T9ibp5aSn/MZnDC/q6eqZDN6ZhWiBvb+NU8U N7vkVnC3z/doWZzZaHItTQktJ9Q05CdWmWipxhVMf19P6viXXhe8/lJn/5/73KYqKThn hcRA== X-Gm-Message-State: AOAM531Zt4I/xmIQ2kU1Kg+ArLm62E+hMUuB77KIfH4bh9PlhygdAFCL qmvL5hXjy1mTgWHrrMUpv/nwUDI73ug0r52/CMg= X-Google-Smtp-Source: ABdhPJxqxCH5zvob7KqNKqfR+QHy3lJpm4iKMFfVqycVnGwgz6TQZ5yJJaMxf2zbqBncTC24DmLKtH8KP3yahtFAehc= X-Received: by 2002:a63:4f1e:: with SMTP id d30mr16764697pgb.203.1612790776109; Mon, 08 Feb 2021 05:26:16 -0800 (PST) MIME-Version: 1.0 References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208122009.GN308988@casper.infradead.org> In-Reply-To: <20210208122009.GN308988@casper.infradead.org> From: Andy Shevchenko Date: Mon, 8 Feb 2021 15:25:59 +0200 Message-ID: Subject: Re: [PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags To: Matthew Wilcox Cc: Yafang Shao , Andy Shevchenko , david@redhat.com, vbabka@suse.cz, Christoph Lameter , linmiaohe@huawei.com, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Joe Perches , linux-mm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 8, 2021 at 2:37 PM Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 06:14:36PM +0800, Yafang Shao wrote: > > To avoid breaking some tools which parsing pGp via debugfs or affecting > > the printf buffer, other new formats are introduced, so the user can choose > > what and in which order they want, suggested by Andy. These new introduced > > format as follows, > > pGpb: print other information first and then the names of page flags > > pGpl: print the names of page flags first and then the other info > > This is overengineering things. We already print in little-endian order, > and the other information should be tacked onto the end. Just extend > %pGp. Andy's suggestion to add another flag was a bad one. Fair enough, I can admit this because I don't know the mm specifics. However, my initial point was about the long message which might be cut into pieces during Oops or whatever and the user will get the first parts only. Depends on what you consider as a higher priority to print the order might be different. Initial patch suggested to print the new fields first. -- With Best Regards, Andy Shevchenko