From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D66EC433DB for ; Wed, 10 Feb 2021 11:47:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69A4264E2A for ; Wed, 10 Feb 2021 11:47:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A4264E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB0A96B006E; Wed, 10 Feb 2021 06:47:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C39B86B0070; Wed, 10 Feb 2021 06:47:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00BD6B0071; Wed, 10 Feb 2021 06:47:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 92F2F6B006E for ; Wed, 10 Feb 2021 06:47:57 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5C0428248047 for ; Wed, 10 Feb 2021 11:47:57 +0000 (UTC) X-FDA: 77802184194.05.7D32105 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 7B58EA0000FC for ; Wed, 10 Feb 2021 11:47:56 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id k13so1077497pfh.13 for ; Wed, 10 Feb 2021 03:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FwhQWQcXOYcRdwhUuOHm0u5zszXz7WPkm4PdHoVK8WA=; b=rXlyVjCrQGaXRg/2MVoSkt5wv3hssM0LAX+7UPuG3iMDCEBXXWTcGJ45kFm2LLFMyC +qOD99PZITQ8T1RyJmAd+cpgt72dlFiKxtchZoLaDYsNUbHvOtm7sfCeBlTa9OFzQ0ya LAUCJgeqIXReb1CHjrI56L8ArODTtGcdXRcLpEEKCBk2ms9zc9GXGoaU0ezH88fB+hqi VIM/whY7w97RD3XA/O+mbPqOJdZUx01R1QoOZSOdvKdeV3sHYzoKU2G9Tr6O+Jmk3/2z 2tFv9kbK2rFuAdLbE+//BXSLq1VGMTNkYlRT6mK0dDFWFdNuAiTixFWtLZsNe0Mo7pGP MhAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FwhQWQcXOYcRdwhUuOHm0u5zszXz7WPkm4PdHoVK8WA=; b=TJsBcwZsuulOWqWWIWQPbbTsJT8khCMJKx0u2vLXyvPSK1WQ+O8uzmKOuxHadOrTci x9Lv72Nb/MGzGrOg/2+tN5sPttDfTpxYTJSxj5rGkv6PKbT296fQZTg7mIcJib8ufLpX WVoKqL+xpxbxCQdhvCWowhyQVzuJXEux3dMSDXW8cbRfZdOHllv8JWs9v56GHNmK0bMF GYoWTqnqdL6wSmrU9rdCFQbFJYRdI5XwpsbmZdgZUMBxrtAlzEaw7O3c2/J8EyEtam0A B4KuBP//bbulGrbO2SimLBH6RZ7ie5Ls7duNGwAW3k78Qu72TbpACZCQjnilgwOMAzVI g1uQ== X-Gm-Message-State: AOAM533nODiSOkKJQ64ofP7vZYsCA9nNNJQstwwTiVbHHGMF3ILMoXOc T0bNYn/ZGiVLrm8jAmWBlEwxQVwgyGtHU5wSODQ= X-Google-Smtp-Source: ABdhPJyfVGi0uwy4EI40frHSBiF+i9wRYQo78rkrCkII3Yugzi/xQ6NQA8drVMpRv2Mww5VQufn8qYli9tYZcG1F4n0= X-Received: by 2002:a63:3d0:: with SMTP id 199mr2782236pgd.4.1612957675693; Wed, 10 Feb 2021 03:47:55 -0800 (PST) MIME-Version: 1.0 References: <20210210051814.845713-1-timur@kernel.org> In-Reply-To: <20210210051814.845713-1-timur@kernel.org> From: Andy Shevchenko Date: Wed, 10 Feb 2021 13:47:39 +0200 Message-ID: Subject: Re: [PATCH 0/3][RESEND] add support for never printing hashed addresses To: Timur Tabi Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Vlastimil Babka , Andy Shevchenko , Matthew Wilcox , Andrew Morton , Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , Akinobu Mita , Alexander Potapenko , Andrey Konovalov , Marco Elver , Rasmus Villemoes , Pavel Machek , Linux Kernel Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 9u34n95pkb45xe9jfkqmhosecbmm6qoz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7B58EA0000FC Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pf1-f175.google.com; client-ip=209.85.210.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612957676-409320 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 10:33 AM Timur Tabi wrote: > > [accidentally sent from the wrong email address, so resending] > > [The list of email addresses on CC: is getting quite lengthy, > so I hope I've included everyone.] > > Although hashing addresses printed via printk does make the > kernel more secure, it interferes with debugging, especially > with some functions like print_hex_dump() which always uses > hashed addresses. > > To avoid having to choose between %p and %px, it's easier to > add a kernel command line that treats all %p as %px. This > encourages developers to use %p more without making debugging > more difficult. > > Patches #1 and #2 upgrade the kselftest framework so that > it can report on tests that were skipped outright. This > is needed for the test_printf module which will now skip > %p hashing tests if hashing is disabled. > > Patch #2 upgrades the printf library to check the command > line. It also updates test_printf(). It's a bit hard in some mailers (like Gmail) to see the different versions of your patches. Can you use in the future - either `git format-patch -v ...`, where is a version - or `git format-patch --subject-prefix="PATCH vX / RESEND / etc" ...` ? -- With Best Regards, Andy Shevchenko