From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4032BC433DF for ; Wed, 10 Jun 2020 15:21:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6AF520734 for ; Wed, 10 Jun 2020 15:21:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=colorremedies-com.20150623.gappssmtp.com header.i=@colorremedies-com.20150623.gappssmtp.com header.b="qaYBaPVB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6AF520734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=colorremedies.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FD826B0031; Wed, 10 Jun 2020 11:21:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AE6D6B0033; Wed, 10 Jun 2020 11:21:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C3326B0036; Wed, 10 Jun 2020 11:21:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 03C676B0031 for ; Wed, 10 Jun 2020 11:21:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B0E26119D69 for ; Wed, 10 Jun 2020 15:21:55 +0000 (UTC) X-FDA: 76913667390.25.waves27_50097f026dcc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 558851808FB69 for ; Wed, 10 Jun 2020 15:21:23 +0000 (UTC) X-HE-Tag: waves27_50097f026dcc X-Filterd-Recvd-Size: 4856 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 15:21:22 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id x6so2700765wrm.13 for ; Wed, 10 Jun 2020 08:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=colorremedies-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=osh5MJSFMdxUmViMeW1hXJs1MHrP/PGYythOWIn5o50=; b=qaYBaPVBTnLnSmjjYJqCguxM4bkLYxodiPJdKy0LbKNtpumL5GzEA+cKK2CHnb4vk3 cFGHc776qjZjAplpzbke4CDxDt4lNHQtH4o+FsJyCnhwEA254eYlysvLhF6hMnlqrf7F 18iMb969CtRbNtmCq445VnXiBjAuSzn2VAVpdJM/oMZFZquKCX7MAsaBZbumWk6iibd9 liuhsBPz/i283Sb2vNo8rnsQDMlowSpVoSEOjC9pbQ05zPwRRDjZj6Ic0VkZi1k9kmx1 RzFbEPkqIFdukNsGGplQSw/IziACCn0H5laovgjDJ7sJRyy5Km9qlvvAoKhlnA6tqLuq qjuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=osh5MJSFMdxUmViMeW1hXJs1MHrP/PGYythOWIn5o50=; b=b6HowbboCKrohur2xA+IFB1LrShRNjvFeoh/2+1bk+GpgahNdi7U4j+0cJ2CJ5cE70 PXCbXnZYXqIIjAjLAz7x6QBcG9sgg2JgD4r289vb9qXp/ohW85d7AoCoYYfpG1vVbKZD N2lZhHC25IaxzJOsdnwgznNN0KBWwzdK3qCzmzaNxU3lJTXqha92JXTi98OGhkpksG19 1wnE2gB0/W0A0hdp7+nABn5wOzRt3F6Zvf8ZWJd9p+etA2x1Mav78hRIGiZpzj8dVW9G HqUuCo2PIDIle7W8Ueb80KAVe3e2/RrHej4t49gODdutkOzKob6CZPC7d1YaWf5An/FY 6Mcw== X-Gm-Message-State: AOAM531LaZqM2Nbb0z50IsSwt0RvIkFdWHE9YlJfoU22ru2J34jsy8ud tzhS8n9c3eke5LqNRRr5PNNAK90QIM34SwxPwTAgZg== X-Google-Smtp-Source: ABdhPJx7qcSs0EuFIhAEzFPMDmm5AGlAY5aHipyLEFRfnZHNH31HfevVnuJkU/beR7hxDhKw/DiPGsOQn0WsTOc5EbA= X-Received: by 2002:a5d:5092:: with SMTP id a18mr4283319wrt.42.1591802481510; Wed, 10 Jun 2020 08:21:21 -0700 (PDT) MIME-Version: 1.0 References: <20200606151254.GO19604@bombadil.infradead.org> <20200608114445.GT19604@bombadil.infradead.org> In-Reply-To: From: Chris Murphy Date: Wed, 10 Jun 2020 09:21:05 -0600 Message-ID: Subject: Re: 5.7.0 page allocation failure: order:0, mode:0x400d0 To: Hugh Dickins Cc: Matthew Wilcox , Vlastimil Babka , Chris Murphy , Linux Memory Management List , Chris Wilson Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 558851808FB69 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 3:33 PM Hugh Dickins wrote: > > ChrisM, could you try with the patch below, and see if it works > for you - I hope it doesn't just give you a blank screen. I can - however... > --- 5.7.0/mm/swap_state.c 2020-05-31 16:49:15.000000000 -0700 > +++ linux/mm/swap_state.c 2020-06-08 14:27:38.211813658 -0700 > @@ -23,6 +23,7 @@ > #include > > #include > +#include "internal.h" $ git status On branch test57rc7gcc10001 nothing to commit, working tree clean $ grep pgtable mm/swap_state.c $ I'm missing something. And there's more... > > /* > * swapper_space is a fiction, retained to simplify the path through > @@ -418,7 +419,8 @@ struct page *__read_swap_cache_async(swp > /* May fail (-ENOMEM) if XArray node allocation failed. */ > __SetPageLocked(new_page); > __SetPageSwapBacked(new_page); > - err = add_to_swap_cache(new_page, entry, gfp_mask & GFP_KERNEL); > + err = add_to_swap_cache(new_page, entry, > + gfp_mask & GFP_RECLAIM_MASK); > if (likely(!err)) { > /* Initiate read into locked page */ > SetPageWorkingset(new_page); Neither the line above or below this insertion match what I have. 424 /* 425 * The swap entry is ours to swap in. Prepare the new page. 426 */ 427 428 __SetPageLocked(page); 429 __SetPageSwapBacked(page); 430 431 /* May fail (-ENOMEM) if XArray node allocation failed. */ 432 if (add_to_swap_cache(page, entry, gfp_mask & GFP_KERNEL)) { 433 put_swap_page(page, entry); 434 goto fail_unlock; 435 } -- Chris Murphy