From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F97C433F5 for ; Thu, 7 Apr 2022 23:05:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 166D06B0072; Thu, 7 Apr 2022 19:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 115266B0073; Thu, 7 Apr 2022 19:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF8B46B0074; Thu, 7 Apr 2022 19:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id E18E06B0072 for ; Thu, 7 Apr 2022 19:05:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A981D8249980 for ; Thu, 7 Apr 2022 23:05:00 +0000 (UTC) X-FDA: 79331615160.27.2C9B6AC Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf15.hostedemail.com (Postfix) with ESMTP id 3296EA0002 for ; Thu, 7 Apr 2022 23:04:59 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id ku13-20020a17090b218d00b001ca8fcd3adeso10319572pjb.2 for ; Thu, 07 Apr 2022 16:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LQwT+/mAGUqM3bKuuBQMYn0uTeyRqxSYD1X0xo7/rPE=; b=Te8C7q8zW+qLm4J/emex42n1YOTNTgYioZ6aL6jd2MEBaCBiG1MonTEaVigQYrxCnX lc2a1Zp9F/CS9bGuKEKpu93mdMYLs+lQfsbi5mhteuVgcuoJm0wqWfraYddXR8D2bRg6 g80ZitZ42SJag/feMLrn8DX95l13h9byUhXsltGRKCs9KWV88T/Q6QdZkDXhfdleSkQe ryLxvSOK7GWWj6jsOpKFb2APmR0DtW+cvDsI5vs30igZtouAhcFKm2Hq3Ic2zZxJev/e Hyk2ptU132DXhvbF7YzTGVCDK2FzEn2yYfELqe296BiWwOwU5IvauV2Zbzna4r5BI7u0 VEvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LQwT+/mAGUqM3bKuuBQMYn0uTeyRqxSYD1X0xo7/rPE=; b=EFklZMvQkNZvUS91EuWsLEKkn8G1TS1719t3xgoK9PU+dYDl1MtV9EMIgaiO9KCuyc zxf/iF2xxNBhr4oPAS49QhZH7yqTk+qKGxa7BpbwpHlusUtjXyd2OKkLjLgNZfovRmv7 h9JlyNWW+cmIVAGlNicVFf49SrsAphbCjl0lCBmMwFbA3eUBpLxMwL8aWhsdm/n+UMis ZW19zCdaiWP9HECqZFMuuZKXcdDgHi0xtRVlNtxWAvpBWm3x6Gi64KJhMQXQRLQ1GXtf jpO5Hhga8ZI/63W1OaMyRNwWFil+wfIBkp+uij5OHjGiVTuwjGvzSRxsjbvJwI+g2KkC 0QXQ== X-Gm-Message-State: AOAM533oGGei15JAv3nwvYfgO6g4B2AtMUt8lk61gg7ZC/fZ5o3GRSog i4J1jSlwOOh26kkHR/jz7dEmnH67YTAVyJHBk4xTIQ== X-Google-Smtp-Source: ABdhPJwyhCRn0iVyHg2CNrALoCcH3RqdRakJthXzqTS4zMpJZcTUNX/0eDdWvG2pEr2k9AtFzvO+MIBVwETlcC1KafM= X-Received: by 2002:a17:90a:c791:b0:1c7:26eb:88dd with SMTP id gn17-20020a17090ac79100b001c726eb88ddmr18367740pjb.218.1649372698677; Thu, 07 Apr 2022 16:04:58 -0700 (PDT) MIME-Version: 1.0 References: <20220407224244.1374102-1-yosryahmed@google.com> <20220407224244.1374102-4-yosryahmed@google.com> In-Reply-To: <20220407224244.1374102-4-yosryahmed@google.com> From: Yosry Ahmed Date: Thu, 7 Apr 2022 16:04:22 -0700 Message-ID: Subject: Re: [PATCH v2 3/4] selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory To: Andrew Morton Cc: David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , Johannes Weiner , Huang@google.com, Ying , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Tim Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel Mailing List , Linux-MM , linux-kselftest@vger.kernel.org, Michal Hocko , Shakeel Butt , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3296EA0002 X-Stat-Signature: s5m3xqp3kxz6rdf48ex8coddqnm7c6nu X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Te8C7q8z; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-HE-Tag: 1649372699-665027 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 7, 2022 at 3:43 PM Yosry Ahmed wrote: > > Currently, alloc_anon_noexit() calls alloc_anon() which instantly frees > the allocated memory. alloc_anon_noexit() is usually used with > cg_run_nowait() to run a process in the background that allocates > memory. It makes sense for the background process to keep the memory > allocated and not instantly free it (otherwise there is no point of > running it in the background). > > Signed-off-by: Yosry Ahmed > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index 36ccf2322e21..c1ec71d83af7 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -211,13 +211,18 @@ static int alloc_pagecache_50M_noexit(const char *cgroup, void *arg) > static int alloc_anon_noexit(const char *cgroup, void *arg) > { > int ppid = getppid(); > + size_t size = (unsigned long)arg; > + char *buf, *ptr; > > - if (alloc_anon(cgroup, arg)) > - return -1; > + buf = malloc(size); > + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) > + *ptr = 0; > > while (getppid() == ppid) > sleep(1); > > + printf("Freeing buffer"); Hey Andew, I am very sorry but I left a debugging printf there by mistake. If it's no hassle, do you mind removing it from the patch (assuming I won't need to send a v3 anyway)? Thanks! > + free(buf); > return 0; > } > > -- > 2.35.1.1178.g4f1659d476-goog >