From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BCDC4345F for ; Sat, 27 Apr 2024 01:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C38D66B009D; Fri, 26 Apr 2024 21:19:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC02B6B009F; Fri, 26 Apr 2024 21:19:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60E06B00A0; Fri, 26 Apr 2024 21:19:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 83A2E6B009D for ; Fri, 26 Apr 2024 21:19:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 001058017A for ; Sat, 27 Apr 2024 01:19:31 +0000 (UTC) X-FDA: 82053554184.18.FA37F3E Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf29.hostedemail.com (Postfix) with ESMTP id 2F7AD120003 for ; Sat, 27 Apr 2024 01:19:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Qx4KDDXX; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714180770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F8/x6WYm3mQ7WVqeZZcGcM1pO3CXxx3F+6ucXZwlnGY=; b=Q9GqPTUN+1kjSzpxjGhRZOaW57pwa7n1jWrOODjjMt2x3+vvCav9T3w6/zw/f7v+u2npLw Aiv8a4pucyhfQ/DJMs+/NvEgHJx1icLqAIifpBjPVmi7MIkGEjfqDUS0Br14qLqE08xV+p +dDRbTKsAIitfLDcWzN+Q36IZlELUWU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Qx4KDDXX; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714180770; a=rsa-sha256; cv=none; b=wyzJRJMEEnoO2JKm6GAnPvAbnZdpEAIPMt1kNAeN9tNbnOWmk2EaY2R6zYmqDYc6P7/P9j 8ArUwl+gdU9PwwwLImLByaBUZCBfmDg7BIkzX63c6xcm/vWJENihY5vkiVXIL+rWNj1Cuk j8QfDXRzynvNHe9sdFjIPEQFcJGkvK4= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a58872c07d8so681942466b.0 for ; Fri, 26 Apr 2024 18:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714180769; x=1714785569; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F8/x6WYm3mQ7WVqeZZcGcM1pO3CXxx3F+6ucXZwlnGY=; b=Qx4KDDXXSpcpjdhJMDNeVwx8Tbmk9VR5f/JPG8/UTAl5DI5MepxnEys0LyfTPHbR/9 jsNHkyIFLvH4wLgMlJGlk+6Dul5UNg2i8SG+L7o/Q9jjg9Qx/K+/zsKjIGe08PO+QPV8 FmJgJobbCoP+EnCjLF/AgAu4mqMTKP6+XdaBv/UHDOnYeJE1NVzVGJFzhszO4jwv1rjB 0O5xsZBvaGh2ylf+z/ATpU532Kl/BMMVMZ8SRPkRc6KJsH/xz4ZihLUg43YXIp8sd8mL m6P3G1rfIhn3IDNB60S3OrpqAk2AV2TCia7+wLyuVrjT+dzBHspnH1dx2Sp2P/JOmOEE nCuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714180769; x=1714785569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F8/x6WYm3mQ7WVqeZZcGcM1pO3CXxx3F+6ucXZwlnGY=; b=C0rqjPa77Q7NMRny/qKGKQpKWbSHJmyNIMnmBSLelA7VY4TZBX0HAp5Ncj7TAgzfKA uGGlqDd5cTjkrcd/d5+rGRNV99T5WDFR7MqFsMoPo/E4EKvLU3Sf2cg8Qu4k1Ucuk37Z C9E46CbdhBr+9HcA1Jkjl51CFfE47mOsmL+Xx1yZ9/j4v01LlFoA0jHHfnnf2IkoNi4k RbsegjeASs23K8B4F/kCtpHYMr3s+a0tbrarNiZsEzOs0E2i4AX/O7W3PXrM/2mWQhG2 l5S00z9vSVdyHQF4Knfco56KP402loL0McR1xUHD0FHgFJfL44QYz0iNpPI2BNh418gQ xS7Q== X-Forwarded-Encrypted: i=1; AJvYcCUVB4DQGMyijzOW5eQ/e9zF6X/I9ok9eAJc55tY+dWVIaniZk0rOlhoFfDM1AeslDOkASOBXbhMqEWZxuDozqGSV4A= X-Gm-Message-State: AOJu0YzBNK3SffkWceu9z1Y4WXYJNnunxj7ubOcy8d63dPbLnsWnyZay Jax836nUK4oAyn+5B5k6i4p9vfT7ojVKP6Jb7B8MEAZoI5fhbj951wDY5oW7PjdcSG5bPF3S3// lggllmHQG5TeuMK9PjVQ39E9RooMMSurTb99JQDU+jh9zNi+9UBtCjIM= X-Google-Smtp-Source: AGHT+IG0f9S4ycgs6mnMWIYUkxy6HkdXLaCSm8YGZNVaE99RGDxlclwkVJR5scPSkfl9vXt65rgn3OiQEijC1VLK9TY= X-Received: by 2002:a17:906:4945:b0:a58:e3d5:87bd with SMTP id f5-20020a170906494500b00a58e3d587bdmr653470ejt.26.1714180768557; Fri, 26 Apr 2024 18:19:28 -0700 (PDT) MIME-Version: 1.0 References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-4-shakeel.butt@linux.dev> In-Reply-To: From: Yosry Ahmed Date: Fri, 26 Apr 2024 18:18:50 -0700 Message-ID: Subject: Re: [PATCH v2 3/7] memcg: reduce memory for the lruvec and memcg stats To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2F7AD120003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1nbcm7szyj5xhbsuqpu1d5x7315pjgf4 X-HE-Tag: 1714180769-632273 X-HE-Meta: U2FsdGVkX1/iFOGMQ0ImCUqUyJocPfRw2Nr3wk+Gj13Uo79lWqlM5Y9tnoDvY4vcN6A7bvCcSfvlrAITw80pkCvAb04by2USMKm6FfAEN1iqp8JSk/zTcEARPg4DNqjo8yzRcxmF2H+Rtk+vLqXYGXGIcPTmft1IrEHb083Ky9oYLsxDYku0ackDKivh8i9/DP2QeLP4RDLuVYhZPjrRY0RzRteg0cfTyKoNQzcWX9+2eUW0XFKV+sh/VByNSFdsIo+uUxEPAmn4/K3snTb4cKxbYT0Z7vKsMOw3ptwllVRbzkGOImJWqu9k5NraayiEZ/b0e2urd1M9tKZVOKPmG0Ky8zjqOD6mQMs04/P4MidCTY2RBLe+VhjDlwDYOaIaJmWWo7IYcGKKQg00Jw2vzIHqdaGlMsPPcqxGcd7VM3hHAXXO3K50/aLeDV4n7mNMmDCmg3IPjXj2s+bIatEOCgwMpSNZSSyFeVzBnqjakQSrFBFckJwJ94swHAcPlsxcozfwrMhZy68oQf//b03Q/HZkXmr/KYQoEgWmh58vbyl9rY2dom5zw5qZ5ljWLlzLKtI1xOpmjW4ZOek9qAzxTLUn47JKC2ve5sX0rHGj3rQ40PWWakYKyqSwBkTrt6Oj9fbN/z8nO/gwweXD8jRnXLE2qMsIucoupIQL6kB88A6Uzcxxu8VduWoDuq1/V4vGhwin002N89+7lCaBTR4wCeN8CEql3BDHSmPhwOmVSC5U3x6C/By0vr5UaL0Gnx02pze5unOaXsplC3fsZM4L/IjUJQ8U4n6QceQtBlEcez3giFP8ov1D8pkNrqoGUqd/Pn1psonFrOowqkH/VQoGItwm8G++rG5U5ZHKUvE86stTh2qNWlWcWJZfVlr4YHYPMD+gXhOYiX1Q+Mc0K2mstT1sLFUt5xg4qfV+5yEgIh3bVAd4bUII3EOqe0Hmfk2rbSoN2Rnx3iShRpZz8Ki DpRXVQag RHoDDGOFvSLtjRcY3FOmOYEvctOCc068DlMKYCSTEgeiCbcmC98CYLiZDCoZkFGwk7O8++BBOdMIvB2v9i2QuSL+dfZ5UPOxra4NhFx726CgZhCmzHBVwyF++sWSKzKfuD3EatbO9AcPMAvaW3eBSUaqm5qZh8ZCEfIEeQxfMTTgZSQPtLx6y5SF9sWR8Dy08NYwIzk6+3E8vNAi9Ku4kj4guxRHJBwzavzpl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 6:16=E2=80=AFPM Shakeel Butt wrote: > > On Fri, Apr 26, 2024 at 05:51:23PM -0700, Yosry Ahmed wrote: > > On Fri, Apr 26, 2024 at 5:37=E2=80=AFPM Shakeel Butt wrote: > > > > > > At the moment, the amount of memory allocated for stats related struc= ts > > > in the mem_cgroup corresponds to the size of enum node_stat_item. > > > However not all fields in enum node_stat_item has corresponding memcg > > > stats. So, let's use indirection mechanism similar to the one used fo= r > > > memcg vmstats management. > > > > Just curious, does the indirection table cause any noticeable > > performance impact? My guess is no, but the update paths are usually > > very performance sensitive. > > > > I guess lkp will shout at us if there are any noticeable regressions. > > Yeah and that is the reason I made the indirection table smaller (i.e. > int8_t) to keep more entries in a single cacheline. Thanks for pointing this out, probably worth including in the commit log :)