From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E028C4338F for ; Thu, 29 Jul 2021 17:25:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F9FD600EF for ; Thu, 29 Jul 2021 17:25:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F9FD600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 298878D0001; Thu, 29 Jul 2021 13:25:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 248DB6B005D; Thu, 29 Jul 2021 13:25:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 137288D0001; Thu, 29 Jul 2021 13:25:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id ECA066B0036 for ; Thu, 29 Jul 2021 13:25:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9D377181C34F4 for ; Thu, 29 Jul 2021 17:25:53 +0000 (UTC) X-FDA: 78416302986.20.E9A1C05 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 4DF2E1928 for ; Thu, 29 Jul 2021 17:25:53 +0000 (UTC) Received: by mail-il1-f177.google.com with SMTP id h18so6683177ilc.5 for ; Thu, 29 Jul 2021 10:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1TJn11KWxh6Ms0mK4tEBNoyeY+OXDD+P+VEKQkQD+NY=; b=gArWMxjXXqu1OGyaMxDZQLC7i3MHPcCwF64UUfAPXyDJCorXxfzg5a5vysUeCi0oTs 7wFR6iAl9vrkIiIim8d796MbceV1SQt3ohDK1ASDKT6JrvVjxpWxD8wEaGlV/tnO57t3 RmC0xlJtZW/UDFxt5uAXeyNkypjdqlbCYCZn4FR/6qqp4gdTPuPWTE8T6vE1kiYtNXZv UZfE+jUng3gWHY8JQ1PLBmsioi9bcfuEB7t/MyPzXlGUYCT8EjD1ypK1T7hGkc5P3te4 4YwtB2Au81Hle8YpONuLo35dtXRlJUYybfoeR6F2rTFIP6zhpArk30NC+p/P0VeWvg2P ejaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1TJn11KWxh6Ms0mK4tEBNoyeY+OXDD+P+VEKQkQD+NY=; b=LaL4kNBepAYCKU8FaBsNDhJ7VekWv6H5uGX+SDJluUm1okEkrcyuFKT0FSVFI1YD0C +PzlHGW73KNys0y9+H0u6iFBcdpb+n7ZzGjreSsaGrgo47mh0Iu5sm/WNleQmMX+I9xI hACtZXp8tTtlucLA4J3kPXfl8dOFYhgizC6XtMIO8jdenM1k76inxn9XYarosKGkmKPf VQqio7ChR75EQwXSTSKuY2nlpL2gTQxtYz4bqtJR9AqpAmOXYQQlrGuPMKc5hE0WJhIJ 18R3eHhjBgoMTFA8Nvtaw8ZOfLTJXyByZ3DK+xUeiSAAY+JiRcx5JXfVUbxoufmRHHIS cTtg== X-Gm-Message-State: AOAM531q7vBRJlDb86tjkw9hSFSUTLDAU9Jxixl0iEMSssb/YM2eJd8A 2Ubdtqz6BqIiiFTu6lDK3qY4OiTSaLiwbxtEpGEy5g== X-Google-Smtp-Source: ABdhPJxBgdfROfnlNJH7EqhAkcAqMv7RaO3xL0u4dbECwCJh6xgg0R0BASRody0t0fg1QO6ecx070wnnTrtihecu8Do= X-Received: by 2002:a92:6503:: with SMTP id z3mr4427664ilb.258.1627579552466; Thu, 29 Jul 2021 10:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20210729092831.38106-1-ligang.bdlg@bytedance.com> In-Reply-To: <20210729092831.38106-1-ligang.bdlg@bytedance.com> From: Axel Rasmussen Date: Thu, 29 Jul 2021 10:25:16 -0700 Message-ID: Subject: Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk To: Gang Li Cc: Steven Rostedt , Ingo Molnar , Andrew Morton , Vlastimil Babka , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=gArWMxjX; spf=pass (imf22.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-Stat-Signature: 1sogaxi6czh978xdc8knax7786f3wy9i X-Rspamd-Queue-Id: 4DF2E1928 X-HE-Tag: 1627579553-266294 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Axel Rasmussen On Thu, Jul 29, 2021 at 2:28 AM Gang Li wrote: > > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > > Signed-off-by: Gang Li > --- > include/trace/events/mmap_lock.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h > index 0abff67b96f0..5f980c92e3e9 100644 > --- a/include/trace/events/mmap_lock.h > +++ b/include/trace/events/mmap_lock.h > @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s success=%s\n", > + "mm=%p memcg_path=%s write=%s success=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false", > @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > -- > 2.20.1 >