From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C64C43461 for ; Tue, 27 Apr 2021 17:03:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F22AB60240 for ; Tue, 27 Apr 2021 17:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F22AB60240 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 629A76B0075; Tue, 27 Apr 2021 13:03:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6014C6B0078; Tue, 27 Apr 2021 13:03:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A2376B0082; Tue, 27 Apr 2021 13:03:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 30C556B0075 for ; Tue, 27 Apr 2021 13:03:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D828A82499A8 for ; Tue, 27 Apr 2021 17:03:56 +0000 (UTC) X-FDA: 78078769272.22.83C0D97 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf10.hostedemail.com (Postfix) with ESMTP id 5701640002D7 for ; Tue, 27 Apr 2021 17:03:46 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id b10so2536483iot.4 for ; Tue, 27 Apr 2021 10:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GR5JD0ns+pkMtnVUKEORcsBQhRfif8pxVKBIY8qVHxA=; b=QmLHoLcsn+BCVDfzUQrjwg8Xy2xVvUXFxBBU5ft+H64o4TFVvBIXxXHuqOMECGEcTO dtvozDEMUp4GFivPJePB0PbkV52eNybLkucfQwmJgQrhAYuEEpl8ey6u5rr7froL9831 wYVyAxisrA82rOkudABuC3U8PenfOlk7D+S7mAqWQheynJuG+L6t550RQN2xH3AtQmcj YZOVPtow4jaHCIeBDjTYIj5/8GSNps1Fuw/jToYXPcH3cgKCRyqq/rZVHA/3bXXQ2Nve 2ueglmp/SjvnojiN9svPkpekJLSz97FI7Aop3wlrKzIy55Bwfsy6mB/auPJu3BpBHN4P BL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GR5JD0ns+pkMtnVUKEORcsBQhRfif8pxVKBIY8qVHxA=; b=h2e0REZIubwfuIeXeDnawQs6LOgVZL6WxisLuTiYLGlP1KGTyT4/7F1d4mR7gIxd2V g+E/Tyo3oP8VPkupHmWWpSvwe0WEUDQ1d0zSU+5JCFHrjYqhBaFdimWcCH1FUlrY54NN mDzrnqVjl0n/iIIc6rf1+9mRQ4mU0bc/vbBRx2TeRob044z2n1LEZsMR+OqYerAcpdnU kiqmfh/Fl5Cj+c8e48k3wwctF3sIy/R9ppWMfPT3YGrL6GylKim6z/9KLivUioct1Bii VykK34eQ5LU8NAXMRwTTo4230Yaz3cnDPOAGpVPaBL7kWR91kegbuV2TUjroUf/XYxyz rijg== X-Gm-Message-State: AOAM531c88oOWjj5oDNSDgtydus3l+c4D1gJPypMBVIFCsiGz904Nk5H bOLGsyj7X9Td9WhIJucv+fTos548dR7PhR3XmiEAHw== X-Google-Smtp-Source: ABdhPJwulj3vaxVO0sHbkW6fF/E/7qJzf+HEs1+HRhzpNXwno9kM3bLiLURQiT9BXMHQwBaFd9a8rHY/eeZXQQ4/jXo= X-Received: by 2002:a5d:9682:: with SMTP id m2mr20925814ion.20.1619543035845; Tue, 27 Apr 2021 10:03:55 -0700 (PDT) MIME-Version: 1.0 References: <20210420220804.486803-1-axelrasmussen@google.com> <20210420220804.486803-5-axelrasmussen@google.com> <20210427155713.GC6820@xz-x1> In-Reply-To: <20210427155713.GC6820@xz-x1> From: Axel Rasmussen Date: Tue, 27 Apr 2021 10:03:20 -0700 Message-ID: Subject: Re: [PATCH v4 04/10] userfaultfd/shmem: support minor fault registration for shmem To: Peter Xu Cc: Hugh Dickins , Alexander Viro , Andrea Arcangeli , Andrew Morton , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, LKML , linux-kselftest@vger.kernel.org, Linux MM , Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 5qo1pyuqqermhp836gc9gzi1x46xxaed X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5701640002D7 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-io1-f53.google.com; client-ip=209.85.166.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619543026-187966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ah yes, I should have modified the commit message when I swapped them the first time - sorry for overlooking it. As I said in the other thread, unless someone strongly objects I'll just re-order them the other way around, minor faults first and then CONTINUE, which resolves this concern at least. I'm not too worried about leaving them split. Clearly we'll never release a kernel with one but not the other. So the only scenario I can imagine is, bisecting. But, bisecting across the range where UFFD shmem minor faults were introduced, if you're using that feature, won't really work out well no matter what we do. If you aren't using this feature explicitly, then any of the configurations we've talked about are fine. On Tue, Apr 27, 2021 at 8:57 AM Peter Xu wrote: > > On Mon, Apr 26, 2021 at 07:23:57PM -0700, Hugh Dickins wrote: > > On Tue, 20 Apr 2021, Axel Rasmussen wrote: > > > > > This patch allows shmem-backed VMAs to be registered for minor faults. > > > Minor faults are appropriately relayed to userspace in the fault path, > > > for VMAs with the relevant flag. > > > > > > This commit doesn't hook up the UFFDIO_CONTINUE ioctl for shmem-backed > > > minor faults, though, so userspace doesn't yet have a way to resolve > > > such faults. > > > > > > Acked-by: Peter Xu > > > Signed-off-by: Axel Rasmussen > > > > And if this "04/10" had been numbered 03/10, I would have said > > Acked-by: Hugh Dickins > > > > Just read the comment above: "so userspace doesn't yet have a way to > > resolve such faults" - if it doesn't by this stage, we're in trouble. > > Right, so merging the two patches might be easier. Even if we don't merge > them, we'll need to touch up the commit message since at least above paragraph > is not true anymore as we've already have UFFDIO_CONTINUE. Thanks, > > -- > Peter Xu >