From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72CFC433E0 for ; Sat, 30 Jan 2021 08:09:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 575D964E04 for ; Sat, 30 Jan 2021 08:09:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 575D964E04 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4770B8D0002; Sat, 30 Jan 2021 03:09:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 428438D0001; Sat, 30 Jan 2021 03:09:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33E478D0002; Sat, 30 Jan 2021 03:09:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 1FF9D8D0001 for ; Sat, 30 Jan 2021 03:09:23 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D474B181AEF07 for ; Sat, 30 Jan 2021 08:09:22 +0000 (UTC) X-FDA: 77761716564.12.cub75_0615f2c275af Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id B1FB11800E90C for ; Sat, 30 Jan 2021 08:09:22 +0000 (UTC) X-HE-Tag: cub75_0615f2c275af X-Filterd-Recvd-Size: 3991 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Sat, 30 Jan 2021 08:09:22 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id x21so11881704iog.10 for ; Sat, 30 Jan 2021 00:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9pF2wojN9gGVpEFLc3F0it5xrHpu2kN/KdpA0MJ6RRs=; b=fnhBSwX5/funsUDXajW4rsV1DPuOtzdpPVFrrcZ7ZMfWXoAeoHwqG62GCWubZMAoO/ WVsQkz/fgBe0lB+kjGwAn7NC3ZTrpr/1JqvAhuckNwCOVDVaOxgVteTivcXu/VfyV+HB xV2sdAnYnK6XNxLyHR+flGg3Rxu9hokL4Out5EHGPEVJIFxVmEe/J+BTEHO1UkcFHWpH 5WmzqOWwKTych2E0F1xSAv3Gcg6r46sR1xGhprCCB5DUpXn9A5++f0m94sbx48b+Qn4i 0tpIonQC0LaZFGZslUb9q59oqeRK6WHOoLDpSkLxGBXs97FqtbU1X5MbERrR4jq3WxS4 obrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9pF2wojN9gGVpEFLc3F0it5xrHpu2kN/KdpA0MJ6RRs=; b=gDDetp4sZ6YL4DRIr1Y8gzKb+IMMKrM6QPNJtXNCKctBBTcnqwCOHqD3SntyIHDtfC HWBuVAY6h7oO3BixUT51RM+WRTupC/lNeMp6WgoO47PLkKKVJ/2usUXB+xLcPSmKbDGW zTpvyiIL327hcDRHgcCGEg2jb5HiskuU1wvk8tSztXTppKdr77qoS9qJa3sBGRxOiqvZ zkPPzRT9LhTLaevHS3exRwGMbECJqOGtZ8AjFpC7lXDVGYlMYbFz4TcmjhEVE2WTRnws CxTstElJZ0BhWHTgPz8/X/CHErdcN+V/XfIdPZlL8ieN4Wr3I3YLIKegRvQsIp9JsYtr ExKg== X-Gm-Message-State: AOAM530BOAVPnkvQw1MZ1FcNJSc+JythwHgl2kOvVnKDj4fwtYhEXQFg trE0TXNjpD2AFZqY0oE4PZjkQctbs2+HUosT0iRI4Q== X-Google-Smtp-Source: ABdhPJzcXsnhwrs8IODBKuA1fG8zEHE9zE9u9Tep93UhkLINan8bZibM1PZuW7Lqh3yLrlxyHgcrmC28NFD25q1CXUY= X-Received: by 2002:a05:6602:2053:: with SMTP id z19mr178334iod.86.1611994161568; Sat, 30 Jan 2021 00:09:21 -0800 (PST) MIME-Version: 1.0 References: <20210115170907.24498-1-peterx@redhat.com> <20210115170907.24498-22-peterx@redhat.com> <20210129223129.GB260413@xz-x1> In-Reply-To: <20210129223129.GB260413@xz-x1> From: Axel Rasmussen Date: Sat, 30 Jan 2021 00:08:44 -0800 Message-ID: Subject: Re: [PATCH RFC 21/30] hugetlb: Pass vma into huge_pte_alloc() To: Peter Xu Cc: LKML , Linux MM , Mike Rapoport , Mike Kravetz , Jerome Glisse , "Kirill A . Shutemov" , Hugh Dickins , Matthew Wilcox , Andrew Morton , Andrea Arcangeli , Nadav Amit Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 29, 2021 at 2:31 PM Peter Xu wrote: > > On Thu, Jan 28, 2021 at 02:59:13PM -0800, Axel Rasmussen wrote: > > > +pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma, > > > > This was pointed out to me just after I sent v3 of my series today > > (which includes this patch): > > > > Typo, s/structt/struct/. > > Thanks Axel - fixed here too. It's strange why it didn't complain. > > Re the minor fault series, I thought it would be good to have some comment from > Andrea/Mike or others, but in all cases I'll read your v3 next week. > > (A small heads-up: you'd better use v3.1 next time for that single patch, so > that just in case there will be a complete v4 series then that patch won't > collapse with it) Thanks! And, I'll keep that in mind for next time. I had seen it done that way before, but it slipped my mind. > > -- > Peter Xu >