From: Axel Rasmussen <axelrasmussen@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Matthew Wilcox <willy@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH v2 0/4] hugetlb: Disable huge pmd unshare for uffd-wp
Date: Thu, 18 Feb 2021 10:54:41 -0800 [thread overview]
Message-ID: <CAJHvVcjgAEk8ABkE0LC=OBsbQYACet7ui6ELqerx-v6KGB+tsg@mail.gmail.com> (raw)
In-Reply-To: <20210217204418.54259-1-peterx@redhat.com>
I reviewed these patches, rebased my minor fault handling series on
top of this series, and then ran some stress tests of minor fault
handling. Other than the one comment I left about !CONFIG_CMA, I
didn't spot any issues. So:
Tested-By: Axel Rasmussen <axelrasmussen@google.com>
(Or Reviewed-By: , if that makes more sense.)
On Wed, Feb 17, 2021 at 12:44 PM Peter Xu <peterx@redhat.com> wrote:
>
> v2:
> - patch 4: move hugetlb_unshare_all_pmds() into mm/hugetlb.c, so it can be used
> even outside userfaultfd.c
>
> This series tries to disable huge pmd unshare of hugetlbfs backed memory for
> uffd-wp. Although uffd-wp of hugetlbfs is still during rfc stage, the idea of
> this series may be needed for multiple tasks (Axel's uffd minor fault series,
> and Mike's soft dirty series), so I picked it out from the larger series.
>
> References works:
>
> Uffd shmem+hugetlbfs rfc:
> https://lore.kernel.org/lkml/20210115170907.24498-1-peterx@redhat.com/
>
> Uffd minor mode for hugetlbfs:
> https://lore.kernel.org/lkml/20210212215403.3457686-1-axelrasmussen@google.com/
>
> Soft dirty for hugetlbfs:
> https://lore.kernel.org/lkml/20210211000322.159437-1-mike.kravetz@oracle.com/
>
> Please review, thanks.
>
> Peter Xu (4):
> hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()
> hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled
> mm/hugetlb: Move flush_hugetlb_tlb_range() into hugetlb.h
> hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp
>
> arch/arm64/mm/hugetlbpage.c | 7 ++-
> arch/ia64/mm/hugetlbpage.c | 3 +-
> arch/mips/mm/hugetlbpage.c | 4 +-
> arch/parisc/mm/hugetlbpage.c | 2 +-
> arch/powerpc/mm/hugetlbpage.c | 3 +-
> arch/s390/mm/hugetlbpage.c | 2 +-
> arch/sh/mm/hugetlbpage.c | 2 +-
> arch/sparc/mm/hugetlbpage.c | 1 +
> fs/userfaultfd.c | 4 ++
> include/linux/hugetlb.h | 16 +++++-
> include/linux/userfaultfd_k.h | 9 ++++
> mm/hugetlb.c | 94 +++++++++++++++++++++++++++--------
> mm/userfaultfd.c | 2 +-
> 13 files changed, 114 insertions(+), 35 deletions(-)
>
> --
> 2.26.2
>
>
next prev parent reply other threads:[~2021-02-18 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 20:44 [PATCH v2 0/4] hugetlb: Disable huge pmd unshare for uffd-wp Peter Xu
2021-02-17 20:44 ` [PATCH v2 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share() Peter Xu
2021-02-17 20:46 ` [PATCH v2 2/4] hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled Peter Xu
2021-02-17 20:46 ` [PATCH v2 3/4] mm/hugetlb: Move flush_hugetlb_tlb_range() into hugetlb.h Peter Xu
2021-02-17 20:46 ` [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp Peter Xu
2021-02-18 1:46 ` Mike Kravetz
2021-02-18 17:55 ` Peter Xu
2021-02-18 18:32 ` Axel Rasmussen
2021-02-18 20:32 ` Peter Xu
2021-02-18 20:34 ` Axel Rasmussen
2021-02-18 20:41 ` Peter Xu
2021-02-18 1:34 ` [PATCH v2 2/4] hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled Mike Kravetz
2021-02-18 18:54 ` Axel Rasmussen [this message]
2021-02-18 20:33 ` [PATCH v2 0/4] hugetlb: Disable huge pmd unshare for uffd-wp Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJHvVcjgAEk8ABkE0LC=OBsbQYACet7ui6ELqerx-v6KGB+tsg@mail.gmail.com' \
--to=axelrasmussen@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).