From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF465C4338F for ; Thu, 29 Jul 2021 17:28:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4EFCE6052B for ; Thu, 29 Jul 2021 17:28:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EFCE6052B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D1C3D6B0036; Thu, 29 Jul 2021 13:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCC4A8D0002; Thu, 29 Jul 2021 13:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBB0D6B006C; Thu, 29 Jul 2021 13:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id A53F46B0036 for ; Thu, 29 Jul 2021 13:28:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 48C6982499A8 for ; Thu, 29 Jul 2021 17:28:48 +0000 (UTC) X-FDA: 78416310336.22.463982D Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 086029000664 for ; Thu, 29 Jul 2021 17:28:47 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id z7so7302724iog.13 for ; Thu, 29 Jul 2021 10:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3FtzGKwABQo72/dMQleZZDertRJDDXn2wvynHfmBqH8=; b=YzPmZW5EZSwHZDq92FKwxPy69FMJ+2vDI4hnu59VWRFvOaa3lNGNbNgT+IyKNgor4g YuFsHIuTnutoXdkfl9dzUEYBWK78CV7QVbLzWbxajuDW324SdTapaHIpxUc51060I2Q5 z1y1UhU2h7Z6oRZ1u2DHd+Uexq5xVre4jISJnvr0Qzp62Km0hIczN2r+0R9bOqN/kA0u 5VyhURGkV3umzSqPV8SotzGVVstK7AqlWhd90kjOMJDlPllUOSrEzCuAen/5FgQbYvbW JPQOAlRZLxfxbdyO1Gw/FmNrTc0Z8tSl00ZMrDomLjUQJpUOrDAV+FLF2trTXRsYIG8K rCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3FtzGKwABQo72/dMQleZZDertRJDDXn2wvynHfmBqH8=; b=YT3NpuZ/qupLS/EZGHB/fZ1844DU4y3pwlEsHWhJy9N0p63jHkAF9DRACt6YYU/uJK jXj95GZRqwpWxEE5DzDHYZkx0yx0NMWoRrSnkD4LU3EFk3G/hkCjhIPQb4mH1hXlqBsg 5xsdImEP1IU8DkNU/rw+3yNooPCcF//ITfkc4Qr7Dg0/NMNEsgoybv7N7vT6nEeW1oW2 5pTdKpBsDBO4OKjG9pC0Z9rT4qhS0vvadQ6aIdRvuBKJwaWG/Jvr1B7dnGxTldA4VLZ7 NesVH07/6HmrNVGka1PVTNMYUSOdwGQOJZLuIoYZmYDbnPqOBHtRBOjKoMyAzM/I83NA Dq7g== X-Gm-Message-State: AOAM533rfQTp+riF55wcHNfmOAWc2DImRH7PnwOPAE/rb9y30JKKeQP7 Viu1rLOOjUadGrJlitj9ExmiXyfhM7nL6tn7W1/xSg== X-Google-Smtp-Source: ABdhPJwfYweaYZvTqmLoiQYvOqERUYEe8DE+aZWTwo/E3l/mFh8dV39ZuZUZ/gGUmFu6jGbTlSHuHO37HIaWI5xKqzk= X-Received: by 2002:a05:6638:3a12:: with SMTP id j18mr5500606jaj.75.1627579726879; Thu, 29 Jul 2021 10:28:46 -0700 (PDT) MIME-Version: 1.0 References: <20210729092841.38175-1-ligang.bdlg@bytedance.com> In-Reply-To: <20210729092841.38175-1-ligang.bdlg@bytedance.com> From: Axel Rasmussen Date: Thu, 29 Jul 2021 10:28:11 -0700 Message-ID: Subject: Re: [PATCH 2/3] mm: mmap_lock: use DECLARE_EVENT_CLASS and DEFINE_EVENT_FN To: Gang Li Cc: Steven Rostedt , Ingo Molnar , Andrew Morton , Vlastimil Babka , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 086029000664 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=YzPmZW5E; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Stat-Signature: bqxxy4ika5g55dr89cw9eedr3qnjboqr X-HE-Tag: 1627579727-511428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Axel Rasmussen On Thu, Jul 29, 2021 at 2:28 AM Gang Li wrote: > > By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot > of space from duplicate code. > > Signed-off-by: Gang Li > --- > include/trace/events/mmap_lock.h | 44 +++++++++----------------------- > 1 file changed, 12 insertions(+), 32 deletions(-) > > diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h > index 5f980c92e3e9..b9dd66f9c226 100644 > --- a/include/trace/events/mmap_lock.h > +++ b/include/trace/events/mmap_lock.h > @@ -13,7 +13,7 @@ struct mm_struct; > extern int trace_mmap_lock_reg(void); > extern void trace_mmap_lock_unreg(void); > > -TRACE_EVENT_FN(mmap_lock_start_locking, > +DECLARE_EVENT_CLASS(mmap_lock, > > TP_PROTO(struct mm_struct *mm, const char *memcg_path, bool write), > > @@ -36,11 +36,19 @@ TRACE_EVENT_FN(mmap_lock_start_locking, > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > - ), > - > - trace_mmap_lock_reg, trace_mmap_lock_unreg > + ) > ); > > +#define DEFINE_MMAP_LOCK_EVENT(name) \ > + DEFINE_EVENT_FN(mmap_lock, name, \ > + TP_PROTO(struct mm_struct *mm, const char *memcg_path, \ > + bool write), \ > + TP_ARGS(mm, memcg_path, write), \ > + trace_mmap_lock_reg, trace_mmap_lock_unreg) > + > +DEFINE_MMAP_LOCK_EVENT(mmap_lock_start_locking); > +DEFINE_MMAP_LOCK_EVENT(mmap_lock_released); > + > TRACE_EVENT_FN(mmap_lock_acquire_returned, > > TP_PROTO(struct mm_struct *mm, const char *memcg_path, bool write, > @@ -73,34 +81,6 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, > trace_mmap_lock_reg, trace_mmap_lock_unreg > ); > > -TRACE_EVENT_FN(mmap_lock_released, > - > - TP_PROTO(struct mm_struct *mm, const char *memcg_path, bool write), > - > - TP_ARGS(mm, memcg_path, write), > - > - TP_STRUCT__entry( > - __field(struct mm_struct *, mm) > - __string(memcg_path, memcg_path) > - __field(bool, write) > - ), > - > - TP_fast_assign( > - __entry->mm = mm; > - __assign_str(memcg_path, memcg_path); > - __entry->write = write; > - ), > - > - TP_printk( > - "mm=%p memcg_path=%s write=%s", > - __entry->mm, > - __get_str(memcg_path), > - __entry->write ? "true" : "false" > - ), > - > - trace_mmap_lock_reg, trace_mmap_lock_unreg > -); > - > #endif /* _TRACE_MMAP_LOCK_H */ > > /* This part must be outside protection */ > -- > 2.20.1 >