From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36970C433DB for ; Thu, 28 Jan 2021 10:21:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90CE364DD8 for ; Thu, 28 Jan 2021 10:21:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90CE364DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCFA96B0005; Thu, 28 Jan 2021 05:21:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7F646B0006; Thu, 28 Jan 2021 05:21:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B701F6B006C; Thu, 28 Jan 2021 05:21:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 9EFFA6B0005 for ; Thu, 28 Jan 2021 05:21:50 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5FB6233C4 for ; Thu, 28 Jan 2021 10:21:50 +0000 (UTC) X-FDA: 77754792780.20.star61_35185fd2759e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 32F8C180C07A3 for ; Thu, 28 Jan 2021 10:21:50 +0000 (UTC) X-HE-Tag: star61_35185fd2759e X-Filterd-Recvd-Size: 5157 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 10:21:49 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id s2so4677838otp.5 for ; Thu, 28 Jan 2021 02:21:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HDfQ7EgSz4He6IVrUzqy89nGy356H19n/4Ap6Knawyw=; b=G4CmkrqeR50f0yeMUAZoLF79yd1rcSZhLta31rwkfb1kPw4cTn2U+HrK9/QXP1hoKp 7xxQg5FDZ3UJ5JLqOHkbXgM83gadN/ffZVHGtBefCfprC86v7Sgi1oxVnSYlxnp5xV+C cGmU4LJJBh+PxWm2A8zv7XVYHozHTP95++DTIXZokMSk3XS/yWQQUV6sBh9k4o6HADV/ J982/G+mxBI47zLYyMZCehSzfalh7WDk9a8EBny9GkqcWZXPqXPXJVQqWbeNGUcz5Gvn ssfyrYBpCe6DehUUY3rGm+J+pVlw/q1gXvhixh5P0LnXWZm1pM+L35a+OKaBfaIQvALZ BLjg== X-Gm-Message-State: AOAM531BCA17jR+RdytQ3swbT/3hlxvGTOeS3d0Vq1yCWFOqVfN+oYo5 2fVoQ2gV/t28KU/udlL86ukt0oWuHs7epjYseA0= X-Google-Smtp-Source: ABdhPJwJviHVEMHN6dwg9pHl9sFzPeOTWi/Tyw7MUMRzUkqGbWVHXybuLc31QSYFbmu849bxozre+7WWIBRJddZRpNc= X-Received: by 2002:a05:6830:2313:: with SMTP id u19mr11117098ote.321.1611829309173; Thu, 28 Jan 2021 02:21:49 -0800 (PST) MIME-Version: 1.0 References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> In-Reply-To: <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> From: "Rafael J. Wysocki" Date: Thu, 28 Jan 2021 11:21:36 +0100 Message-ID: Subject: Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io To: Chaitanya Kulkarni Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, Linux Kernel Mailing List , drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme , "open list:TARGET SUBSYSTEM" , target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, Linux PM , Linux Memory Management List , Jens Axboe , Philipp Reisner , Lars Ellenberg , Konrad Rzeszutek Wilk , roger.pau@citrix.com, Minchan Kim , ngupta@vflare.org, Sergey Senozhatsky , Alasdair Kergon , Mike Snitzer , Christoph Hellwig , Sagi Grimberg , "Martin K. Petersen" , Al Viro , "Ted Ts'o" , jaegeuk@kernel.org, Eric Biggers , djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, Mark Fasheh , Joel Becker , Joseph Qi , damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Andrew Morton , Hannes Reinecke , "Gustavo A. R. Silva" , Takashi Iwai , Alex Shi , asml.silence@gmail.com, Ming Lei , Tejun Heo , osandov@fb.com, Bart Van Assche , jefflexu@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 28, 2021 at 8:21 AM Chaitanya Kulkarni wrote: > Please explain in the changelog why making this change is a good idea. > Signed-off-by: Chaitanya Kulkarni > --- > kernel/power/swap.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t page_off, void *addr, > struct hib_bio_batch *hb) > { > struct page *page = virt_to_page(addr); > + sector_t sect = page_off * (PAGE_SIZE >> 9); > struct bio *bio; > int error = 0; > > - bio = bio_alloc(GFP_NOIO | __GFP_HIGH, 1); > - bio->bi_iter.bi_sector = page_off * (PAGE_SIZE >> 9); > - bio_set_dev(bio, hib_resume_bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio = bio_new(hib_resume_bdev, sect, op, op_flags, 1, > + GFP_NOIO | __GFP_HIGH); > > if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) { > pr_err("Adding page to bio failed at %llu\n", > -- > 2.22.1 >