linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: gaowei Pu <pugaowei@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org
Subject: Re: [PATCH] mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area
Date: Sat, 12 Oct 2019 17:41:58 +0800	[thread overview]
Message-ID: <CAJdJevVqbD9GTXLtAe_Yyz-b_Tchz5pWmmBVDiP-DVpT26j1Jg@mail.gmail.com> (raw)
In-Reply-To: <20191011191906.9901e400a98f78a9b8652aeb@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Andrew Morton <akpm@linux-foundation.org> 于2019年10月12日周六 上午10:19写道：

>
> ./include/linux/err.h:22:49: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>  #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned
> long)-MAX_ERRNO)
>                                                  ^
> ./include/linux/compiler.h:78:42: note: in definition of macro unlikely
>  # define unlikely(x) __builtin_expect(!!(x), 0)
>                                           ^
> mm/mmap.c:3006:6: note: in expansion of macro IS_ERR_VALUE
>   if (IS_ERR_VALUE(error))
>
>
Thanks for your review.
I will send a v2.

[-- Attachment #2: Type: text/html, Size: 1108 bytes --]

      reply	other threads:[~2019-10-12  9:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10  3:31 [PATCH] mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area Gaowei Pu
2019-10-12  2:19 ` Andrew Morton
2019-10-12  9:41   ` gaowei Pu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJdJevVqbD9GTXLtAe_Yyz-b_Tchz5pWmmBVDiP-DVpT26j1Jg@mail.gmail.com \
    --to=pugaowei@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).