From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87CEC4360C for ; Sat, 12 Oct 2019 09:42:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 431BD2087E for ; Sat, 12 Oct 2019 09:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PdtpK7ez" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 431BD2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 740936B0003; Sat, 12 Oct 2019 05:42:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F1F06B0005; Sat, 12 Oct 2019 05:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 606EC8E0001; Sat, 12 Oct 2019 05:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 38F396B0003 for ; Sat, 12 Oct 2019 05:42:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id AA889181AEF31 for ; Sat, 12 Oct 2019 09:42:10 +0000 (UTC) X-FDA: 76034641620.13.cover68_30143f4669341 X-HE-Tag: cover68_30143f4669341 X-Filterd-Recvd-Size: 5153 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sat, 12 Oct 2019 09:42:10 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id n197so26660790iod.9 for ; Sat, 12 Oct 2019 02:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5isT5A8DuYZ7qMgJu60jCwARJ0W1ktZVMgtc5OCLwiY=; b=PdtpK7ezyMC6WQR9QAo0SR+uCDsP5ChRoHa3pqPCLTT05tdqZ+ZdE/oeFpUybp9Z5C Ri6oOoqGM+YDdlFWlFN+p0HBx4raVDx2T7qkfNSoixeQTTKQeIjCjpQkQhganlDDrdVf ptws1ehB6a+ttjOnevN1NtkRpRWZwvhf32Amq+ntRouzR2ghYFYM8ih3Bl1Xz4jgjG4r LNu+Az0ovF/COBQ3ouA6ErObRdymyAmYr5Pu2t9Hekih82cY387W9leJxWDj2HvViGV3 JDL9piiiTe53fM+BXxuaPEJIvzWGQ2Y1A+PqzK5ZX36iIvy7hY+ny/hR9zU3+5x1Rw1s WAYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5isT5A8DuYZ7qMgJu60jCwARJ0W1ktZVMgtc5OCLwiY=; b=P2+2+vRmdmS/y7kNWaGrxxCdwXrFuqXrLQzWcpBHLGE5BjdS8726Z8rtPMbxC0v6ku OY3nnKoWNdUXEavlu26PGLhREoFYDHcCVz/cnLBxHlv/+muaOMFNkAiIuYK4oHjD3LLt 4TKQjdaHIYi+/KNbOR8m/J3fdXM5ifYJ5YZt2mjAGPzRMRdkgcG9ORkIyQ7cu+t1Vwdj S4JpdULYSYo3Zw3Y31FnO8sYsYPVVURNc/o6RIvJvXPkG1/6wsc+8Gp7g353OoWRWQCw QXPaRikIxJdcnWt3h2t1oRFC1EDsMR+YVd/T+q8Yq7kyw5Oku3M4genukp4tbQtkTwYN DFsg== X-Gm-Message-State: APjAAAUoh5vboX+Tm17GGdGhdPaADTlsOFB/hO0tKpyjjPEMtmipVyjL 7TvLqkcb/AFaFgnn+8/dh4L9csJV0kgAlXUY+do= X-Google-Smtp-Source: APXvYqwb0DDMgNwkxbMgqJpMgSci8qb7tA6RvPbHtKVb+XEFKxwhBolPzf93OSHZjl2A7IcIYn3De7musjke3RQNqos= X-Received: by 2002:a05:6638:a0e:: with SMTP id 14mr23520660jan.4.1570873329326; Sat, 12 Oct 2019 02:42:09 -0700 (PDT) MIME-Version: 1.0 References: <20191010033117.22294-1-pugaowei@gmail.com> <20191011191906.9901e400a98f78a9b8652aeb@linux-foundation.org> In-Reply-To: <20191011191906.9901e400a98f78a9b8652aeb@linux-foundation.org> From: gaowei Pu Date: Sat, 12 Oct 2019 17:41:58 +0800 Message-ID: Subject: Re: [PATCH] mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area To: Andrew Morton Cc: Vlastimil Babka , linux-mm@kvack.org Content-Type: multipart/alternative; boundary="000000000000c81c950594b372a3" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000766, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000c81c950594b372a3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Andrew Morton =E4=BA=8E2019=E5=B9=B410=E6=9C=88= 12=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=8810:19=E5=86=99=E9=81=93=EF= =BC=9A > > ./include/linux/err.h:22:49: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >=3D (unsign= ed > long)-MAX_ERRNO) > ^ > ./include/linux/compiler.h:78:42: note: in definition of macro unlikely > # define unlikely(x) __builtin_expect(!!(x), 0) > ^ > mm/mmap.c:3006:6: note: in expansion of macro IS_ERR_VALUE > if (IS_ERR_VALUE(error)) > > Thanks for your review. I will send a v2. --000000000000c81c950594b372a3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Andrew Morton <akpm@linux-foundation.org> =E4=BA=8E2019= =E5=B9=B410=E6=9C=8812=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=8810:19= =E5=86=99=E9=81=93=EF=BC=9A

./include/linux/err.h:22:49: warning: cast to pointer from integer of diffe= rent size [-Wint-to-pointer-cast]
=C2=A0#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >=3D (= unsigned long)-MAX_ERRNO)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0^
./include/linux/compiler.h:78:42: note: in definition of macro unlikely
=C2=A0# define unlikely(x) __builtin_expect(!!(x), 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^=
mm/mmap.c:3006:6: note: in expansion of macro IS_ERR_VALUE
=C2=A0 if (IS_ERR_VALUE(error))


Thanks for your review.
I will send a v2.
=C2=A0
--000000000000c81c950594b372a3--