From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55042C636CC for ; Wed, 1 Feb 2023 00:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DA2B6B0074; Tue, 31 Jan 2023 19:04:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 895046B0075; Tue, 31 Jan 2023 19:04:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752806B0078; Tue, 31 Jan 2023 19:04:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 65A686B0074 for ; Tue, 31 Jan 2023 19:04:03 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 380D84015C for ; Wed, 1 Feb 2023 00:04:03 +0000 (UTC) X-FDA: 80416775166.29.D1C4D61 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 80B082001A for ; Wed, 1 Feb 2023 00:04:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kjgH2CMP; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675209841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZUycsi7Qy1G+kA/BDKEqAynjD+S1ub0yGcBr2S1csDg=; b=X75/I/FypD2erkToCunNexmPQb9OJgGDy4aAkKo71VlmneA18Nd1LDPUnGGvas3eG5Rl9U wkZ2Knwtfpsbg5FZPfIhA4pJLXDq8anYjX1GqnEjB9IzcSjSj/DMNO7AP1ii30GQxjwWNN AQvwpBD3uSEKm65BM7j6r02TOojjIuo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kjgH2CMP; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675209841; a=rsa-sha256; cv=none; b=DSMikcfvGr07wfd1iRK/1O+XWcCyWDikqxAjqxJEL3b8lc8DGmGU0LApPW/npZdTDOnXu6 LAB+AuqD4VsJN8uPa4qfshm+/bOAKwru05m04dbTEAo5oIoK/PbJ9zHxhDN/UzKj7xlLNm xjqF7uQHWPD/kyHmo0eX4rmnuoLiJnY= Received: by mail-yb1-f174.google.com with SMTP id o187so3846584ybg.3 for ; Tue, 31 Jan 2023 16:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZUycsi7Qy1G+kA/BDKEqAynjD+S1ub0yGcBr2S1csDg=; b=kjgH2CMPcbJUL89I13duLHr/x00EFsX3fEJyRMjgA3lmo+3BlhNvsXihc340eh4Mo2 xJLlakMeru4DhNc2LQ7VdXDjksVjD8J95ylIlceJjZjmLcziSrIGjflqo01hf0aIuPRr /Tm7tSWg1BzuIO5SMCXWDrfUCKN94wOyzFfYw06eAp4JwvSUDIkxnWZVGG8jazLCRLQ4 fy9jQY5nCrkr6ftTyn2XwMB2wYenW9lk/kPwLomUt2hRm3TEP3rTyKcgDtcfIeERobCm uThPnsvu8qu2+2UDFWG+LRF+g46vJaxVjEr6TrfgDRaIL6R7vK5wPEjDj7fJztXMnUO3 CX+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZUycsi7Qy1G+kA/BDKEqAynjD+S1ub0yGcBr2S1csDg=; b=8N8yJF0wrtWjLcbAexphspv8YGmrfW3AT1JckSKhCKBz2uIH1rlXnG1jVJSg/MdtSM 150W5Fg+oXr+CizMt16u4cpdOyfzgCk9ObPxb3SfWBHm0M71ISWQyqPbh0wnV8DEyTzB jhh6e53smk2sxyLYa8LkrPaiJXJrlzEFVscLf7PyUBxQU2f2CyR0BO0xmQ1ojRBOzTdT VBvL60uU2yXNqpOix5Eo89kzgC342tuOOWvzR1jI0tIhQqev63S9QfH7wy4SGMVqk7EZ X8F9b6ww663PfsVSBPqN61z/31O6HufjGEHjghmklDxm9eByIRrlnTHiJdzRNR0ZRA/W fCRg== X-Gm-Message-State: AO0yUKUiNKyIpjRIqxOfb0sFp9/EDd69YukTkatU/tWr3zpvReoPcRfh B0nqh85HSZPoMkdug4GUAB8hjJGNMXoUwDtccM28lQ== X-Google-Smtp-Source: AK7set8i/R4jubc4/eBLZr1C2uot2lhviGeGxjdH9LtwH5rX8BcQ29iFG2gEY6poGbAAfxlHLKG4eGpFSJTOl8lO5k0= X-Received: by 2002:a25:2441:0:b0:80b:5988:2045 with SMTP id k62-20020a252441000000b0080b59882045mr107656ybk.59.1675209840310; Tue, 31 Jan 2023 16:04:00 -0800 (PST) MIME-Version: 1.0 References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> <20230131151209.d53ba65c3c065979808d9912@linux-foundation.org> In-Reply-To: <20230131151209.d53ba65c3c065979808d9912@linux-foundation.org> From: Suren Baghdasaryan Date: Tue, 31 Jan 2023 16:03:49 -0800 Message-ID: Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls To: Andrew Morton Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 80B082001A X-Stat-Signature: g6nx3ibbafg9ah9598m1q9qzkqxpwc9g X-Rspam-User: X-HE-Tag: 1675209841-869951 X-HE-Meta: U2FsdGVkX1+foJZigSh1gr9squ5eNBDUv/sA+/b3yLN7LLfLNSn/OgJ4PpmtAlU+aPFuL+dyxrUG0hU+Ya8oB6nawnusc/dXpLIWnSAid+TjLDoHqeoDjuFn/J2721X1/Kdx1guYuAu9qA4BQANiNzk6uMvZk+5LerxZk4nIUF6YGrjx9T7bVVIoOYPI+WNXYLvPoAWCnGOgGfPt5xuUYky1JipvnyWpyksOk+zwThBKjeeeOwsg2I67r19KwABq1FSEER3gW2z24V8fExOsB/HmsBWTNS4XOK5ioy5r9dFi3qpym7988QPcDzKDdpzLjS0/MPFLF8VPpYMttxRrou9jcga/ddU/k0dLIJCoFZGJ6qH7SUTxukLNOSqDMZ4QGmx3+qy1UzZZ6QrkoNVLTYOsVKibQZR5VLfN157te4iY9pJRt/MAos7Dbk4YNEWtC/OO3JD9RhxQT/mVn8hjP3Fhl3HSZlDRys9kVGwjS6aN8fCKltCUf1+pWBHtIx8QHMEVYkGsYxk2NTo63Il0P0tYgbaDuzzzqMmggTlSXe3ME6syqH81aJAj+o3RogMg8VRqdlLmRzS56gw76sJnBXhGktESsCQmAn6ra7yydgmsWEJCwt4PFJVXwE0kN3735SPPyh5nTLcRJkCphUIRvhN+slIxA2+cYlpyF6gJH6/hgXOu1KUmRWQeL+9tPczoFrw0EcY0A+uJFkUyObob+XXZ7kmpGUoSaWHbUkmFGqMr6/UBdWXZZ7R5KFWvGXyYGFjeLO3/an09moqPNtz/xRO3dsyGivvrnbzNRE1QJCX/Iq5UrcEUFQR155BUKlGDAAFkNOblTl83zf8Tt5THLbFuVyvSvk3SRpoGzFzKYkxDGZptUTu4vrMxEjxDrPM/04y0xDAJiLyMkLZdfxoGa4LO1vqd+sFSzS0GoKy/MOKn9SnuaeHjsd8dQtKlKtfXgORx6mmgo2+lcfQN86V Hqr3Yjc6 yWrBTRbU5MSFSvV1Epu9nd//9ekAil8txqIDCvlXbligChvjRu74zWbvqUPpZaO8A1izVE9sxtTrEcOKU82nnciJ9rXOp9Gjx3YW4qaKHHFBTUPayYbbIOrWKNtjOzbWXgR+DBcv1M6ev5k97L4JkqDhOBCV0syogWUFFXNvhILw47G9NkCnSq1O3l5vLNjfWCUCQpVmVYXighpEGJbHc4XMPQ1kcEbbV0EpXr+zYHS3kUdFzMQxeGJ2rGJxGxy/fpdGH7IXyVDjU1FpXwIjSsW3kbvVFZnXV5xe+D99nv72tr+ix5rb/bhDGLymbZ3+nGCsOjNwLWUKggOMwLmIz0C/+bjAjxMzk+l4gapJsmZgVxQNQD9vO/ewQXZ++r+iYvC7WCRbbuACX/ZAPWzfOzkA8cf7HjZqhEfM0xx+KmNb4KC7/9E/cIaiVXSCXSShsky8TPxDQdkmKYb4L0eqYGbAxxsV6e65trHKJsflfAEdNgHqO7M+GNGe69NkWUHHOeebD9AnxS37Mb7DGKkOqRuh4NbvCVUZ1GBg3R4dU5kkfWf8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 3:12 PM Andrew Morton wrote: > > On Tue, 31 Jan 2023 13:08:19 -0800 Suren Baghdasaryan wrote: > > > On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton > > wrote: > > > > > > On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan wrote: > > > > > > > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > > > > } > > > > > > > > > > I think it should be: > > > > > s/VM_MAYSHARE/VM_MAYWRITE/ > > > > > > > > > > I added the fixup. Much better than resending a seven patch series for a > > > single line change. Unless you have substantial other changes pending. > > > > Thanks! That sounds reasonable. > > > > I'll also need to introduce vm_flags_reset_once() to use in > > replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send > > a separate short patch for that? > > That depends on what the patch looks like. How about you send it > and we'll see? Here it is: https://lore.kernel.org/all/20230201000116.1333160-1-surenb@google.com/ > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >