From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725D9C433E0 for ; Thu, 16 Jul 2020 02:50:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D25F2076C for ; Thu, 16 Jul 2020 02:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FVon6Pb3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D25F2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 843798D0009; Wed, 15 Jul 2020 22:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CC588D0003; Wed, 15 Jul 2020 22:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 693CB8D0009; Wed, 15 Jul 2020 22:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 50B4C8D0003 for ; Wed, 15 Jul 2020 22:50:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D8B29181AC9C6 for ; Thu, 16 Jul 2020 02:50:04 +0000 (UTC) X-FDA: 77042409528.17.alarm30_4b08b0b26efe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id A880E180D018B for ; Thu, 16 Jul 2020 02:50:04 +0000 (UTC) X-HE-Tag: alarm30_4b08b0b26efe X-Filterd-Recvd-Size: 4391 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 02:50:04 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id x13so2183046vsx.13 for ; Wed, 15 Jul 2020 19:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WEKmkAw0uwcvvBEVpu10W/Sa5gQp5k7qXmo5AR9AurA=; b=FVon6Pb3ZKgtvlu6hExXOR+GxSVISq63TByCX4gSkKOhQlnbEzC4eSF6fOoXpDTtq0 pQY3Vxm7slt/77qZ7EjB8PYM7R7tPC2UnR3whxkMhALBsJPZm2mtqNBNYJ50MId7sz/U VnFSnIlZpMtl294S/qgEb0x4zixD73XKt8NlreDpuTshjgFnl7ORvOC8c6e7j0POYBwS AyyyoLhV+/agwsr3q70DWj82Eymx6336qEJaKKGTYOvPmsSVlF4I4ZURExC+91VAkSYE 8GCvhcqpaZV5yPhIUU4To8aSIbgvsvoMJhg0JwOeryqCUOrOUaBendC536fqgWMM5yGf ZwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WEKmkAw0uwcvvBEVpu10W/Sa5gQp5k7qXmo5AR9AurA=; b=qe7s8gaANT/i3uJqmtzCTDnFEw7MF7cVh4vy97dY6xR7h9r7LLMNKF8pYZycEY8xgx V8rI5r1dSp1d2Zh+IY2QfqjTt9XKnQEH3qpoKtn6dKgfpUdpirk+/fxL9D1OOOkUGwmn UALVcofKtBQi39HsaWfHb0X65aWScPaGKBqDU+4mUs5anVFfWglOSuQv4okzgaYuaq5c bd9bA1pECF8WejpDJ7uLcpA2DWaEKCCOI4dDGQQNFjfk5TtgzLDBSRoqtMLmRp1/q2O9 63EF3qwb7QtG1I/grbizyCh3/GDdSbWRTOuhTLyWMnPK0+QjiD7IzjwLhnAgX3gis174 5XTQ== X-Gm-Message-State: AOAM530mRHfmJX/spihaNLrKSqBvRXXvMSCQu5rByh8eTOBnXOodmvGt 5t0Q4Muur2pW28CGMs8ZXlg3Oa0j/InWQh8fBhSI/Q== X-Google-Smtp-Source: ABdhPJwxCXQz0WoadyQHNKpsbOvxJMTRPicLoxVEytHah6x5/VcIKiVX4ciSJ6j/Gj2uPkLh6VB0DKXak2Z5ddYHgFM= X-Received: by 2002:a67:6441:: with SMTP id y62mr1679674vsb.82.1594867803345; Wed, 15 Jul 2020 19:50:03 -0700 (PDT) MIME-Version: 1.0 References: <0000000000000b5f9d059aa2037f@google.com> <20200714033252.8748-1-hdanton@sina.com> <20200714053205.15240-1-hdanton@sina.com> <20200714140859.15156-1-hdanton@sina.com> <20200714141815.GP24642@dhcp22.suse.cz> <20200715063639.GA5451@dhcp22.suse.cz> In-Reply-To: <20200715063639.GA5451@dhcp22.suse.cz> From: Suren Baghdasaryan Date: Wed, 15 Jul 2020 19:49:52 -0700 Message-ID: Subject: Re: possible deadlock in shmem_fallocate (4) To: Michal Hocko Cc: Todd Kjos , Hridya Valsaraju , Hillf Danton , Eric Biggers , syzbot , Andrew Morton , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Christian Brauner , "open list:ANDROID DRIVERS" , Greg Kroah-Hartman , Hugh Dickins , "Joel Fernandes (Google)" , LKML , Linux-MM , Martijn Coenen , syzkaller-bugs , Todd Kjos , Markus Elfring Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A880E180D018B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 14, 2020 at 11:36 PM Michal Hocko wrote: > > On Tue 14-07-20 10:32:20, Suren Baghdasaryan wrote: > [...] > > I'm not sure how we can annotate the fact that the inode_lock in > > generic_file_write_iter and in shmem_fallocate always operate on > > different inodes. Ideas? > > I believe that the standard way is to use lockdep_set_class on your > backing inode. But asking lockdep experts would be better than relying > on my vague recollection Thanks Michal! I think https://lkml.org/lkml/2020/7/15/1390 should fix it, however I was unable to reproduce the lockdep warning to confirm that this warning gets fixed by the patch. > > -- > Michal Hocko > SUSE Labs