From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A377AC4338F for ; Mon, 2 Aug 2021 22:16:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50D0960EC0 for ; Mon, 2 Aug 2021 22:16:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50D0960EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B8D306B0033; Mon, 2 Aug 2021 18:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B16488D0001; Mon, 2 Aug 2021 18:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6716B005D; Mon, 2 Aug 2021 18:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 7D4C96B0033 for ; Mon, 2 Aug 2021 18:16:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3C4C31F379 for ; Mon, 2 Aug 2021 22:16:40 +0000 (UTC) X-FDA: 78431550960.08.BF0E96F Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf23.hostedemail.com (Postfix) with ESMTP id 03D619001B31 for ; Mon, 2 Aug 2021 22:16:39 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id z128so4432093ybc.10 for ; Mon, 02 Aug 2021 15:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aVGojMx+DUr0Bkpg2GauKzHjG+QgnSZtH0f6WVA+GT0=; b=By54SS2dwDkwJGwhuIY8NsqezsY4v2SSiJz/qQ9prW1GHhN67KM613ArcrnWbfN29w 66vJKXYIXsQWnaTR7h1Zg/CFtOpvRzaM6jlIwcaNF46QV77I8s1SYBSas/aRaxTzZw9Q r5kcuWovT3l/xOkysf+JSJWN36GqoJxKjj8NvWoeAnhIirN6HY4zI3YG1GX4M6EB0jLA /n+GC3iP+r/Rv7q99K2vr6rxpb/M6LHy6+9m/dE7gM9Pa6wvZ262dyGCi6FvoYRW7OZi VuDuagjPRdTAPq4VP9znMB0RCmC61qRMholJzB5mVVtKwzz41MR9B6NTx5+ss6GAmQ3K QCsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aVGojMx+DUr0Bkpg2GauKzHjG+QgnSZtH0f6WVA+GT0=; b=EXi9cs/d/zDaPDpTTbh6m43yq7QTzvCcqaoR4xBT00p2SLgmYH+UOvtn4PxA9KlEdh i4grODXmYreFSoFh9ON0qN5xKns2oRi11etLSMJTdKZsyNimHW65ACgH2x6y4RnK3GKs xgzo8LyhKeyCbEGRlNKHqFj0L+9JZbN5/l0SE2SAieohMDZI1K5+nJHH1/gHsCG+Yusi B/EpVADf3Td+CsK700JEVxsjBkLl4YuJb61/QUvxjxi/2luR7cwRIbP42l0rez3vlxYy kHV9IgwlNuLvVG34MlhsOo9EiVC50bGszLHeu3yCrgxht9L7X/vh64fO9JYgDEwD8mTt D9bQ== X-Gm-Message-State: AOAM531t+6xDn82EkRBC1yprQ1Fio6773W56IQ1wKhPyRsJ1XXf+pHNJ wg36inuwuaHNUoiwhU3QtCTXPla+HyGOwdrRvTkT1Q== X-Google-Smtp-Source: ABdhPJznsVErJkSBK2mP8Pgp6BYYOZiuyhX+5Nzyp4ctrjdWEjLWT0m8oePoA6y1TBwFp0C7H8pMMC76CRg5lw9NzP0= X-Received: by 2002:a25:7ec4:: with SMTP id z187mr24318844ybc.136.1627942599134; Mon, 02 Aug 2021 15:16:39 -0700 (PDT) MIME-Version: 1.0 References: <20210723011436.60960-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 2 Aug 2021 15:16:27 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: introduce process_mrelease system call To: Shakeel Butt Cc: Michal Hocko , Andrew Morton , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 03D619001B31 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=By54SS2d; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=surenb@google.com X-Stat-Signature: yuan5t5nyyp4q7chduqdo8oygngmned6 X-HE-Tag: 1627942599-863689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 2, 2021 at 1:08 PM Suren Baghdasaryan wrote: > > On Mon, Aug 2, 2021 at 1:05 PM Shakeel Butt wrote: > > > > On Mon, Aug 2, 2021 at 12:54 PM Suren Baghdasaryan wrote: > > > > > > On Mon, Jul 26, 2021 at 6:44 AM Shakeel Butt wrote: > > > > > > > > On Mon, Jul 26, 2021 at 12:27 AM Michal Hocko wrote: > > > > > > > > > [...] > > > > > > > > > > Is process_mrelease on all of them really necessary? I thought that the > > > > > primary reason for the call is to guarantee a forward progress in cases > > > > > where the userspace OOM victim cannot die on SIGKILL. That should be > > > > > more an exception than a normal case, no? > > > > > > > > > > > > > I am thinking of using this API in this way: On user-defined OOM > > > > condition, kill a job/cgroup and unconditionally reap all of its > > > > processes. Keep monitoring the situation and if it does not improve go > > > > for another kill and reap. > > > > > > > > I can add additional logic in between kill and reap to see if reap is > > > > necessary but unconditionally reaping is more simple. > > > > > > > > > > > > > > > An alternative would be to have a cgroup specific interface for > > > > > > reaping similar to cgroup.kill. > > > > > > > > > > Could you elaborate? > > > > > > > > > > > > > I mentioned this in [1] where I was thinking if it makes sense to > > > > overload cgroup.kill to also add the SIGKILLed processes in > > > > oom_reaper_list. The downside would be that there will be one thread > > > > doing the reaping and the syscall approach allows userspace to reap in > > > > multiple threads. I think for now, I would go with whatever Suren is > > > > proposing and we can always add more stuff if need arises. > > > > > > > > [1] https://lore.kernel.org/containers/CALvZod4jsb6bFzTOS4ZRAJGAzBru0oWanAhezToprjACfGm+ew@mail.gmail.com/ > > > > > > Hi Folks, > > > So far I don't think there was any request for further changes. > > > Anything else you would want me to address or are we in a good shape > > > wrt this feature? > > > If so, would people who had a chance to review this patchset be > > > willing to endorse it with their Reviewed-by or Acked-by? > > > > I think with Michal's suggestion to use a killable mmap lock, at least > > I am good with the patch. > > Ah, yes. Thanks for pointing this out! I'll replace mmap_read_lock() > with mmap_read_lock_killable(). Will post an updated version later > today. Posted the next version at https://lore.kernel.org/patchwork/patch/1471403/