From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E76C4338F for ; Fri, 23 Jul 2021 04:48:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39F5960E96 for ; Fri, 23 Jul 2021 04:48:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39F5960E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 744D86B005D; Fri, 23 Jul 2021 00:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F68B6B006C; Fri, 23 Jul 2021 00:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E47F6B0070; Fri, 23 Jul 2021 00:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 41F1B6B005D for ; Fri, 23 Jul 2021 00:48:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E6143181AEF39 for ; Fri, 23 Jul 2021 04:48:09 +0000 (UTC) X-FDA: 78392620698.21.9022010 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 90629D05AE69 for ; Fri, 23 Jul 2021 04:48:09 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id w17so421603ybl.11 for ; Thu, 22 Jul 2021 21:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xlcZWcz4mdXUCoyHWgDwvx+q9rKyJhhgsoTYgw/NZo=; b=oA1SmkgwMTcifFRajFNWyJOtAcePH1ew06mG3n1aRUwn01UQO7hc6QD1Wr8ChVWU+N 7jAMMJmNXRO+NqIRdihpRp5RotBJGYcd/jVD9ENlNBYE5B1LBWRLqXUP8kH+Cx+XCU0Q 0/hipn2fp5646D8z+7YcZmgtRtxnJDgy89zezIN6RMVBhoa/OY/kft8lBmSIxPZz0bl/ X/Yje6IANDPwMTfbeMTDQ4UP0SdnjVApPZtmpzSNJLj8dlTfpd/joUSdqY3jcd/kt4yI 3GtAYgZ84oSgr0ZXaOxHN2IlxSyDkOPk+vY58e+zgX3ogg6VH1tqH1TGvi+Xix6nCdka BmJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xlcZWcz4mdXUCoyHWgDwvx+q9rKyJhhgsoTYgw/NZo=; b=eRvOecyzyT2Pk6baronKToy6Bd1NV1W1qWZF5sX8zYOfZF/ifRRCyNeDvLcOn/gY+n iHX6CO3dtV/dCle72mPJr7T5/nP41JH7wpg63glG1/RRMi7+SFw4v1sTSAPymjqNeoRs Ea1P7yeUpYOZUsVywim1s+dSlgnVDtNN98V+27sWDsDUqumqNE68c5XM7wx+KqJTiuDo oCE4abj25HqgORYJH6jO8dwtSFjyRoLBi4Ta5xI00Nje6rkrd9kgYUWjPDkI5Cg/55st AgxjS1nWnbk72Siw9VfmWwH8YNBHr5A8KU9f0t07hFMeH6bUoLf+FKRu07wNMhL34La9 mKXQ== X-Gm-Message-State: AOAM533sHzaRJ6JnXPIS4YoyFeiKWCQkWzNG8nTnPtJcFeOLETf1ZGh+ fON/ABQK493Xe/LkxzjdI7IiUh0jXlMIQb72mSXTow== X-Google-Smtp-Source: ABdhPJwfmwRMayUbqTEaDMkJHqCPwbu7ecES2BrJ3mN0H8k9pCHWrDqjz2GeDbC6F7TZDFKndFXyuVeUBUIrvLRZqw4= X-Received: by 2002:a25:ba08:: with SMTP id t8mr3987910ybg.111.1627015688504; Thu, 22 Jul 2021 21:48:08 -0700 (PDT) MIME-Version: 1.0 References: <20210723011436.60960-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 22 Jul 2021 21:47:56 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: introduce process_mrelease system call To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: multipart/alternative; boundary="00000000000029313f05c7c31c1c" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 90629D05AE69 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=oA1Smkgw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com X-Stat-Signature: x9ti198jgwyako4ifd7wbaqtkpabaxhu X-HE-Tag: 1627015689-801253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --00000000000029313f05c7c31c1c Content-Type: text/plain; charset="UTF-8" On Thu, Jul 22, 2021, 7:04 PM Shakeel Butt wrote: > On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan > wrote: > > > [...] > > + > > + mmap_read_lock(mm); > > How about mmap_read_trylock(mm) and return -EAGAIN on failure? > That sounds like a good idea. Thanks! I'll add that in the next respin. > > > + if (!__oom_reap_task_mm(mm)) > > + ret = -EAGAIN; > > + mmap_read_unlock(mm); > > + > --00000000000029313f05c7c31c1c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jul 22, 2021, 7:04 PM Shakeel Butt <shakeelb@google.com> wrote:
On Thu, Jul 22, 2021 at 6:14 PM Suren Baghd= asaryan <surenb@google.com> wrote:
>
[...]
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0mmap_read_lock(mm);

How about mmap_read_trylock(mm) and return -EAGAIN on failure?

That sounds l= ike a good idea. Thanks! I'll add that in the next respin.




> +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!__oom_reap_task_mm(mm))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D -EAGAI= N;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0mmap_read_unlock(mm);
> +
--00000000000029313f05c7c31c1c--