From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5052C6377B for ; Wed, 21 Jul 2021 20:59:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 462436120A for ; Wed, 21 Jul 2021 20:59:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 462436120A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5D206B0036; Wed, 21 Jul 2021 16:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0E9B6B006C; Wed, 21 Jul 2021 16:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD4DE6B0070; Wed, 21 Jul 2021 16:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id A03A66B0036 for ; Wed, 21 Jul 2021 16:59:57 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4913A1850E6B5 for ; Wed, 21 Jul 2021 20:59:57 +0000 (UTC) X-FDA: 78387812034.26.0E3E235 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf29.hostedemail.com (Postfix) with ESMTP id DCAA9901E0CB for ; Wed, 21 Jul 2021 20:59:56 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id i18so5100003yba.13 for ; Wed, 21 Jul 2021 13:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zev5RkUDntkX6kWICmg9oLGVZwQDp/V6CB2SFJXvlbM=; b=MbUup/f2IQ4e5MYXEyQSpJT9BA/5+K1mBDGxRAU/j8XHmKaNWC16053kMEmyaCPWU0 6X5d7gRKAa/dn9sXGMMonqNVZSQYg+FgMrgm/oDLmrFHHR6ryPTk24OjWuqiUkf9JhlW PLjjQ9c7rg4CcEE7sbk2wPUqHfE4u7dcmZIHR68kECpIWmNrF1e+HavOLMMowGahLl1N kGlsYJAhDLNMrqMEj2DACIl6eethtxavpitbs31H1qNkaE1Gra0Ryy7rqC6tnXd9j2JL 7GKz6SzksiLzhiITrFIqLM+x66LPrPtZYXLKfOTn1rDr0ivJKphsFhfY2vy2DTZWrCSf Kz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zev5RkUDntkX6kWICmg9oLGVZwQDp/V6CB2SFJXvlbM=; b=sNvMQmWhUvfNyVkrOIqiip8ulryLQuUATyiP2U5GyHQPWECFK61ANXX202l+qFjNrD G2zOnIJR4nCA4fXmEmPWTP6RvRqBFpc15VBtBX3v/Taz+sTeemoxzhRp53P03MajBUtc DNoqXRbIQqNjTDtcZpwztslDv1ctOpyjXZK6uaeHOQOa0d/8rlvNfo/8pu7yiVJr+Zu8 ZKihfReGVmGXt3UVRQPAj2qnUjOyaF4EBi8zvDmoL+npnMU+AdgXiG6oR5+qtd/MxGDx QgogqMJGJnSatWGvsK+Hfu3YUsVZY2Qz+Gy/pfJ4rQEyJssCziXS+deY89jNEiweamE+ VWNw== X-Gm-Message-State: AOAM53207BHUh79ZNYXtzz04Iz4tNj21v/Tule9mzE7Iz50fb3ND+tvJ FHQcBqOa+9sgARhiDw04FXz+1hRwuGmTI4SIkXMxVQ== X-Google-Smtp-Source: ABdhPJxPA+1Lvr6r0Ah+Ih16Hp1gDj0q96HTIeJShNuvXV8XbMIS4BZvdwqDvpclVoKXHc0q16IfDXSgqc30JARLqDQ= X-Received: by 2002:a25:d912:: with SMTP id q18mr44064581ybg.294.1626901195909; Wed, 21 Jul 2021 13:59:55 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 21 Jul 2021 13:59:44 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease To: Andrew Morton Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="MbUup/f2"; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DCAA9901E0CB X-Stat-Signature: gppgybo48meh7r3t8pkkguceconn4wgf X-HE-Tag: 1626901196-639434 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 21, 2021 at 1:51 PM Andrew Morton wrote: > > On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > > > This would not require moving other functions. > > > > Would that be better than the current approach or the forward declaration? > > > > > > IMHO that could be an easy, possible alternative. > > > > Andrew, others? Should I follow this path instead? > > Whatever you prefer ;) I understand David's concern too well to ignore it, so I prefer to follow this middle-ground approach if you don't mind :)