From: Suren Baghdasaryan <surenb@google.com>
To: Michal Hocko <mhocko@suse.com>
Cc: linux-man@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jann Horn" <jannh@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Jeffrey Vander Stoep" <jeffv@google.com>,
"Minchan Kim" <minchan@kernel.org>,
"Shakeel Butt" <shakeelb@google.com>,
"David Rientjes" <rientjes@google.com>,
"Edgar Arriaga García" <edgararriaga@google.com>,
"Tim Murray" <timmurray@google.com>,
linux-mm <linux-mm@kvack.org>,
"SElinux list" <selinux@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>,
"Linux API" <linux-api@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team <kernel-team@android.com>
Subject: Re: [PATCH 1/1] process_madvise.2: Add process_madvise man page
Date: Mon, 25 Jan 2021 16:14:00 -0800 [thread overview]
Message-ID: <CAJuCfpGu_x4vxXejTUfD4Mjun=qJOsdoRs42gQhiv30EnED=nA@mail.gmail.com> (raw)
In-Reply-To: <20210125131935.GI827@dhcp22.suse.cz>
On Mon, Jan 25, 2021 at 5:19 AM 'Michal Hocko' via kernel-team
<kernel-team@android.com> wrote:
>
> On Wed 20-01-21 12:23:37, Suren Baghdasaryan wrote:
> [...]
> > MADV_COLD (since Linux 5.4.1)
> > Deactivate a given range of pages by moving them from active to
> > inactive LRU list. This is done to accelerate the reclaim of these
> > pages. The advice might be ignored for some pages in the range when it
> > is not applicable.
>
> I do not think we want to talk about active/inactive LRU lists here.
> Wouldn't it be sufficient to say
> Deactive a given range of pages which will make them a more probable
> reclaim target should there be a memory pressure. This is a
> non-destructive operation.
That sounds better. Will update in the next version.
>
> Other than that, looks good to me from the content POV.
>
> Thanks!
Thanks for the review Michal!
> --
> Michal Hocko
> SUSE Labs
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>
next prev parent reply other threads:[~2021-01-26 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 20:23 [PATCH 1/1] process_madvise.2: Add process_madvise man page Suren Baghdasaryan
2021-01-25 13:19 ` Michal Hocko
2021-01-26 0:14 ` Suren Baghdasaryan [this message]
2021-01-28 12:24 ` Michael Kerrisk (man-pages)
2021-01-28 18:40 ` Suren Baghdasaryan
2021-01-28 20:31 ` Michael Kerrisk (man-pages)
2021-01-28 20:37 ` Suren Baghdasaryan
2021-01-29 7:15 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpGu_x4vxXejTUfD4Mjun=qJOsdoRs42gQhiv30EnED=nA@mail.gmail.com' \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=edgararriaga@google.com \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
--cc=selinux@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).