From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F032AC433E0 for ; Mon, 11 Jan 2021 17:06:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C0F122AAD for ; Mon, 11 Jan 2021 17:06:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C0F122AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB1846B00AE; Mon, 11 Jan 2021 12:06:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D61176B00B1; Mon, 11 Jan 2021 12:06:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C50746B00B2; Mon, 11 Jan 2021 12:06:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 9E3096B00AE for ; Mon, 11 Jan 2021 12:06:19 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 360CA181AEF10 for ; Mon, 11 Jan 2021 17:06:19 +0000 (UTC) X-FDA: 77694122478.28.wish60_14135922750e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id B0FF15DD5 for ; Mon, 11 Jan 2021 17:05:50 +0000 (UTC) X-HE-Tag: wish60_14135922750e X-Filterd-Recvd-Size: 4692 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 17:05:50 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id v14so454650wml.1 for ; Mon, 11 Jan 2021 09:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zHu1ckVRAMWx4RepAlDhc0i4dSbBejVwjp9wkCsGwWQ=; b=U8DCHxOZsNnXyHsqGt/aEYsvKCWeeNiemmjB41i5nfiN+qhhV7UhvWucy4ZZ50W9ya zKysXo93jowfFFeokf0s7lG6rUakqE5kd4+DIk3XeUI36UidX0kc5ti1qRvvCgO9UO2x hVPp85Jhh4Gm7ZelMM25WPtS/jQSC3s95fnmdSfFQMjFuZEKGaO5AO9uEASvwk/Xfn8z +VjqUJXYp3t6IpE1sBc3MFGU/NsX2HFZL0Ff9MqF+LiUYQp2t9JXTlbkYyYTvEB/OzhZ mpPlpyGqFACMFjZgtADlHwln/yvk6eFkGGVyuPBvaBIlfDJo8hEO+EtFZ6IJVKxpdUye t33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zHu1ckVRAMWx4RepAlDhc0i4dSbBejVwjp9wkCsGwWQ=; b=lpr11Oz2gnlgn1Qm1HJp8zw/5ViABQlUp5cJzbfd5m5mkLXg4G+935GM/Xhw+Tcmvo HNAEWrAyPZarD4lF1c6rIazn7cI3aWb1ZfpyQ1MHikeuDsaJXKsb44dx4gvp8Q2pjj97 4ibDm55pm0llys6/r3CIKqL4HDBt+dYekuVUGwuJJ4ywlMV3rgJOKTg7J713hpLZ1zxE mJWwYQuq1oGKui6L9I+Mn1og1TSW/OTcXya4ex/HAQHeD0QWrcYlMfsipwNDIYcnVIj9 XVhpuUo1ZXmOuBB1Apvnod39XbIRYChNga49K15X0Ivwn3+FSFT3kShQyLlRK7loUNHz zksA== X-Gm-Message-State: AOAM530MjJuIf3fqrWV4j2QzXs+KbCfOcvD6QudGz+EnU35MkkwPSYYi AJUar4N3CxPIl/ovL1WagNsdnevfnZbqSmYa9xlKBg== X-Google-Smtp-Source: ABdhPJwuNTuUcYaBZ08xd/Ii7ZYohmL1BPrUHr53gbc0AGN0DmQFWjIcA/QD16dFhDbX+aMkVap0PfDnmCDOKrzq9QY= X-Received: by 2002:a7b:cc94:: with SMTP id p20mr612383wma.22.1610384748638; Mon, 11 Jan 2021 09:05:48 -0800 (PST) MIME-Version: 1.0 References: <20210108205857.1471269-1-surenb@google.com> <875z43rd0u.fsf@oldenburg2.str.redhat.com> In-Reply-To: <875z43rd0u.fsf@oldenburg2.str.redhat.com> From: Suren Baghdasaryan Date: Mon, 11 Jan 2021 09:05:37 -0800 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: replace ptrace attach requirement for process_madvise To: Florian Weimer Cc: Andrew Morton , Jann Horn , Kees Cook , Jeffrey Vander Stoep , Minchan Kim , Michal Hocko , Shakeel Butt , David Rientjes , =?UTF-8?Q?Edgar_Arriaga_Garc=C3=ADa?= , Tim Murray , linux-mm , selinux@vger.kernel.org, Linux API , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 2:20 AM Florian Weimer wrote: > > * Suren Baghdasaryan: > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 6a660858784b..c2d600386902 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -1197,12 +1197,22 @@ SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec, > > goto release_task; > > } > > > > - mm = mm_access(task, PTRACE_MODE_ATTACH_FSCREDS); > > + /* Require PTRACE_MODE_READ to avoid leaking ASLR metadata. */ > > + mm = mm_access(task, PTRACE_MODE_READ_FSCREDS); > > if (IS_ERR_OR_NULL(mm)) { > > ret = IS_ERR(mm) ? PTR_ERR(mm) : -ESRCH; > > goto release_task; > > } > > Shouldn't this depend on the requested behavior? Several operations > directly result in observable changes, and go beyond performance tuning. Thanks for the comment Florian. process_madvise supports only MADV_COLD and MADV_PAGEOUT hints which are both non-destructive (see process_madvise_behavior_valid() function). Maybe you meant something else by "observable changes", if so please clarify. Thanks, Suren. > > Thanks, > Florian > -- > Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, > Commercial register: Amtsgericht Muenchen, HRB 153243, > Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >